Bug 150560 - [Streams API] Add close method to writable stream
Summary: [Streams API] Add close method to writable stream
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Xabier Rodríguez Calvar
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-26 09:56 PDT by Xabier Rodríguez Calvar
Modified: 2015-10-27 04:37 PDT (History)
4 users (show)

See Also:

Attachments
Patch (13.12 KB, patch)
2015-10-26 10:09 PDT, Xabier Rodríguez Calvar 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews114 for mac-yosemite (856.07 KB, application/zip)
2015-10-26 10:47 PDT, Build Bot 		no flags Details
Patch (14.18 KB, patch)
2015-10-26 11:24 PDT, Xabier Rodríguez Calvar 		no flags Details | Formatted Diff | Diff
Patch for landing (14.17 KB, patch)
2015-10-27 01:40 PDT, Xabier Rodríguez Calvar 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xabier Rodríguez Calvar 2015-10-26 09:56:12 PDT 
[Streams API] Add close method to writable stream
Comment 1 Xabier Rodríguez Calvar 2015-10-26 10:09:53 PDT 
Created attachment 264049 [details]
Patch
Comment 2 Darin Adler 2015-10-26 10:22:50 PDT 
Comment on attachment 264049 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=264049&action=review

> Source/WebCore/Modules/streams/StreamInternals.js:157
> +    // TODO

In this project we use FIXME. Lets not start also using TODO.
Comment 3 Build Bot 2015-10-26 10:47:23 PDT 
Comment on attachment 264049 [details]
Patch

Attachment 264049 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/340553

New failing tests:
streams/reference-implementation/writable-stream-abort.html
Comment 4 Build Bot 2015-10-26 10:47:26 PDT 
Created attachment 264050 [details]
Archive of layout-test-results from ews114 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 5 Xabier Rodríguez Calvar 2015-10-26 11:24:16 PDT 
Created attachment 264054 [details]
Patch

Flagged tests that are failing under certain conditions because of bug 147933 and turned TODOs into FIXMEs.
Comment 6 Xabier Rodríguez Calvar 2015-10-26 11:25:53 PDT 
(In reply to comment #5)
> Flagged tests that are failing under certain conditions because of bug
> 147933 and turned TODOs into FIXMEs.

I think that flagging the offending tests would require a new r+.
Comment 7 Xabier Rodríguez Calvar 2015-10-26 13:06:57 PDT 
(In reply to comment #6)
> (In reply to comment #5)
> > Flagged tests that are failing under certain conditions because of bug
> > 147933 and turned TODOs into FIXMEs.
> 
> I think that flagging the offending tests would require a new r+.

If Darin says nothing till tomorrow morning, I'll land this as the only change other than his suggestions is flagging the tests with the corresponding bug.
Comment 8 Xabier Rodríguez Calvar 2015-10-27 01:40:42 PDT 
Created attachment 264124 [details]
Patch for landing
Comment 9 WebKit Commit Bot 2015-10-27 04:37:43 PDT 
Comment on attachment 264124 [details]
Patch for landing

Clearing flags on attachment: 264124

Committed r191622: <http://trac.webkit.org/changeset/191622>
Comment 10 WebKit Commit Bot 2015-10-27 04:37:48 PDT 
All reviewed patches have been landed.  Closing bug.