Bug 150558 – [GTK] Allow applications to force Accelerated Compositing mode

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Mario Sanchez Prada]

As discussed in the mailing list [1], it would be nice in some cases to have a way to tell WebKit to have AC mode enabled all the time, avoiding it to having it repeateadly leaving/re-entering AC mode whenever the conditions that need to be fulfilled change.

Originally proposed as a public API, that's perhaps too much, so perhaps something simpler like recognizing a environment variable WEBKIT_FORCE_ACCELERATED_COMPOSITING would be a better option.

[1] https://lists.webkit.org/pipermail/webkit-gtk/2015-October/002448.html

[Tomas Popela]

(In reply to comment #0)
> Originally proposed as a public API, that's perhaps too much, so perhaps
> something simpler like recognizing a environment variable
> WEBKIT_FORCE_ACCELERATED_COMPOSITING would be a better option.

Wouldn't be better to use WEBKITGTK_ instead of WEBKIT_ as we are not the only WebKit port there..

[Mario Sanchez Prada]

(In reply to comment #1)
> (In reply to comment #0)
> > Originally proposed as a public API, that's perhaps too much, so perhaps
> > something simpler like recognizing a environment variable
> > WEBKIT_FORCE_ACCELERATED_COMPOSITING would be a better option.
> 
> Wouldn't be better to use WEBKITGTK_ instead of WEBKIT_ as we are not the
> only WebKit port there..

I don't have a strong opinion on this, but I think WEBKIT_ is the correct prefix here, as this causes a change in behaviour at the level of WebCore, I think, and not just in the port-specific bits.

[Carlos Garcia Campos]

We already use WEBKIT for other thinks like WEBKIT_INSPECTOR_SERVER for example. I don't think that would conflict with any other port installed anyway, since you set the variable per program, but even if it's in your env, other ports will just ignore it.

[Mario Sanchez Prada]

Created attachment 266764 [details]
Patch proposal

Attached patch proposal. I've tested this locally and seems to work as expected.

Please review, thanks!

[WebKit Commit Bot]

Comment on attachment 266764 [details]
Patch proposal

Clearing flags on attachment: 266764

Committed r193626: <http://trac.webkit.org/changeset/193626>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.