Bug 150551 - Web Inspector: Selecting child layers with keyboard causes Compositing Reason popover to become misaligned
Summary: Web Inspector: Selecting child layers with keyboard causes Compositing Reason...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-10-25 21:25 PDT by Matt Baker
Modified: 2017-10-02 16:55 PDT (History)
6 users (show)

See Also:

Attachments
[Video] Bad UI behavior (4.45 MB, video/quicktime)
2015-10-25 21:25 PDT, Matt Baker 		no flags Details
Patch (2.20 KB, patch)
2017-10-02 13:14 PDT, Ross Kirsling 		no flags Details | Formatted Diff | Diff
Patch (3.51 KB, patch)
2017-10-02 13:51 PDT, Ross Kirsling 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2015-10-25 21:25:01 PDT 
Created attachment 264033 [details]
[Video] Bad UI behavior

* SUMMARY
Selecting child layers with keyboard causes Compositing Reason popover to become misaligned.

* STEPS TO REPRODUCE
1. Inspect page with layers (apple.com)
2. Select a node with child layer data
3. Click first child layer, popup appears correctly
4. Use up/down keys to cycle child layers
  => Compositing Reason popup appears next to the wrong data grid node
Comment 1 Radar WebKit Bug Importer 2015-10-25 21:26:19 PDT 
<rdar://problem/23252697>
Comment 2 Ross Kirsling 2017-10-02 13:14:30 PDT 
Created attachment 322415 [details]
Patch
Comment 3 Ross Kirsling 2017-10-02 13:16:58 PDT 
Comment on attachment 322415 [details]
Patch

This patch fixes the issue for the Layers tab sidebar; let me know if you want to fix the legacy one.

I liked your idea on IRC about making the API less confusing, but ultimately I suppose the lesson is "don't use the `content` setter on an existing popover unless you intend to retain the position"...
Comment 4 Matt Baker 2017-10-02 13:33:48 PDT 
Comment on attachment 322415 [details]
Patch

r=me. If the fix is identical for the legacy sidebar, please make that change before landing.
Comment 5 Ross Kirsling 2017-10-02 13:51:04 PDT 
Created attachment 322427 [details]
Patch
Comment 6 Build Bot 2017-10-02 14:04:41 PDT 
Comment on attachment 322427 [details]
Patch

Rejecting attachment 322427 [details] from review queue.

ross.kirsling@sony.com does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.
Comment 7 WebKit Commit Bot 2017-10-02 16:55:23 PDT 
Comment on attachment 322427 [details]
Patch

Clearing flags on attachment: 322427

Committed r222759: <http://trac.webkit.org/changeset/222759>
Comment 8 WebKit Commit Bot 2017-10-02 16:55:24 PDT 
All reviewed patches have been landed.  Closing bug.