Bug 150551 – Web Inspector: Selecting child layers with keyboard causes Compositing Reason popover to become misaligned

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Matt Baker]

Created attachment 264033 [details]
[Video] Bad UI behavior

* SUMMARY
Selecting child layers with keyboard causes Compositing Reason popover to become misaligned.

* STEPS TO REPRODUCE
1. Inspect page with layers (apple.com)
2. Select a node with child layer data
3. Click first child layer, popup appears correctly
4. Use up/down keys to cycle child layers
  => Compositing Reason popup appears next to the wrong data grid node

[Radar WebKit Bug Importer]

<rdar://problem/23252697>

[Ross Kirsling]

Created attachment 322415 [details]
Patch

[Ross Kirsling]

Comment on attachment 322415 [details]
Patch

This patch fixes the issue for the Layers tab sidebar; let me know if you want to fix the legacy one.

I liked your idea on IRC about making the API less confusing, but ultimately I suppose the lesson is "don't use the `content` setter on an existing popover unless you intend to retain the position"...

[Matt Baker]

Comment on attachment 322415 [details]
Patch

r=me. If the fix is identical for the legacy sidebar, please make that change before landing.

[Ross Kirsling]

Created attachment 322427 [details]
Patch

[Build Bot]

Comment on attachment 322427 [details]
Patch

Rejecting attachment 322427 [details] from review queue.

[e-mail] does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.

[WebKit Commit Bot]

Comment on attachment 322427 [details]
Patch

Clearing flags on attachment: 322427

Committed r222759: <http://trac.webkit.org/changeset/222759>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.