Bug 150544 - [EFL] Fix inappropriate move semantics use in parseAndRemoveEnvironments function
Summary: [EFL] Fix inappropriate move semantics use in parseAndRemoveEnvironments func...
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joonghun Park
Depends on:
Reported: 2015-10-25 03:55 PDT by Joonghun Park
Modified: 2015-11-01 16:25 PST (History)
4 users (show)

See Also:

Patch (2.36 KB, patch)
2015-10-25 03:59 PDT, Joonghun Park
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joonghun Park 2015-10-25 03:55:13 PDT
In parseAndRemoveEnvironments function, it declares its paramerter type as rvalue.
But in ProcessLauncher::launchProcess(), the argument of parseAndRemoveEnvironments still be used after the call of the function.
Currently the rvalue is not assigned to any other variable in parseAndRemoveEnvironments,
so it doesn't lead to runtime error but use of move semantic is not appropriate semantically in this case.
Comment 1 Joonghun Park 2015-10-25 03:59:41 PDT
Created attachment 264006 [details]
Comment 2 WebKit Commit Bot 2015-11-01 16:25:05 PST
Comment on attachment 264006 [details]

Clearing flags on attachment: 264006

Committed r191868: <http://trac.webkit.org/changeset/191868>
Comment 3 WebKit Commit Bot 2015-11-01 16:25:09 PST
All reviewed patches have been landed.  Closing bug.