Bug 150530 - Make the size of the benchmark canvas adaptive to the screen size and screen resolution
Summary: Make the size of the benchmark canvas adaptive to the screen size and screen ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-10-23 21:43 PDT by Said Abou-Hallawa
Modified: 2015-11-01 01:27 PST (History)
7 users (show)

See Also:


Attachments
Patch (74.43 KB, patch)
2015-10-30 17:31 PDT, Said Abou-Hallawa
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews104 for mac-mavericks-wk2 (703.20 KB, application/zip)
2015-10-30 18:20 PDT, Build Bot
no flags Details
Patch (74.40 KB, patch)
2015-10-31 00:41 PDT, Said Abou-Hallawa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2015-10-23 21:43:14 PDT
We should have two choices for the benchmark canvas size: one for large screens and one for small screens. We should also count for Retina display. The canvas size should be doubled but scaled down 50%.
Comment 1 Radar WebKit Bug Importer 2015-10-23 21:43:49 PDT
<rdar://problem/23246659>
Comment 2 Said Abou-Hallawa 2015-10-30 17:31:31 PDT
Created attachment 264448 [details]
Patch
Comment 3 Build Bot 2015-10-30 18:20:05 PDT
Comment on attachment 264448 [details]
Patch

Attachment 264448 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/360730

New failing tests:
animations/multiple-backgrounds.html
Comment 4 Build Bot 2015-10-30 18:20:08 PDT
Created attachment 264454 [details]
Archive of layout-test-results from ews104 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 5 Said Abou-Hallawa 2015-10-31 00:41:49 PDT
Created attachment 264468 [details]
Patch
Comment 6 Darin Adler 2015-10-31 14:47:28 PDT
Comment on attachment 264468 [details]
Patch

rs=me
Comment 7 WebKit Commit Bot 2015-11-01 01:27:37 PST
Comment on attachment 264468 [details]
Patch

Clearing flags on attachment: 264468

Committed r191853: <http://trac.webkit.org/changeset/191853>
Comment 8 WebKit Commit Bot 2015-11-01 01:27:41 PST
All reviewed patches have been landed.  Closing bug.