WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
150520
Fix CMake compile error and add correct null check
https://bugs.webkit.org/show_bug.cgi?id=150520
Summary
Fix CMake compile error and add correct null check
Alex Christensen
Reported
2015-10-23 16:59:31 PDT
Fix CMake compile error and add correct null check
Attachments
Patch
(1.53 KB, patch)
2015-10-23 16:59 PDT
,
Alex Christensen
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Alex Christensen
Comment 1
2015-10-23 16:59:49 PDT
Created
attachment 263961
[details]
Patch
WebKit Commit Bot
Comment 2
2015-10-23 18:12:20 PDT
Comment on
attachment 263961
[details]
Patch Clearing flags on attachment: 263961 Committed
r191528
: <
http://trac.webkit.org/changeset/191528
>
WebKit Commit Bot
Comment 3
2015-10-23 18:12:24 PDT
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 4
2015-10-24 13:47:04 PDT
Comment on
attachment 263961
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=263961&action=review
> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:3217 > - typeof(updateBlock) updateBlockCopy = nil; > + void (^updateBlockCopy)(void) = nil;
How is this a “CMake” compile error? Since CMake is not a C compiler, I don’t understand how using CMake causes this to be a compile error when it’s not an error without CMake. Is CMake passing different options to clang? Also, I suggest using auto instead of what we did here.
Alex Christensen
Comment 5
2015-10-26 10:24:04 PDT
(In reply to
comment #4
)
> Comment on
attachment 263961
[details]
> Patch > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=263961&action=review
> > > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:3217 > > - typeof(updateBlock) updateBlockCopy = nil; > > + void (^updateBlockCopy)(void) = nil; > > How is this a “CMake” compile error? Since CMake is not a C compiler, I > don’t understand how using CMake causes this to be a compile error when it’s > not an error without CMake. Is CMake passing different options to clang?
Yes, CMake is currently passing different compile flags, and I'm not sure why this doesn't compile, but with typeof(updateBlock) as the variable type it has unrecognized identifier syntax errors.
> > Also, I suggest using auto instead of what we did here.
Good idea!
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug