Bug 150518 - Web Inspector: Remove unused ScrollLayer Timeline EventType
Summary: Web Inspector: Remove unused ScrollLayer Timeline EventType
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: Other
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: DoNotImportToRadar
Depends on:
Blocks:
 
Reported: 2015-10-23 16:40 PDT by Joseph Pecoraro
Modified: 2015-10-26 11:03 PDT (History)
12 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (22.61 KB, patch)
2015-10-23 16:42 PDT, Joseph Pecoraro
timothy: review+
joepeck: commit-queue-
Details | Formatted Diff | Diff
[PATCH] For Bots (23.08 KB, patch)
2015-10-23 17:35 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-10-23 16:40:16 PDT
* SUMMARY
Remove unused ScrollLayer Timeline EventType.

Frontend doesn't use it, and though it appears hooked up I don't see it even getting sent to the frontend.
Remove it retroactively from iOS backends because I don't think it works there even if it existed.
Comment 1 Joseph Pecoraro 2015-10-23 16:42:12 PDT
Created attachment 263956 [details]
[PATCH] Proposed Fix
Comment 2 WebKit Commit Bot 2015-10-23 16:44:10 PDT
Attachment 263956 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Joseph Pecoraro 2015-10-23 17:35:23 PDT
Created attachment 263966 [details]
[PATCH] For Bots
Comment 4 WebKit Commit Bot 2015-10-23 20:59:17 PDT
Comment on attachment 263966 [details]
[PATCH] For Bots

Clearing flags on attachment: 263966

Committed r191532: <http://trac.webkit.org/changeset/191532>