Bug 150514 - Remove unnecessary details from Other Crashes section
Summary: Remove unnecessary details from Other Crashes section
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-10-23 15:02 PDT by Aakash Jain
Modified: 2017-03-15 17:17 PDT (History)
3 users (show)

See Also:

Attachments
Proposed patch (3.56 KB, patch)
2015-10-23 15:08 PDT, Aakash Jain 		ap: review+
ap: commit-queue-
Details | Formatted Diff | Diff
Updated patch (3.52 KB, patch)
2015-10-23 16:53 PDT, Aakash Jain 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2015-10-23 15:02:09 PDT 
Please remove sections like "history", "sample" and trac link from Other Crashes as they are not relevant for other crashes (they are relevant only for tests).
Comment 1 Aakash Jain 2015-10-23 15:08:38 PDT 
Created attachment 263948 [details]
Proposed patch
Comment 2 Alexey Proskuryakov 2015-10-23 16:05:09 PDT 
Comment on attachment 263948 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=263948&action=review

I wonder if we can further simplify the json format now, getting rid of an empty dictionary.

> LayoutTests/fast/harness/results.html:779
> +        if (tableId == 'passes-table') {
> +            html += testLink(test);
> +        } else if (tableId == 'other-crash-tests-table') {

The WebKit style is to not have braces around single-line code blocks.
Comment 3 Alexey Proskuryakov 2015-10-23 16:42:02 PDT 
<rdar://problem/23235458>
Comment 4 Aakash Jain 2015-10-23 16:53:41 PDT 
Created attachment 263958 [details]
Updated patch

Updated the style.

This patch helps little bit towards ability to further simplify json, but more changes (both in javascript and webkitpy) would be required for that. I would work on that in separate patch.
Comment 5 WebKit Commit Bot 2015-10-23 17:46:50 PDT 
Comment on attachment 263958 [details]
Updated patch

Clearing flags on attachment: 263958

Committed r191524: <http://trac.webkit.org/changeset/191524>
Comment 6 WebKit Commit Bot 2015-10-23 17:46:53 PDT 
All reviewed patches have been landed.  Closing bug.