Bug 150474 – Web Inspector: Remove generateColoredImagesForCSS and its clients

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Timothy Hatcher]

We can use SVG directly, avoid the canvas bitmaps and avoid high startup costs.

[Radar WebKit Bug Importer]

<rdar://problem/23224909>

[Timothy Hatcher]

Created attachment 263864 [details]
Patch (Needs GTK Images Fixed)

[Joseph Pecoraro]

Comment on attachment 263864 [details]
Patch (Needs GTK Images Fixed)

View in context: https://bugs.webkit.org/attachment.cgi?id=263864&action=review

r=me

> Source/WebInspectorUI/UserInterface/Images/BackForwardArrows.svg:17
> +        svg[id $= "-mask"] {

Nit: These spaces look weird. I'm used to seeing these without spaces (e.g. input[type="search"]).

> Source/WebInspectorUI/UserInterface/Views/ObjectTreePropertyTreeElement.css:200
>  .object-tree-property .read-only {
>      content: url(../Images/Locked.svg);
> -    opacity: 0.5;
>  
>      width: 8px;
>      height: 10px;

Err, I think you can actually get rid of this entire group. I think we only show icons now for getter/setter. I don't see us setting "read-only" class on anything in ObjectTrees.

[Timothy Hatcher]

Created attachment 263879 [details]
Patch

[Devin Rousso]

Comment on attachment 263879 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=263879&action=review

> Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.css:80
> +    background-image: url(../Images/DisclosureTriangles.svg#closed-normal);

I did not know that you could select particular elements with "background-image: url(...)".  That is crazy cool.

[Joseph Pecoraro]

Comment on attachment 263879 [details]
Patch

r=me, nice getting rid of Tiny disclosure Trianges

[WebKit Commit Bot]

Comment on attachment 263879 [details]
Patch

Clearing flags on attachment: 263879

Committed r191488: <http://trac.webkit.org/changeset/191488>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Andres Gomez Garcia]

Thanks for this patch and taking care of GTK+ icons! :)