Bug 150470 - update-webkitgtk-libs should use mesa tarball
Summary: update-webkitgtk-libs should use mesa tarball
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Linux
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2015-10-22 13:44 PDT by Mark Salisbury
Modified: 2015-10-23 10:55 PDT (History)
8 users (show)

See Also:

Submitting patch for review (2.82 KB, patch)
2015-10-22 15:10 PDT, Mark Salisbury
pnormand: review+
Details | Formatted Diff | Diff
Proposed fix (2.85 KB, patch)
2015-10-23 09:58 PDT, Mark Salisbury
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Salisbury 2015-10-22 13:44:55 PDT
To fix https://bugs.webkit.org/show_bug.cgi?id=148941 mesa was changed from a tarball via ftp to a git checkout.

A git checkout is expensive.  Brian Paul (webmaster for mesa) has made an http tarball of mesa releases available.

Now that an http tarball is available it should be used.
Comment 1 Mark Salisbury 2015-10-22 15:10:13 PDT
Created attachment 263870 [details]
Submitting patch for review
Comment 2 Mark Salisbury 2015-10-23 08:27:47 PDT
Just got work from Brian - he submitted https://bugs.freedesktop.org/show_bug.cgi?id=92628 to create a more public link.  I don't think that needs to block making this change however.
Comment 3 Philippe Normand 2015-10-23 09:04:11 PDT
Comment on attachment 263870 [details]
Submitting patch for review

View in context: https://bugs.webkit.org/attachment.cgi?id=263870&action=review

Thanks. Please use prepare-ChangeLog next time, it seems you manually did it this time?

> Tools/ChangeLog:9
> +        https://bugs.webkit.org/show_bug.cgi?id=150470

This should be below the bug title

> Tools/ChangeLog:11
> +        Not reviewed yet.

The OOPS line should have been kept instead of adding this one.
Comment 4 Mark Salisbury 2015-10-23 09:58:58 PDT
Created attachment 263930 [details]
Proposed fix

Thanks Philippe.

Yeah - I did prepare it manually.  prepare-ChangeLog doesn't find any changes:

~/git/webkit-gtk$ ./Tools/Scripts/prepare-ChangeLog
  Running status to find changed, added, or removed files.
  No changes found.

I'm using git.  I've tried in a staged/unstaged/committed state...  guess I'd need to debug it figure out what's going on.
Comment 5 WebKit Commit Bot 2015-10-23 10:55:52 PDT
Comment on attachment 263930 [details]
Proposed fix

Clearing flags on attachment: 263930

Committed r191498: <http://trac.webkit.org/changeset/191498>
Comment 6 WebKit Commit Bot 2015-10-23 10:55:56 PDT
All reviewed patches have been landed.  Closing bug.