Bug 150470 – update-webkitgtk-libs should use mesa tarball

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Mark Salisbury]

To fix https://bugs.webkit.org/show_bug.cgi?id=148941 mesa was changed from a tarball via ftp to a git checkout.

A git checkout is expensive.  Brian Paul (webmaster for mesa) has made an http tarball of mesa releases available.

Now that an http tarball is available it should be used.

[Mark Salisbury]

Created attachment 263870 [details]
Submitting patch for review

[Mark Salisbury]

Just got work from Brian - he submitted https://bugs.freedesktop.org/show_bug.cgi?id=92628 to create a more public link.  I don't think that needs to block making this change however.

[Philippe Normand]

Comment on attachment 263870 [details]
Submitting patch for review

View in context: https://bugs.webkit.org/attachment.cgi?id=263870&action=review

Thanks. Please use prepare-ChangeLog next time, it seems you manually did it this time?

> Tools/ChangeLog:9
> +        https://bugs.webkit.org/show_bug.cgi?id=150470

This should be below the bug title

> Tools/ChangeLog:11
> +        Not reviewed yet.

The OOPS line should have been kept instead of adding this one.

[Mark Salisbury]

Created attachment 263930 [details]
Proposed fix

Thanks Philippe.

Yeah - I did prepare it manually.  prepare-ChangeLog doesn't find any changes:

~/git/webkit-gtk$ ./Tools/Scripts/prepare-ChangeLog
  Running status to find changed, added, or removed files.
  No changes found.

I'm using git.  I've tried in a staged/unstaged/committed state...  guess I'd need to debug it figure out what's going on.

[WebKit Commit Bot]

Comment on attachment 263930 [details]
Proposed fix

Clearing flags on attachment: 263930

Committed r191498: <http://trac.webkit.org/changeset/191498>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.