Bug 150467 – Remove ContextMenuWin.cpp and ContextMenuItemWin.cpp

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Anders Carlsson]

Remove ContextMenuWin.cpp and ContextMenuItemWin.cpp

[Anders Carlsson]

Created attachment 263852 [details]
Patch

[Build Bot]

Comment on attachment 263852 [details]
Patch

Attachment 263852 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/322903

New failing tests:
storage/indexeddb/modern/createobjectstore-basic.html

[Build Bot]

Created attachment 263865 [details]
Archive of layout-test-results from ews113 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Darin Adler]

Comment on attachment 263852 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=263852&action=review

> Source/WebCore/platform/win/ContextMenuWin.cpp:-112
> -HMENU ContextMenu::platformContextMenu() const
> -{
> -    return createPlatformContextMenuFromItems(m_items);
> -}

This error:

WebContextMenuClient.obj : error LNK2019: unresolved external symbol "public: struct tagMENUITEMINFOW __thiscall WebCore::ContextMenuItem::platformContextMenuItem(void)const " (?platformContextMenuItem@ContextMenuItem@WebCore@@QBE?AUtagMENUITEMINFOW@@XZ) referenced in function "public: virtual void __thiscall WebContextMenuClient::contextMenuItemSelected(class WebCore::ContextMenuItem *,class WebCore::ContextMenu const *)" (?contextMenuItemSelected@WebContextMenuClient@@UAEXPAVContextMenuItem@WebCore@@PBVContextMenu@3@@Z) [C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\Source\WebKit\WebKit.vcxproj]

seems to indicate we also need to remove WebKit/win/WebCoreSupport/WebContextMenuClient.cpp along with these files.

[Anders Carlsson]

Created attachment 265337 [details]
Patch

[Anders Carlsson]

Committed r192339: <http://trac.webkit.org/changeset/192339>