Bug 150467 - Remove ContextMenuWin.cpp and ContextMenuItemWin.cpp
Summary: Remove ContextMenuWin.cpp and ContextMenuItemWin.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-22 13:26 PDT by Anders Carlsson
Modified: 2015-11-11 17:29 PST (History)
1 user (show)

See Also:

Attachments
Patch (11.26 KB, patch)
2015-10-22 13:29 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews113 for mac-yosemite (774.31 KB, application/zip)
2015-10-22 14:17 PDT, Build Bot 		no flags Details
Patch (11.26 KB, patch)
2015-11-11 16:53 PST, Anders Carlsson 		bdakin: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2015-10-22 13:26:52 PDT 
Remove ContextMenuWin.cpp and ContextMenuItemWin.cpp
Comment 1 Anders Carlsson 2015-10-22 13:29:18 PDT 
Created attachment 263852 [details]
Patch
Comment 2 Build Bot 2015-10-22 14:17:37 PDT 
Comment on attachment 263852 [details]
Patch

Attachment 263852 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/322903

New failing tests:
storage/indexeddb/modern/createobjectstore-basic.html
Comment 3 Build Bot 2015-10-22 14:17:40 PDT 
Created attachment 263865 [details]
Archive of layout-test-results from ews113 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 4 Darin Adler 2015-10-31 10:15:38 PDT 
Comment on attachment 263852 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=263852&action=review

> Source/WebCore/platform/win/ContextMenuWin.cpp:-112
> -HMENU ContextMenu::platformContextMenu() const
> -{
> -    return createPlatformContextMenuFromItems(m_items);
> -}

This error:

WebContextMenuClient.obj : error LNK2019: unresolved external symbol "public: struct tagMENUITEMINFOW __thiscall WebCore::ContextMenuItem::platformContextMenuItem(void)const " (?platformContextMenuItem@ContextMenuItem@WebCore@@QBE?AUtagMENUITEMINFOW@@XZ) referenced in function "public: virtual void __thiscall WebContextMenuClient::contextMenuItemSelected(class WebCore::ContextMenuItem *,class WebCore::ContextMenu const *)" (?contextMenuItemSelected@WebContextMenuClient@@UAEXPAVContextMenuItem@WebCore@@PBVContextMenu@3@@Z) [C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\Source\WebKit\WebKit.vcxproj]

seems to indicate we also need to remove WebKit/win/WebCoreSupport/WebContextMenuClient.cpp along with these files.
Comment 5 Anders Carlsson 2015-11-11 16:53:17 PST 
Created attachment 265337 [details]
Patch
Comment 6 Anders Carlsson 2015-11-11 17:29:29 PST 
Committed r192339: <http://trac.webkit.org/changeset/192339>