Bug 150452 - Web Inspector: Restore :not(:placeholder-shown) behavior on search bars with comments
Summary: Web Inspector: Restore :not(:placeholder-shown) behavior on search bars with ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: DoNotImportToRadar
Depends on:
Blocks:
 
Reported: 2015-10-22 10:55 PDT by Joseph Pecoraro
Modified: 2015-10-22 11:43 PDT (History)
8 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (2.23 KB, patch)
2015-10-22 10:56 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-10-22 10:55:00 PDT 
* SUMMARY
Restore :not(:placeholder-shown) behavior on search bars with comments.

> > <http://trac.webkit.org/changeset/191071>
> > 
> > 4. Removed some :placeholder-shown CSS that didn't seem to be changing
> > behavior, unless I'm missing what it was doing.
> 
> The point of the :placeholder-shown selectors was to style the sidebar inputs with a
> white background when they had user typed text, not just when focused. So if you
> click/tab away it will stay white. That way the user has an indication a filter is
> applied and it won't recess into the sidebar background.
Comment 1 Joseph Pecoraro 2015-10-22 10:56:34 PDT 
Created attachment 263836 [details]
[PATCH] Proposed Fix
Comment 2 WebKit Commit Bot 2015-10-22 11:42:58 PDT 
Comment on attachment 263836 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 263836

Committed r191464: <http://trac.webkit.org/changeset/191464>
Comment 3 WebKit Commit Bot 2015-10-22 11:43:03 PDT 
All reviewed patches have been landed.  Closing bug.