Bug 150451 - [Win] Add support for the USE_TYPO_METRICS flag
Summary: [Win] Add support for the USE_TYPO_METRICS flag
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Windows 7
: P2 Normal
Assignee: Nobody
URL: http://tests.mathml-association.org/m...
Depends on: 150394 150396
  Show dependency treegraph
Reported: 2015-10-22 10:46 PDT by Frédéric Wang (:fredw)
Modified: 2019-06-16 23:28 PDT (History)
6 users (show)

See Also:

Patch (7.57 KB, patch)
2015-10-22 11:30 PDT, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff
Patch V2 (7.56 KB, patch)
2015-10-22 12:49 PDT, Frédéric Wang (:fredw)
darin: review+
Details | Formatted Diff | Diff
testcase (requires Cambria Math) (9.78 KB, text/html)
2015-10-22 13:57 PDT, Frédéric Wang (:fredw)
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Frédéric Wang (:fredw) 2015-10-22 10:46:24 PDT
This is bug 131839 for Windows.
Comment 1 Frédéric Wang (:fredw) 2015-10-22 11:30:59 PDT
Created attachment 263839 [details]
Comment 2 Frédéric Wang (:fredw) 2015-10-22 12:49:22 PDT
Created attachment 263847 [details]
Patch V2
Comment 3 WebKit Commit Bot 2015-10-22 12:52:28 PDT
Attachment 263847 [details] did not pass style-queue:

ERROR: Source/WebCore/platform/graphics/win/SimpleFontDataCGWin.cpp:70:  Missing spaces around /  [whitespace/operators] [3]
Total errors found: 1 in 5 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Frédéric Wang (:fredw) 2015-10-22 13:53:31 PDT
Comment on attachment 263847 [details]
Patch V2

Just asking a first review to get some feedback...

The patch has *not* been verified on a Windows machine.

The style error is bug 150396 and it seems that we can not workaround that because kCTFontTableOS2 is not defined on Windows. Maybe this requires an additional header but I can't find a public documentation for Windows.

It's a shame that the CGFont API does not have a more straightforward way to access the typo metrics. For SimpleFontDataCGWin, I just copied & adapted what was done for Mac in bug 150396. I'm afraid the same will be necessary for iOS...

As said in bug 150394 comment 13, I can add more code to restrict this change to font with a MATH table if that's desired. Again, the CGFont API does not seem to have a simple & fast way to verify whether a MATH table is present, so in bug 150394 I just adapted the fontHasVerticalGlyphs function from FontCocoa.mm.
Comment 5 Frédéric Wang (:fredw) 2015-10-22 13:57:11 PDT
Created attachment 263857 [details]
testcase (requires Cambria Math)
Comment 6 Frédéric Wang (:fredw) 2015-11-02 10:13:17 PST
Committed r191893: <http://trac.webkit.org/changeset/191893>