Bug 150448 – [EFL] Bump harfbuzz versions to 0.9.35

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Csaba Osztrogonác]

Similar GTK bug report: bug149749

[Csaba Osztrogonác]

Created attachment 263829 [details]
Patch

[Csaba Osztrogonác]

Some data: 
- Now we use a very very old version, 0.9.14. (released 2.5 years ago)
- Ubuntu 14.04 LTS ships 0.9.27
- Ubuntu 15.04 ships 0.9.37 (will reach end of life in 3 months)
- Ubuntu 15.10 ships 1.0.1
- Debian stable ships 0.9.35 (GTK already bumped to this version)
- Debian testing ships 1.0.1

Ubuntu 15.04 is the reference platform of EFL, so the best choice would
be to bump to 0.9.37 ... but I think it would be better to use the same
version as GTK port, let's choice 0.9.35.

I already ran tests with the new harfbuzz and saw no regression.
But the EFL bots will need a clean build once we land this change.

[Csaba Osztrogonác]

Created attachment 264205 [details]
Patch

EFL EWS was flakey, let's check it again.

[Csaba Osztrogonác]

Building the old harfbuzz on Ubuntu 15.10 with 
the stock GCC 5.2 fails with the following error:

hb-icu-le.cc: In function 'PortableFontInstance* _hb_icu_le_shaper_font_data_create(hb_font_t*)':
hb-icu-le.cc:68:16: error: invalid new-expression of abstract class type 'PortableFontInstance'
          status);
                ^
In file included from hb-icu-le.cc:31:0:
hb-icu-le/PortableFontInstance.h:32:7: note:   because the following virtual functions are pure within 'PortableFontInstance':
 class PortableFontInstance : public LEFontInstance, protected FontTableCache
       ^
In file included from hb-icu-le/PortableFontInstance.h:23:0,
                 from hb-icu-le.cc:31:
/usr/include/x86_64-linux-gnu/layout/LEFontInstance.h:165:25: note:     virtual const void* icu_55::LEFontInstance::getFontTable(LETag, size_t&) const
     virtual const void* getFontTable(LETag tableTag, size_t &length) const = 0;
                         ^
  CXX    test_size_params-test-size-params.o
Makefile:1140: recipe for target 'libharfbuzz_la-hb-icu-le.lo' failed


harfbuzz 0.9.35 builds fine on Ubuntu 15.10 and 15.04 
too. One more reason to bump to the newer one.

[Csaba Osztrogonác]

Comment on attachment 264205 [details]
Patch

Clearing flags on attachment: 264205

Committed r191886: <http://trac.webkit.org/changeset/191886>

[Csaba Osztrogonác]

All reviewed patches have been landed.  Closing bug.

[Gyuyoung Kim]

I just restart efl buildbot and ews from scratch.