Bug 150448 - [EFL] Bump harfbuzz versions to 0.9.35
Summary: [EFL] Bump harfbuzz versions to 0.9.35
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
Depends on:
Blocks: 150619
  Show dependency treegraph
Reported: 2015-10-22 08:42 PDT by Csaba Osztrogonác
Modified: 2015-11-02 04:00 PST (History)
2 users (show)

See Also:

Patch (1.42 KB, patch)
2015-10-22 08:43 PDT, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff
Patch (1.42 KB, patch)
2015-10-28 03:08 PDT, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2015-10-22 08:42:14 PDT
Similar GTK bug report: bug149749
Comment 1 Csaba Osztrogonác 2015-10-22 08:43:15 PDT
Created attachment 263829 [details]
Comment 2 Csaba Osztrogonác 2015-10-27 10:29:19 PDT
Some data: 
- Now we use a very very old version, 0.9.14. (released 2.5 years ago)
- Ubuntu 14.04 LTS ships 0.9.27
- Ubuntu 15.04 ships 0.9.37 (will reach end of life in 3 months)
- Ubuntu 15.10 ships 1.0.1
- Debian stable ships 0.9.35 (GTK already bumped to this version)
- Debian testing ships 1.0.1

Ubuntu 15.04 is the reference platform of EFL, so the best choice would
be to bump to 0.9.37 ... but I think it would be better to use the same
version as GTK port, let's choice 0.9.35.

I already ran tests with the new harfbuzz and saw no regression.
But the EFL bots will need a clean build once we land this change.
Comment 3 Csaba Osztrogonác 2015-10-28 03:08:02 PDT
Created attachment 264205 [details]

EFL EWS was flakey, let's check it again.
Comment 4 Csaba Osztrogonác 2015-10-28 04:26:53 PDT
Building the old harfbuzz on Ubuntu 15.10 with 
the stock GCC 5.2 fails with the following error:

hb-icu-le.cc: In function 'PortableFontInstance* _hb_icu_le_shaper_font_data_create(hb_font_t*)':
hb-icu-le.cc:68:16: error: invalid new-expression of abstract class type 'PortableFontInstance'
In file included from hb-icu-le.cc:31:0:
hb-icu-le/PortableFontInstance.h:32:7: note:   because the following virtual functions are pure within 'PortableFontInstance':
 class PortableFontInstance : public LEFontInstance, protected FontTableCache
In file included from hb-icu-le/PortableFontInstance.h:23:0,
                 from hb-icu-le.cc:31:
/usr/include/x86_64-linux-gnu/layout/LEFontInstance.h:165:25: note:     virtual const void* icu_55::LEFontInstance::getFontTable(LETag, size_t&) const
     virtual const void* getFontTable(LETag tableTag, size_t &length) const = 0;
  CXX    test_size_params-test-size-params.o
Makefile:1140: recipe for target 'libharfbuzz_la-hb-icu-le.lo' failed

harfbuzz 0.9.35 builds fine on Ubuntu 15.10 and 15.04 
too. One more reason to bump to the newer one.
Comment 5 Csaba Osztrogonác 2015-11-02 03:03:06 PST
Comment on attachment 264205 [details]

Clearing flags on attachment: 264205

Committed r191886: <http://trac.webkit.org/changeset/191886>
Comment 6 Csaba Osztrogonác 2015-11-02 03:03:13 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Gyuyoung Kim 2015-11-02 04:00:03 PST
I just restart efl buildbot and ews from scratch.