Bug 150440 – Style checker didn't catch single-line if statement

• Status: NEW
• Component: Tools / Tests

[Antoine Quint]

My patch at https://bugs.webkit.org/attachment.cgi?id=263680&action=review had the following code:

    } else if (name == SVGNames::onendAttr) {
        setAttributeEventListener(eventNames().endEventEvent, name, value);
    } else
        SVGElement::parseAttribute(name, value);

I added the else if which should not have used braces, but the style bot didn't report a failure. This sounds like https://bugs.webkit.org/show_bug.cgi?id=28164 but that bug is marked as fixed.

[Sam Sneddon [:gsnedders]]

The test is still there: https://github.com/WebKit/WebKit/blob/b28edead7c0c1615e7f7f934c475245e61742fe7/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py#L5433-L5438

So presumably something specific in this case (the else if?) making it not apply.