Bug 150433 - [Win][EFL][GTK] webkitpy test failed after r191374.
Summary: [Win][EFL][GTK] webkitpy test failed after r191374.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-21 19:35 PDT by Hunseop Jeong
Modified: 2015-10-22 00:18 PDT (History)
6 users (show)

See Also:

Attachments
Proposed patch (1.75 KB, patch)
2015-10-21 23:23 PDT, Aakash Jain 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hunseop Jeong 2015-10-21 19:35:30 PDT 
https://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/25059/steps/webkitpy-test/logs/stdio

[106/1443] webkitpy.common.system.crashlogs_unittest.CrashLogsTest.test_find_all_log_darwin erred:
  Traceback (most recent call last):
    File "/home/gyuyoung/WebKit-BuildSlave/efl-linux-64-release-wk2/build/Tools/Scripts/webkitpy/common/system/crashlogs_unittest.py", line 261, in test_find_all_log_darwin
      all_logs = crash_logs.find_all_logs()
  AttributeError: 'NoneType' object has no attribute 'find_all_logs'
  
[106/1443] webkitpy.common.checkout.checkout_unittest.CommitMessageForThisCommitTest.test_commit_message_for_rollout_changelogs_with_different_directories (+5)
[107/1443] webkitpy.common.system.crashlogs_unittest.CrashLogsTest.test_find_log_darwin erred:
  Traceback (most recent call last):
    File "/home/gyuyoung/WebKit-BuildSlave/efl-linux-64-release-wk2/build/Tools/Scripts/webkitpy/common/system/crashlogs_unittest.py", line 270, in test_find_log_darwin
      log = crash_logs.find_newest_log("DumpRenderTree")
  AttributeError: 'NoneType' object has no attribute 'find_newest_log'
Comment 1 Aakash Jain 2015-10-21 23:23:05 PDT 
Created attachment 263798 [details]
Proposed patch

Need to check platform before running the tests.
Comment 2 WebKit Commit Bot 2015-10-22 00:18:20 PDT 
Comment on attachment 263798 [details]
Proposed patch

Clearing flags on attachment: 263798

Committed r191445: <http://trac.webkit.org/changeset/191445>
Comment 3 WebKit Commit Bot 2015-10-22 00:18:24 PDT 
All reviewed patches have been landed.  Closing bug.