Bug 150428 - REGRESSION (r181972): Scroll position changes to top of youtube page when switching tabs
Summary: REGRESSION (r181972): Scroll position changes to top of youtube page when swi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-10-21 17:57 PDT by Ryosuke Niwa
Modified: 2015-10-22 17:08 PDT (History)
5 users (show)

See Also:


Attachments
Fixes the bug (16.15 KB, patch)
2015-10-21 18:10 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Adds an API test (24.72 KB, patch)
2015-10-22 00:23 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Patch for landing (24.86 KB, patch)
2015-10-22 03:45 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2015-10-21 17:57:45 PDT
We need to avoid revealing the focused element when restoring selection during tab switches.
Comment 1 Ryosuke Niwa 2015-10-21 18:10:33 PDT
Created attachment 263776 [details]
Fixes the bug
Comment 2 Simon Fraser (smfr) 2015-10-21 18:18:54 PDT
Comment on attachment 263776 [details]
Fixes the bug

Can we make a test?
Comment 3 Ryosuke Niwa 2015-10-21 18:27:55 PDT
(In reply to comment #2)
> Comment on attachment 263776 [details]
> Fixes the bug
> 
> Can we make a test?

We might be able to create an WK2 API test.
Comment 4 Ryosuke Niwa 2015-10-22 00:23:22 PDT
Created attachment 263801 [details]
Adds an API test
Comment 5 Antti Koivisto 2015-10-22 01:42:27 PDT
Comment on attachment 263801 [details]
Adds an API test

View in context: https://bugs.webkit.org/attachment.cgi?id=263801&action=review

r=me

> Source/WebCore/dom/Document.h:282
> +enum class RevealMode {

Reveal what? SelectionRevealMode might be more informative and consistent with the other enum.

> Tools/TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm:44
> +TEST(WebKit2, FirstResponderScrollingPosition)

Nice test!
Comment 6 Ryosuke Niwa 2015-10-22 03:45:50 PDT
Created attachment 263816 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2015-10-22 04:38:28 PDT
Comment on attachment 263816 [details]
Patch for landing

Clearing flags on attachment: 263816

Committed r191451: <http://trac.webkit.org/changeset/191451>
Comment 8 WebKit Commit Bot 2015-10-22 04:38:33 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 Ryosuke Niwa 2015-10-22 17:08:04 PDT
<rdar://problem/22407558>