Bug 150417 - Get rid of useBinaryEncoding from WKPageGetContentsAsMHTMLData
Summary: Get rid of useBinaryEncoding from WKPageGetContentsAsMHTMLData
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-21 14:33 PDT by Anders Carlsson
Modified: 2015-10-21 15:30 PDT (History)
1 user (show)

See Also:


Attachments
Patch (9.61 KB, patch)
2015-10-21 14:44 PDT, Anders Carlsson
no flags Details | Formatted Diff | Diff
Patch (9.67 KB, patch)
2015-10-21 14:54 PDT, Anders Carlsson
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2015-10-21 14:33:51 PDT
Get rid of useBinaryEncoding from WKPageGetContentsAsMHTMLData
Comment 1 Anders Carlsson 2015-10-21 14:44:57 PDT
Created attachment 263742 [details]
Patch
Comment 2 WebKit Commit Bot 2015-10-21 14:47:03 PDT
Attachment 263742 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:2642:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:755:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 2 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Anders Carlsson 2015-10-21 14:54:45 PDT
Created attachment 263743 [details]
Patch
Comment 4 WebKit Commit Bot 2015-10-21 14:56:28 PDT
Attachment 263743 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:2642:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:755:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 2 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Alex Christensen 2015-10-21 15:09:40 PDT
Comment on attachment 263743 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=263743&action=review

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:-2530
> -        ? MHTMLArchive::generateMHTMLDataUsingBinaryEncoding(m_page.get())

If you're doing this, why not go further and remove generateMHTMLDataUsingBinaryEncoding from MHTMLArchive.h and cpp?
Comment 6 Tim Horton 2015-10-21 15:13:44 PDT
Comment on attachment 263743 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=263743&action=review

>> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:-2530
>> -        ? MHTMLArchive::generateMHTMLDataUsingBinaryEncoding(m_page.get())
> 
> If you're doing this, why not go further and remove generateMHTMLDataUsingBinaryEncoding from MHTMLArchive.h and cpp?

Yeah, it doesn't look like there are other callers.
Comment 7 Anders Carlsson 2015-10-21 15:15:31 PDT
(In reply to comment #6)
> Comment on attachment 263743 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=263743&action=review
> 
> >> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:-2530
> >> -        ? MHTMLArchive::generateMHTMLDataUsingBinaryEncoding(m_page.get())
> > 
> > If you're doing this, why not go further and remove generateMHTMLDataUsingBinaryEncoding from MHTMLArchive.h and cpp?
> 
> Yeah, it doesn't look like there are other callers.

Going to do that in a follow-up patch!
Comment 8 Anders Carlsson 2015-10-21 15:30:40 PDT
Committed r191408: <http://trac.webkit.org/changeset/191408>