Bug 150409 – Web Inspector: srcset attributes should have hyperlinks to the resources

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Timothy Hatcher]

We link src and href, but we don't link the URLs inside srcset.

<img src="/blog-files/inspector-tab-bar.png" srcset="/blog-files/inspector-tab-bar.png 1x, /blog-files/inspector-tab-bar-2x.png 2x" alt="Web Inspector Tab Bar" width="1221" height="208">

This will require multiple links in an attribute, unlike src and href. We will need to parse the srcset microsyntax.

[Radar WebKit Bug Importer]

<rdar://problem/23206394>

[Joseph Pecoraro]

This affects both (1) CodeMirror content and (2) DOMTree content.

[Joseph Pecoraro]

Created attachment 263762 [details]
[PATCH] Proposed Fix

[Joseph Pecoraro]

Created attachment 263763 [details]
[IMAGE] CodeMirror test case

[Joseph Pecoraro]

Created attachment 263764 [details]
[IMAGE] DOMTree test case

[WebKit Commit Bot]

Comment on attachment 263762 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 263762

Committed r191421: <http://trac.webkit.org/changeset/191421>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Joseph Pecoraro]

I missed a `git add` for the better multi-line attribute handling. Reopening and adding a follow-up fixes patch.

[Joseph Pecoraro]

Created attachment 263841 [details]
[PATCH] Follow-up Fixes for Multiline

[Timothy Hatcher]

Image generators and vars are also supported. The following is from Web Inspector:
background-image: -webkit-canvas(foo);
background-image: linear-gradient(to bottom, hsl(0, 0%, 78%), hsl(0, 0%, 85%));

Yes, var would be a larger undertaking. Likely you would provide a menu selector for available variables.

[WebKit Commit Bot]

Comment on attachment 263841 [details]
[PATCH] Follow-up Fixes for Multiline

Rejecting attachment 263841 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
b)
  8  0x00007fff88a2628d _dispatch_client_callout (in libdispatch.dylib)
  9  0x00007fff88a28673 _dispatch_queue_drain (in libdispatch.dylib)
 10  0x00007fff88a299c1 _dispatch_queue_invoke (in libdispatch.dylib)
 11  0x00007fff88a27f87 _dispatch_root_queue_drain (in libdispatch.dylib)
 12  0x00007fff88a29177 _dispatch_worker_thread2 (in libdispatch.dylib)
 13  0x00007fff8db69ef8 _pthread_wqthread (in libsystem_pthread.dylib)
 14  0x00007fff8db6cfb9 start_wqthread (in libsystem_pthread.dylib)


Full output: http://webkit-queues.webkit.org/results/322872

[WebKit Commit Bot]

Comment on attachment 263841 [details]
[PATCH] Follow-up Fixes for Multiline

Clearing flags on attachment: 263841

Committed r191478: <http://trac.webkit.org/changeset/191478>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.