Bug 150407 - run-webkit-tests does not copy all crash logs for layout test failures on Mac
Summary: run-webkit-tests does not copy all crash logs for layout test failures on Mac
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-21 12:35 PDT by Aakash Jain
Modified: 2017-03-15 17:18 PDT (History)
9 users (show)

See Also:

Attachments
Proposed patch (2.63 KB, patch)
2015-10-21 12:46 PDT, Aakash Jain 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2015-10-21 12:35:49 PDT 
Mac specific implementation for https://bugs.webkit.org/show_bug.cgi?id=150056
Comment 1 Aakash Jain 2015-10-21 12:46:44 PDT 
Created attachment 263715 [details]
Proposed patch
Comment 2 Aakash Jain 2015-10-21 12:49:28 PDT 
This patch is similar to the iOS specific portion of patch for https://bugs.webkit.org/show_bug.cgi?id=150056
Comment 3 Alexey Proskuryakov 2015-10-21 15:17:14 PDT 
Comment on attachment 263715 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=263715&action=review

> Tools/Scripts/webkitpy/port/mac.py:223
> +    def _merge_crash_logs(self, logs, new_logs, crashed_processes):

It would be good to avoid copy/pasting this code, as it appears to be the same on iOS.
Comment 4 WebKit Commit Bot 2015-10-21 16:06:35 PDT 
Comment on attachment 263715 [details]
Proposed patch

Clearing flags on attachment: 263715

Committed r191410: <http://trac.webkit.org/changeset/191410>
Comment 5 WebKit Commit Bot 2015-10-21 16:06:41 PDT 
All reviewed patches have been landed.  Closing bug.