Bug 150404 - Web Inspector: Array previews with Symbol objects have too few preview values
Summary: Web Inspector: Array previews with Symbol objects have too few preview values
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: Other
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: DoNotImportToRadar
Depends on:
Blocks:
 
Reported: 2015-10-21 12:00 PDT by Joseph Pecoraro
Modified: 2015-10-21 12:57 PDT (History)
8 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (1.32 KB, patch)
2015-10-21 12:08 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-10-21 12:00:42 PDT 
* SUMMARY
Array previews with Symbol objects have too few preview values

* STEPS TO REPRODUCE
1. js> [Symbol(), 1, 2, 3, 4]
  => [Symbol()], expected [Symbol(), 1, 2, 3, 4]
Comment 1 Joseph Pecoraro 2015-10-21 12:01:14 PDT 
I think I see what is wrong. _generatePreview has a `return` instead of a `continue` in a loop when handling Symbol values.
Comment 2 Joseph Pecoraro 2015-10-21 12:08:36 PDT 
Created attachment 263709 [details]
[PATCH] Proposed Fix
Comment 3 WebKit Commit Bot 2015-10-21 12:57:32 PDT 
Comment on attachment 263709 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 263709

Committed r191397: <http://trac.webkit.org/changeset/191397>
Comment 4 WebKit Commit Bot 2015-10-21 12:57:35 PDT 
All reviewed patches have been landed.  Closing bug.