Bug 150400 - Failures in PutStackSinkingPhase should be less severe
Summary: Failures in PutStackSinkingPhase should be less severe
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-21 11:29 PDT by Filip Pizlo
Modified: 2015-10-21 11:46 PDT (History)
0 users

See Also:

Attachments
the patch (6.35 KB, patch)
2015-10-21 11:32 PDT, Filip Pizlo 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2015-10-21 11:29:30 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2015-10-21 11:32:39 PDT 
Created attachment 263707 [details]
the patch
Comment 2 Geoffrey Garen 2015-10-21 11:36:40 PDT 
Comment on attachment 263707 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=263707&action=review

r=me

> Source/JavaScriptCore/dfg/DFGPutStackSinkingPhase.cpp:254
> +                        // enabled we silently let this fly and we just abort this phase.

enabled => disabled

> Source/JavaScriptCore/dfg/DFGPutStackSinkingPhase.cpp:265
> +                            // Oh noes! Abort!!

O HAI IZ LOL CODE? https://esolangs.org/wiki/LOLCODE
Comment 3 Filip Pizlo 2015-10-21 11:37:48 PDT 
(In reply to comment #2)
> Comment on attachment 263707 [details]
> the patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=263707&action=review
> 
> r=me
> 
> > Source/JavaScriptCore/dfg/DFGPutStackSinkingPhase.cpp:254
> > +                        // enabled we silently let this fly and we just abort this phase.
> 
> enabled => disabled

Fixed.

> 
> > Source/JavaScriptCore/dfg/DFGPutStackSinkingPhase.cpp:265
> > +                            // Oh noes! Abort!!
> 
> O HAI IZ LOL CODE? https://esolangs.org/wiki/LOLCODE

Should I fix it? ;-)
Comment 4 Filip Pizlo 2015-10-21 11:46:52 PDT 
Landed in http://trac.webkit.org/changeset/191395