Bug 150397 – Un-expose obsolete HTMLBaseFontElement

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Chris Dumez]

Un-expose legacy HTMLBaseFontElement:
https://html.spec.whatwg.org/multipage/obsolete.html#non-conforming-features

Firefox and Chrome currently do not expose HTMLBaseFontElement on the global Window object. Also, document.createElement("basefont") constructs a generic HTMLElement.

[Chris Dumez]

Created attachment 263700 [details]
Patch

[Chris Dumez]

Created attachment 263703 [details]
Patch

[Chris Dumez]

Created attachment 263721 [details]
Patch

[Build Bot]

Comment on attachment 263721 [details]
Patch

Attachment 263721 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/317277

New failing tests:
http/tests/security/cross-frame-access-put.html
http/tests/security/cross-frame-access-getOwnPropertyDescriptor.html

[Build Bot]

Created attachment 263728 [details]
Archive of layout-test-results from ews100 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Build Bot]

Comment on attachment 263721 [details]
Patch

Attachment 263721 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/317283

New failing tests:
http/tests/security/cross-frame-access-put.html

[Build Bot]

Created attachment 263730 [details]
Archive of layout-test-results from ews106 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[Build Bot]

Comment on attachment 263721 [details]
Patch

Attachment 263721 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/317288

New failing tests:
http/tests/security/cross-frame-access-put.html
http/tests/security/cross-frame-access-getOwnPropertyDescriptor.html

[Build Bot]

Created attachment 263731 [details]
Archive of layout-test-results from ews115 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Chris Dumez]

Created attachment 263738 [details]
Patch

[Build Bot]

Comment on attachment 263738 [details]
Patch

Attachment 263738 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/317634

New failing tests:
imported/w3c/web-platform-tests/html/dom/interfaces.html

[Build Bot]

Created attachment 263745 [details]
Archive of layout-test-results from ews101 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Build Bot]

Comment on attachment 263738 [details]
Patch

Attachment 263738 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/317673

New failing tests:
imported/w3c/web-platform-tests/html/dom/interfaces.html

[Build Bot]

Created attachment 263748 [details]
Archive of layout-test-results from ews105 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[Chris Dumez]

Created attachment 263750 [details]
Patch

[Ryosuke Niwa]

Isn't this change risky in terms of backwards compatibility?

[WebKit Commit Bot]

Comment on attachment 263750 [details]
Patch

Clearing flags on attachment: 263750

Committed r191423: <http://trac.webkit.org/changeset/191423>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Alex Christensen]

http://trac.webkit.org/changeset/191438 should fix the clean build after this.

[Csaba Osztrogonác]

Just to document, https://trac.webkit.org/changeset/191448 fixed the GTK build.

[Chris Dumez]

Thanks for the follow-up build fixes.

[Chris Dumez]

(In reply to comment #16)
> Isn't this change risky in terms of backwards compatibility?

Well, this is a very old feature that has never really been fully cross-browser. Also, Firefox and Chrome do not support this so I think the risk is low. The only possible breakage would be for Safari-only sites that rely on this "ancient" feature.