Bug 150391 – Web Inspector: Typo in a property name: style.inerhited

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Nikita Vasilyev]

Should be "inherited". WebStorm spotted a missing property, otherwise I wouldn't notice.

http://trac.webkit.org/changeset/187195
https://github.com/WebKit/webkit/blob/f83708780100ed4be51a136ec33b3ddfdddcc9dd/Source/WebInspectorUI/UserInterface/Views/RulesStyleDetailsPanel.js#L293

I searched in Source/WebInspectorUI. That's the only place where "inerhited" is used.

[Radar WebKit Bug Importer]

<rdar://problem/23199935>

[Nikita Vasilyev]

Created attachment 263675 [details]
Patch

[Nikita Vasilyev]

I've been looking at this over 300 lines long refresh method for a while and I still don't quite understand what difference fixing this typo made.

Devin, in insertAllMatchingPseudoStyles(force), what is the point of the force agrument?

[WebKit Commit Bot]

Comment on attachment 263675 [details]
Patch

Clearing flags on attachment: 263675

Committed r191387: <http://trac.webkit.org/changeset/191387>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Devin Rousso]

(In reply to comment #3)
> I've been looking at this over 300 lines long refresh method for a while and
> I still don't quite understand what difference fixing this typo made.
> 
> Devin, in insertAllMatchingPseudoStyles(force), what is the point of the
> force agrument?

The idea behind the force argument was that pseudo-element styles (::before, ::after, etc) should never be seen below user-agent or inherited rules.  They should always be inserted before the first of those rules in the absolute worst case.  On most websites, there will be a matching rule that doesn't have the pseudo-element, so this is not necessary (like having ".example" and ".example::before").  It is possible, however, to have pseudo-rules without a matching non-pseudo-element rule, and it is for this case that the force was added.

Example:
on a blank page, create a rule and give it the selector "body::before" (and give the ::before a content).  This pseudo-element rule should appear before the user-agent "body" rule.

[Nikita Vasilyev]

Thanks Devin, that makes sense now.