Bug 150389 – [Streams API] Add writable stream attributes

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Xabier Rodríguez Calvar]

[Streams API] Add writable stream attributes

[Xabier Rodríguez Calvar]

Created attachment 263672 [details]
Patch

Added WS attributes.

[youenn fablet]

Comment on attachment 263672 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=263672&action=review

> Source/WebCore/Modules/streams/WritableStream.js:93
> +        return Promise.reject(new @TypeError("Callee of closed is not a WritableStream"));

We should start thinking in RS and WS to move from Promise.reject/Promise.resolve to private functions (like new @Promise -> new @InternalPromise).

Also, we may want to have consistent error messages.
ReadableStream error message would translate in "Function should be called on a WritableStream" which in not very good since it is a getter.
DOM C++ binding would say something like "The WritableStream.closed getter can only be used on instances of WritableStream".
Maybe we should think of introducing functions available from JS built-ins based on DOM binding (throwGetterTypeError...)?

[Xabier Rodríguez Calvar]

(In reply to comment #2)
> Comment on attachment 263672 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=263672&action=review
> 
> > Source/WebCore/Modules/streams/WritableStream.js:93
> > +        return Promise.reject(new @TypeError("Callee of closed is not a WritableStream"));
> 
> We should start thinking in RS and WS to move from
> Promise.reject/Promise.resolve to private functions (like new @Promise ->
> new @InternalPromise).

I'm on it. First I would get rid of the @createNewStreamsPromise and then I would take on that. Maybe together or in a separate patch, but I am definitely on it.

I would like to upstream what I have because it takes some time to review the patches so this way I can do several things at the same time.

> Also, we may want to have consistent error messages.
> ReadableStream error message would translate in "Function should be called
> on a WritableStream" which in not very good since it is a getter.
> DOM C++ binding would say something like "The WritableStream.closed getter
> can only be used on instances of WritableStream".
> Maybe we should think of introducing functions available from JS built-ins
> based on DOM binding (throwGetterTypeError...)?

That would be an option, yes.

I can change the error message to something more meaningful meanwhile.

[Xabier Rodríguez Calvar]

Created attachment 263676 [details]
Patch

Use more meaningful error messages

[WebKit Commit Bot]

Comment on attachment 263676 [details]
Patch

Clearing flags on attachment: 263676

Committed r191446: <http://trac.webkit.org/changeset/191446>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.