Bug 150382 - Single tapping clickable elements in unscalable pages should show a tap highlight
Summary: Single tapping clickable elements in unscalable pages should show a tap highl...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: iPhone / iPad Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on: 149968
Blocks:
  Show dependency treegraph
 
Reported: 2015-10-20 18:48 PDT by Wenson Hsieh
Modified: 2015-10-21 15:31 PDT (History)
1 user (show)

See Also:


Attachments
Patch (4.11 KB, patch)
2015-10-21 14:14 PDT, Wenson Hsieh
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2015-10-20 18:48:07 PDT
Single tapping clickable elements in unscalable pages should show a tap highlight. Currently, tap highlights are broken for fast clicking in pages that are unscalable because WKContentView assumes that the tap highlight geometry will arrive from the web process before the single tap is committed by the gesture recognizer. However, when the double tap gesture recognizer is disabled ahead of time (as in the case of unscalable pages) the tap is committed before the geometries come in.
Comment 1 Wenson Hsieh 2015-10-20 18:50:02 PDT
<rdar://problem/23172720>
Comment 2 Wenson Hsieh 2015-10-21 14:14:32 PDT
Created attachment 263733 [details]
Patch
Comment 3 Simon Fraser (smfr) 2015-10-21 14:58:12 PDT
Comment on attachment 263733 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=263733&action=review

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1254
> +    _isExpectingFastSingleTapCommit = ![_doubleTapGestureRecognizer isEnabled];

dot syntax?
Comment 4 Wenson Hsieh 2015-10-21 15:29:19 PDT
Comment on attachment 263733 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=263733&action=review

>> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1254
>> +    _isExpectingFastSingleTapCommit = ![_doubleTapGestureRecognizer isEnabled];
> 
> dot syntax?

Fixed!
Comment 5 Wenson Hsieh 2015-10-21 15:31:39 PDT
Committed r191409: <http://trac.webkit.org/changeset/191409>