WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 150380
[MIPS] LLInt: align stack pointer on MIPS too
https://bugs.webkit.org/show_bug.cgi?id=150380
Summary
[MIPS] LLInt: align stack pointer on MIPS too
Guillaume Emont
Reported
2015-10-20 17:22:40 PDT
The code in doVMEntry() to align the stack for X86_WIN is also needed on MIPS since C code using the o32 ABI will only align the stack to 8 bytes but JavaScriptCore expects it to be aligned on 16 bytes.
Attachments
Patch
(1.47 KB, patch)
2015-10-20 17:31 PDT
,
Guillaume Emont
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Guillaume Emont
Comment 1
2015-10-20 17:31:41 PDT
Created
attachment 263639
[details]
Patch
Michael Saboff
Comment 2
2015-10-20 17:36:08 PDT
Comment on
attachment 263639
[details]
Patch r=me
Philippe Normand
Comment 3
2015-10-21 09:26:35 PDT
Comment on
attachment 263639
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=263639&action=review
> Source/JavaScriptCore/ChangeLog:3 > + llint: align stack pointer on mips too
that line should be removed.
WebKit Commit Bot
Comment 4
2015-10-21 10:08:59 PDT
Comment on
attachment 263639
[details]
Patch Clearing flags on attachment: 263639 Committed
r191389
: <
http://trac.webkit.org/changeset/191389
>
WebKit Commit Bot
Comment 5
2015-10-21 10:09:02 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug