Bug 150380 - [MIPS] LLInt: align stack pointer on MIPS too
Summary: [MIPS] LLInt: align stack pointer on MIPS too
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Other Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 108664
  Show dependency tree / graph
 
Reported: 2015-10-20 17:22 PDT by Guillaume Emont
Modified: 2015-10-22 02:13 PDT (History)
1 user (show)

See Also:

Attachments
Patch (1.47 KB, patch)
2015-10-20 17:31 PDT, Guillaume Emont 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Guillaume Emont 2015-10-20 17:22:40 PDT 
The code in doVMEntry() to align the stack for X86_WIN is also needed on MIPS since C code using the o32 ABI will only align the stack to 8 bytes but JavaScriptCore expects it to be aligned on 16 bytes.
Comment 1 Guillaume Emont 2015-10-20 17:31:41 PDT 
Created attachment 263639 [details]
Patch
Comment 2 Michael Saboff 2015-10-20 17:36:08 PDT 
Comment on attachment 263639 [details]
Patch

r=me
Comment 3 Philippe Normand 2015-10-21 09:26:35 PDT 
Comment on attachment 263639 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=263639&action=review

> Source/JavaScriptCore/ChangeLog:3
> +        llint: align stack pointer on mips too

that line should be removed.
Comment 4 WebKit Commit Bot 2015-10-21 10:08:59 PDT 
Comment on attachment 263639 [details]
Patch

Clearing flags on attachment: 263639

Committed r191389: <http://trac.webkit.org/changeset/191389>
Comment 5 WebKit Commit Bot 2015-10-21 10:09:02 PDT 
All reviewed patches have been landed.  Closing bug.