Bug 150377 - HTMLIFrameElement.sandbox should be a DOMSettableTokenList
Summary: HTMLIFrameElement.sandbox should be a DOMSettableTokenList
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://html.spec.whatwg.org/multipag...
Keywords: WebExposed
Depends on:
Blocks:
 
Reported: 2015-10-20 16:22 PDT by Chris Dumez
Modified: 2015-10-21 10:01 PDT (History)
5 users (show)

See Also:

Attachments
Patch (10.25 KB, patch)
2015-10-20 20:40 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (10.20 KB, patch)
2015-10-21 09:15 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2015-10-20 16:22:52 PDT 
HTMLIframeElement.sandbox should be a DOMSettableTokenList as per the HTML specification:
https://html.spec.whatwg.org/multipage/embedded-content.html#htmliframeelement

Chrome and Firefox match the specification but Safari/WebKit uses a DOMString.
Comment 1 Chris Dumez 2015-10-20 20:40:02 PDT 
Created attachment 263655 [details]
Patch
Comment 2 Ryosuke Niwa 2015-10-21 03:51:18 PDT 
Comment on attachment 263655 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=263655&action=review

> Source/WebCore/html/HTMLIFrameElement.idl:34
> +    #endif

#endif shouldn't be indented.

> LayoutTests/fast/frames/sandbox-attribute.html:11
> +// Test Sanitization.

I don't think we need this comment.
Comment 3 Chris Dumez 2015-10-21 09:15:16 PDT 
Created attachment 263682 [details]
Patch
Comment 4 WebKit Commit Bot 2015-10-21 10:01:00 PDT 
Comment on attachment 263682 [details]
Patch

Clearing flags on attachment: 263682

Committed r191388: <http://trac.webkit.org/changeset/191388>
Comment 5 WebKit Commit Bot 2015-10-21 10:01:04 PDT 
All reviewed patches have been landed.  Closing bug.