Bug 150366 – AX: Expose table size and cell indexes on iOS

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Nan Wang]

Expose table row/column counts and ARIA 1.1 table related attributes on iOS.

[Radar WebKit Bug Importer]

<rdar://problem/23185254>

[Nan Wang]

Created attachment 263604 [details]
patch

[chris fleizach]

Comment on attachment 263604 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=263604&action=review

I'm wondering

> Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:921
> +    for (parentTable = m_object; parentTable && !parentTable->isTable(); parentTable = parentTable->parentObject())

why the change here

> Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:1012
> +    return rowCount > 0 ? rowCount : 0;

can we write as

return table->rowCount() > 0 ? : 0;

> Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:1024
> +    return colCount > 0 ? colCount : 0;

ditto

> Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:1036
> +    return rowCount > 0 ? rowCount : 0;

ditto

> Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:1048
> +    return colCount > 0 ? colCount : 0;

ditto

[Nan Wang]

Comment on attachment 263604 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=263604&action=review

>> Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:921
>> +    for (parentTable = m_object; parentTable && !parentTable->isTable(); parentTable = parentTable->parentObject())
> 
> why the change here

in isDataTable(), it returns false when the element has ARIA role. So aria table will be considered as not a table.

>> Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:1012
>> +    return rowCount > 0 ? rowCount : 0;
> 
> can we write as
> 
> return table->rowCount() > 0 ? : 0;

Ok.

[chris fleizach]

Comment on attachment 263604 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=263604&action=review

>>> Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:921
>>> +    for (parentTable = m_object; parentTable && !parentTable->isTable(); parentTable = parentTable->parentObject())
>> 
>> why the change here
> 
> in isDataTable(), it returns false when the element has ARIA role. So aria table will be considered as not a table.

in that case we might want isExposableThroughAccessibility()

[Nan Wang]

Created attachment 263662 [details]
patch

I think "table->ariaRowCount() > 0 ? : 0" is equivalent to "table->ariaRowCount > 0 ? table->ariaRowCount > 0 : 0",
which is not what we want: "table->ariaRowCount > 0 : table->ariaRowCount : 0".
So I didn't change those.

[WebKit Commit Bot]

Comment on attachment 263662 [details]
patch

Clearing flags on attachment: 263662

Committed r191391: <http://trac.webkit.org/changeset/191391>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.