Bug 150363 - http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-twice.html is flaky
Summary: http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-twice.html is flaky
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-20 09:05 PDT by Alexey Proskuryakov
Modified: 2015-11-14 01:25 PST (History)
4 users (show)

See Also:


Attachments
Patch (1.36 KB, patch)
2015-10-20 13:35 PDT, Ryan Haddad
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2015-10-20 09:05:35 PDT
http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-twice.html is flaky:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fxmlhttprequest%2Ftimeout%2Fxmlhttprequest-timeout-twice.html

 PASS XHR2 Timeout Property Tests 
-PASS XHR2 Timeout Property Tests 1 
-PASS XHR2 Timeout Property Tests 2 
+FAIL XHR2 Timeout Property Tests 1 assert_equals: load fires normally with same timeout set twice, original timeout at 1000, reset at 400 to 1000 expected "load" but got "timeout"(stack: assert@http://127.0.0.1:8000/w3c/resources/testharness.js:2060:37
+assert_equals@http://127.0.0.1:8000/w3c/resources/testharness.js:699:15
+http://127.0.0.1:8000/xmlhttprequest/timeout/xmlhttprequest-timeout-runner.js:7:40
+step@http://127.0.0.1:8000/w3c/resources/testharness.js:1160:30
+test@http://127.0.0.1:8000/w3c/resources/testharness.js:443:22
+testResultCallbackHandler@http://127.0.0.1:8000/xmlhttprequest/timeout/xmlhttprequest-timeout-runner.js:7:13)
Comment 1 youenn fablet 2015-10-20 09:09:36 PDT
If I am not mistaken, WPT testsuite contains the same tests.
It might be better to use WPT latest version and import them in LayoutTests/imported/w3c/web-platform-tests/XMLHttpRequest.

I'll try to do that once bug 149656 is done.

Also, IIRC, timeout values in the WPT tests have been increased.
Comment 2 Ryan Haddad 2015-10-20 13:35:21 PDT
Created attachment 263611 [details]
Patch

This is failing frequently today on Yosemite. Marking as flaky.
Comment 3 WebKit Commit Bot 2015-10-20 23:09:01 PDT
Comment on attachment 263611 [details]
Patch

Clearing flags on attachment: 263611

Committed r191375: <http://trac.webkit.org/changeset/191375>
Comment 4 WebKit Commit Bot 2015-10-20 23:09:05 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Alexey Proskuryakov 2015-10-20 23:21:38 PDT
Re-opening for investigation.
Comment 6 youenn fablet 2015-11-14 01:25:28 PST
Fixed as part of bug 151091