Bug 150350 - Add basic TextStream output for Images
Summary: Add basic TextStream output for Images
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-19 17:51 PDT by Simon Fraser (smfr)
Modified: 2015-10-20 13:39 PDT (History)
3 users (show)

See Also:


Attachments
Patch (16.40 KB, patch)
2015-10-19 17:54 PDT, Simon Fraser (smfr)
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2015-10-19 17:51:59 PDT
Add basic TextStream output for Images
Comment 1 Simon Fraser (smfr) 2015-10-19 17:54:22 PDT
Created attachment 263538 [details]
Patch
Comment 2 Darin Adler 2015-10-20 09:36:51 PDT
Comment on attachment 263538 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=263538&action=review

> Source/WebCore/platform/graphics/cg/PDFDocumentImage.h:56
> +protected:
> +    virtual void dump(TextStream&) const override;

Why not private?

> Source/WebCore/svg/graphics/SVGImage.h:73
> +protected:
> +    virtual void dump(TextStream&) const override;

Why not private?
Comment 3 Simon Fraser (smfr) 2015-10-20 13:39:42 PDT
Fixed and landed:
https://trac.webkit.org/r191352