Bug 150349 - AX: : CrashTracer: com.apple.WebKit.WebContent at com.apple.WebCore: WebCore::AccessibilityTable::tableElement const + 116
Summary: AX: : CrashTracer: com.apple.WebKit.WebContent at com.apple.WebCore: WebCore:...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: Safari 9
Hardware: All All
: P2 Normal
Assignee: chris fleizach
URL:
Keywords: InRadar
: 149084 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-10-19 17:44 PDT by chris fleizach
Modified: 2016-07-13 13:21 PDT (History)
11 users (show)

See Also:

Attachments
patch (2.13 KB, patch)
2015-10-19 17:49 PDT, chris fleizach 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description chris fleizach 2015-10-19 17:44:09 PDT 
100 com.apple.WebCore:  WebCore::AccessibilityTable::tableElement const + 116 <==
        100 com.apple.WebCore:  WebCore::AccessibilityTable::isDataTable const + 153
          100 com.apple.WebCore:  WebCore::AccessibilityTable::isTableExposableThroughAccessibility const + 45
            100 com.apple.WebCore:  WebCore::AccessibilityTable::init + 33
              96 com.apple.WebCore:  WebCore::AXObjectCache::getOrCreate + 3221
              | 83 com.apple.WebCore:  WebCore::AccessibilityRenderObject::addChildren + 47
              | | 83 com.apple.WebCore:  WebCore::AccessibilityNodeObject::insertChild + 76
              | |   83 com.apple.WebCore:  WebCore::AccessibilityRenderObject::addChildren + 82


<rdar://problem/23103005>
Comment 1 chris fleizach 2015-10-19 17:49:02 PDT 
Created attachment 263537 [details]
patch
Comment 2 Brent Fulgham 2015-10-20 13:50:34 PDT 
Comment on attachment 263537 [details]
patch

This looks reasonable to me. Will 'ancestorsOfType' traverse farther than we intend in this case? Or is that actually a benefit of this change?
Comment 3 chris fleizach 2015-10-20 13:55:58 PDT 
(In reply to comment #2)
> Comment on attachment 263537 [details]
> patch
> 
> This looks reasonable to me. Will 'ancestorsOfType' traverse farther than we
> intend in this case? Or is that actually a benefit of this change?

I think thats actually a benefit here. Thanks!
Comment 4 WebKit Commit Bot 2015-10-20 14:35:03 PDT 
Comment on attachment 263537 [details]
patch

Clearing flags on attachment: 263537

Committed r191357: <http://trac.webkit.org/changeset/191357>
Comment 5 WebKit Commit Bot 2015-10-20 14:35:08 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Brent Fulgham 2016-07-13 13:21:04 PDT 
*** Bug 149084 has been marked as a duplicate of this bug. ***