Bug 150345 - Remove unused support for long presses from WebKit
Summary: Remove unused support for long presses from WebKit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-19 16:23 PDT by Tim Horton
Modified: 2015-10-20 06:04 PDT (History)
5 users (show)

See Also:


Attachments
Patch (39.11 KB, patch)
2015-10-19 16:24 PDT, Tim Horton
bdakin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2015-10-19 16:23:54 PDT
Remove unused support for long presses from WebKit
Comment 1 Tim Horton 2015-10-19 16:24:10 PDT
Created attachment 263524 [details]
Patch
Comment 2 Tim Horton 2015-10-19 17:18:13 PDT
http://trac.webkit.org/changeset/191323
Comment 3 Ryan Haddad 2015-10-19 18:31:32 PDT
It looks like this change may have broken some builds:

/Volumes/Data/slave/elcapitan-debug/build/WebKitBuild/Debug/DerivedSources/WebCore/JSInternalSettingsGenerated.cpp:1750:10: error: no member named 'setLongMousePressEnabled' in 'WebCore::InternalSettingsGenerated'

Mac builds:
https://build.webkit.org/builders/Apple%20El%20Capitan%20Debug%20%28Build%29/builds/563
https://build.webkit.org/builders/Apple%20Yosemite%20Debug%20%28Build%29/builds/9578
https://build.webkit.org/builders/Apple%20Mavericks%20Debug%20%28Build%29/builds/21019

iOS builds:
https://build.webkit.org/builders/Apple%20iOS%209%20Simulator%20Release%20%28Build%29/builds/532
https://build.webkit.org/builders/Apple%20iOS%209%20Release%20%28Build%29/builds/435
Comment 4 Ryan Haddad 2015-10-19 18:32:57 PDT
May just need a clean build.
Comment 5 Tim Horton 2015-10-19 18:49:05 PDT
Needs a clean build or some Makefiles to finally be fixed.