WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
150345
Remove unused support for long presses from WebKit
https://bugs.webkit.org/show_bug.cgi?id=150345
Summary
Remove unused support for long presses from WebKit
Tim Horton
Reported
2015-10-19 16:23:54 PDT
Remove unused support for long presses from WebKit
Attachments
Patch
(39.11 KB, patch)
2015-10-19 16:24 PDT
,
Tim Horton
bdakin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Tim Horton
Comment 1
2015-10-19 16:24:10 PDT
Created
attachment 263524
[details]
Patch
Tim Horton
Comment 2
2015-10-19 17:18:13 PDT
http://trac.webkit.org/changeset/191323
Ryan Haddad
Comment 3
2015-10-19 18:31:32 PDT
It looks like this change may have broken some builds: /Volumes/Data/slave/elcapitan-debug/build/WebKitBuild/Debug/DerivedSources/WebCore/JSInternalSettingsGenerated.cpp:1750:10: error: no member named 'setLongMousePressEnabled' in 'WebCore::InternalSettingsGenerated' Mac builds:
https://build.webkit.org/builders/Apple%20El%20Capitan%20Debug%20%28Build%29/builds/563
https://build.webkit.org/builders/Apple%20Yosemite%20Debug%20%28Build%29/builds/9578
https://build.webkit.org/builders/Apple%20Mavericks%20Debug%20%28Build%29/builds/21019
iOS builds:
https://build.webkit.org/builders/Apple%20iOS%209%20Simulator%20Release%20%28Build%29/builds/532
https://build.webkit.org/builders/Apple%20iOS%209%20Release%20%28Build%29/builds/435
Ryan Haddad
Comment 4
2015-10-19 18:32:57 PDT
May just need a clean build.
Tim Horton
Comment 5
2015-10-19 18:49:05 PDT
Needs a clean build or some Makefiles to finally be fixed.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug