Bug 150335 - Only HTML spaces should be stripped from a <script>'s 'for' / 'event' attributes
Summary: Only HTML spaces should be stripped from a <script>'s 'for' / 'event' attributes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://html.spec.whatwg.org/multipag...
Keywords: WebExposed
Depends on: 148855
Blocks:
  Show dependency tree / graph
 
Reported: 2015-10-19 11:32 PDT by Chris Dumez
Modified: 2015-10-20 11:34 PDT (History)
6 users (show)

See Also:

Attachments
Patch (4.77 KB, patch)
2015-10-19 11:56 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (4.66 KB, patch)
2015-10-20 10:46 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2015-10-19 11:32:30 PDT 
Only HTML spaces should be stripped from a <script>'s 'for' / 'event' attributes. We currently use the wrong strip function and end up stripping non-HTML spaces:
https://html.spec.whatwg.org/multipage/scripting.html#prepare-a-script (step 12.3)
https://html.spec.whatwg.org/multipage/infrastructure.html#space-character
Comment 1 Chris Dumez 2015-10-19 11:56:57 PDT 
Created attachment 263498 [details]
Patch
Comment 2 WebKit Commit Bot 2015-10-19 14:06:10 PDT 
Comment on attachment 263498 [details]
Patch

Rejecting attachment 263498 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 263498, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.webkit.org/results/308850
Comment 3 Chris Dumez 2015-10-20 10:46:39 PDT 
Created attachment 263590 [details]
Patch
Comment 4 WebKit Commit Bot 2015-10-20 11:34:19 PDT 
Comment on attachment 263590 [details]
Patch

Clearing flags on attachment: 263590

Committed r191349: <http://trac.webkit.org/changeset/191349>
Comment 5 WebKit Commit Bot 2015-10-20 11:34:25 PDT 
All reviewed patches have been landed.  Closing bug.