WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
150331
W3C test importer should not import reference files as regular tests
https://bugs.webkit.org/show_bug.cgi?id=150331
Summary
W3C test importer should not import reference files as regular tests
youenn fablet
Reported
2015-10-19 08:25:43 PDT
W3C repository contains reference file tests (XX-ref.html) that are detected as reference tests by test parser. Also, test importer is skipping import of test resource files. It might be better to import those test resource files, detect them and mark them as Skip in TestExpectations or in some other configuration file.
Attachments
Patch
(35.29 KB, patch)
2015-10-19 08:47 PDT
,
youenn fablet
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
youenn fablet
Comment 1
2015-10-19 08:47:02 PDT
Created
attachment 263484
[details]
Patch
youenn fablet
Comment 2
2015-10-21 00:08:48 PDT
(In reply to
comment #1
)
> Created
attachment 263484
[details]
> Patch
In the future for web-platform-tests at least, we should just generate the MANIFEST.json file using WPT tools. Then we can use that MANIFEST.json to identify which files are tests and which files are resources.
WebKit Commit Bot
Comment 3
2015-10-21 00:54:18 PDT
Comment on
attachment 263484
[details]
Patch Clearing flags on attachment: 263484 Committed
r191380
: <
http://trac.webkit.org/changeset/191380
>
WebKit Commit Bot
Comment 4
2015-10-21 00:54:23 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug