Bug 150331 - W3C test importer should not import reference files as regular tests
Summary: W3C test importer should not import reference files as regular tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-19 08:25 PDT by youenn fablet
Modified: 2015-10-21 00:54 PDT (History)
5 users (show)

See Also:

Attachments
Patch (35.29 KB, patch)
2015-10-19 08:47 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2015-10-19 08:25:43 PDT 
W3C repository contains reference file tests (XX-ref.html) that are detected as reference tests by test parser.
Also, test importer is skipping import of test resource files.
It might be better to import those test resource files, detect them and mark them as Skip in TestExpectations or in some other configuration file.
Comment 1 youenn fablet 2015-10-19 08:47:02 PDT 
Created attachment 263484 [details]
Patch
Comment 2 youenn fablet 2015-10-21 00:08:48 PDT 
(In reply to comment #1)
> Created attachment 263484 [details]
> Patch

In the future for web-platform-tests at least, we should just generate the MANIFEST.json file using WPT tools.
Then we can use that MANIFEST.json to identify which files are tests and which files are resources.
Comment 3 WebKit Commit Bot 2015-10-21 00:54:18 PDT 
Comment on attachment 263484 [details]
Patch

Clearing flags on attachment: 263484

Committed r191380: <http://trac.webkit.org/changeset/191380>
Comment 4 WebKit Commit Bot 2015-10-21 00:54:23 PDT 
All reviewed patches have been landed.  Closing bug.