Bug 150330 - Fix the ENABLE(WEBASSEMBLY) build after r190827
Summary: Fix the ENABLE(WEBASSEMBLY) build after r190827
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P1 Blocker
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks: 149727
  Show dependency tree / graph
 
Reported: 2015-10-19 07:20 PDT by Csaba Osztrogonác
Modified: 2015-10-19 09:20 PDT (History)
4 users (show)

See Also:

Attachments
Patch (5.65 KB, patch)
2015-10-19 07:34 PDT, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2015-10-19 07:20:54 PDT 
https://trac.webkit.org/changeset/190827 broke the ENABLE(WEBASSEMBLY) 
build in many places. It's obvious that the changes in ENABLE(WEBASSEMBLY)
blocks were speculative changes and nobody tried to build it anytime.

Fix is coming.
Comment 1 Csaba Osztrogonác 2015-10-19 07:27:22 PDT 
for example:
-------------
CodeBlock::CodeBlock(VM* vm, Structure* structure, WebAssemblyExecutable* ownerExecutable, VM& vm, JSGlobalObject* globalObject)

"VM* vm" vs "VM& vm"

---

WebAssemblyCodeBlock* codeBlock = WebAssemblyCodeBlock::create(vm, this, exec->lexicalGlobalObject()));

extra ")" at the end ...
Comment 2 Csaba Osztrogonác 2015-10-19 07:34:28 PDT 
Created attachment 263481 [details]
Patch
Comment 3 Geoffrey Garen 2015-10-19 09:11:03 PDT 
Comment on attachment 263481 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2015-10-19 09:20:48 PDT 
Comment on attachment 263481 [details]
Patch

Clearing flags on attachment: 263481

Committed r191291: <http://trac.webkit.org/changeset/191291>
Comment 5 WebKit Commit Bot 2015-10-19 09:20:52 PDT 
All reviewed patches have been landed.  Closing bug.