WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
150321
Fix the !ENABLE(CSS_GRID_LAYOUT) build after
r191128
https://bugs.webkit.org/show_bug.cgi?id=150321
Summary
Fix the !ENABLE(CSS_GRID_LAYOUT) build after r191128
Csaba Osztrogonác
Reported
2015-10-19 03:02:13 PDT
https://trac.webkit.org/changeset/191128
broke the --minimal build (at least on EFL): /home/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebCore/CSSGrammar.y:1540.31-34: warning: unused value: $3 [-Wother] | VARFUNCTION maybe_space expr closing_parenthesis { ^^^^ /home/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebCore/CSSGrammar.y: error: shift/reduce conflicts: 38 found, 37 expected Died at /home/webkit/WebKit/Source/WebCore/css/makegrammar.pl line 84. ninja: build stopped: subcommand failed.
Attachments
Patch
(1.09 KB, patch)
2015-10-19 03:34 PDT
,
Csaba Osztrogonác
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1
2015-10-19 03:34:13 PDT
Created
attachment 263465
[details]
Patch
Csaba Osztrogonác
Comment 2
2015-10-19 04:00:20 PDT
(In reply to
comment #0
)
>
https://trac.webkit.org/changeset/191128
broke the --minimal build (at least > on EFL): > > /home/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebCore/CSSGrammar.y: > 1540.31-34: warning: unused value: $3 [-Wother] > | VARFUNCTION maybe_space expr closing_parenthesis { > ^^^^
This warning is not so critical, build works fine without fixing it, so I filed a new bug report to fix the warning:
bug150325
.
> /home/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebCore/CSSGrammar.y: > error: shift/reduce conflicts: 38 found, 37 expected > Died at /home/webkit/WebKit/Source/WebCore/css/makegrammar.pl line 84. > ninja: build stopped: subcommand failed.
The proposed patch fixes only the build failure.
Csaba Osztrogonác
Comment 3
2015-10-20 01:01:33 PDT
ping?
WebKit Commit Bot
Comment 4
2015-10-20 10:16:56 PDT
Comment on
attachment 263465
[details]
Patch Clearing flags on attachment: 263465 Committed
r191344
: <
http://trac.webkit.org/changeset/191344
>
WebKit Commit Bot
Comment 5
2015-10-20 10:17:01 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug