Bug 150321 – Fix the !ENABLE(CSS_GRID_LAYOUT) build after r191128

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Csaba Osztrogonác]

https://trac.webkit.org/changeset/191128 broke the --minimal build (at least on EFL):

/home/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebCore/CSSGrammar.y:1540.31-34: warning: unused value: $3 [-Wother]
     | VARFUNCTION maybe_space expr closing_parenthesis {
                               ^^^^
/home/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebCore/CSSGrammar.y: error: shift/reduce conflicts: 38 found, 37 expected
Died at /home/webkit/WebKit/Source/WebCore/css/makegrammar.pl line 84.
ninja: build stopped: subcommand failed.

[Csaba Osztrogonác]

Created attachment 263465 [details]
Patch

[Csaba Osztrogonác]

(In reply to comment #0)
> https://trac.webkit.org/changeset/191128 broke the --minimal build (at least
> on EFL):
> 
> /home/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebCore/CSSGrammar.y:
> 1540.31-34: warning: unused value: $3 [-Wother]
>      | VARFUNCTION maybe_space expr closing_parenthesis {
>                                ^^^^

This warning is not so critical, build works fine without fixing it,
so I filed a new bug report to fix the warning: bug150325.

> /home/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebCore/CSSGrammar.y:
> error: shift/reduce conflicts: 38 found, 37 expected
> Died at /home/webkit/WebKit/Source/WebCore/css/makegrammar.pl line 84.
> ninja: build stopped: subcommand failed.

The proposed patch fixes only the build failure.

[Csaba Osztrogonác]

ping?

[WebKit Commit Bot]

Comment on attachment 263465 [details]
Patch

Clearing flags on attachment: 263465

Committed r191344: <http://trac.webkit.org/changeset/191344>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.