Bug 150321 - Fix the !ENABLE(CSS_GRID_LAYOUT) build after r191128
Summary: Fix the !ENABLE(CSS_GRID_LAYOUT) build after r191128
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P1 Blocker
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks: 19660
  Show dependency treegraph
 
Reported: 2015-10-19 03:02 PDT by Csaba Osztrogonác
Modified: 2015-10-20 10:17 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.09 KB, patch)
2015-10-19 03:34 PDT, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2015-10-19 03:02:13 PDT
https://trac.webkit.org/changeset/191128 broke the --minimal build (at least on EFL):

/home/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebCore/CSSGrammar.y:1540.31-34: warning: unused value: $3 [-Wother]
     | VARFUNCTION maybe_space expr closing_parenthesis {
                               ^^^^
/home/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebCore/CSSGrammar.y: error: shift/reduce conflicts: 38 found, 37 expected
Died at /home/webkit/WebKit/Source/WebCore/css/makegrammar.pl line 84.
ninja: build stopped: subcommand failed.
Comment 1 Csaba Osztrogonác 2015-10-19 03:34:13 PDT
Created attachment 263465 [details]
Patch
Comment 2 Csaba Osztrogonác 2015-10-19 04:00:20 PDT
(In reply to comment #0)
> https://trac.webkit.org/changeset/191128 broke the --minimal build (at least
> on EFL):
> 
> /home/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebCore/CSSGrammar.y:
> 1540.31-34: warning: unused value: $3 [-Wother]
>      | VARFUNCTION maybe_space expr closing_parenthesis {
>                                ^^^^

This warning is not so critical, build works fine without fixing it,
so I filed a new bug report to fix the warning: bug150325.

> /home/webkit/WebKit/WebKitBuild/Release/DerivedSources/WebCore/CSSGrammar.y:
> error: shift/reduce conflicts: 38 found, 37 expected
> Died at /home/webkit/WebKit/Source/WebCore/css/makegrammar.pl line 84.
> ninja: build stopped: subcommand failed.

The proposed patch fixes only the build failure.
Comment 3 Csaba Osztrogonác 2015-10-20 01:01:33 PDT
ping?
Comment 4 WebKit Commit Bot 2015-10-20 10:16:56 PDT
Comment on attachment 263465 [details]
Patch

Clearing flags on attachment: 263465

Committed r191344: <http://trac.webkit.org/changeset/191344>
Comment 5 WebKit Commit Bot 2015-10-20 10:17:01 PDT
All reviewed patches have been landed.  Closing bug.