Bug 150320 - Fix the binding generator after r191176
Summary: Fix the binding generator after r191176
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks: 149952
  Show dependency treegraph
 
Reported: 2015-10-19 02:41 PDT by Csaba Osztrogonác
Modified: 2015-10-19 14:22 PDT (History)
3 users (show)

See Also:


Attachments
Patch (2.80 KB, patch)
2015-10-19 02:44 PDT, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2015-10-19 02:41:45 PDT
https://trac.webkit.org/changeset/191176 broke the !ENABLE(FOO) 
builds because of a mistake in the binding generator.

DerivedSources/WebCore/JSCompositionEvent.cpp: In static member function 'static JSC::ConstructType WebCore::JSDOMConstructor<JSClass>::getConstructData(JSC::JSCell*, JSC::ConstructData&) [with JSClass = WebCore::JSCompositionEvent]':
DerivedSources/WebCore/JSCompositionEvent.cpp:131:35: error: 'cell' was not declared in this scope
DerivedSources/WebCore/JSCompositionEvent.cpp:133:1: error: control reaches end of non-void function [-Werror=return-type]

WebKitBuild/Release/DerivedSources/WebCore/JSCompositionEvent.cpp
------------------------------------------------------------------
...
template<> ConstructType JSCompositionEventConstructor::getConstructData(JSCell*, ConstructData& constructData)
{
#if ENABLE(DOM4_EVENTS_CONSTRUCTOR)
    constructData.native.function = construct;
    return ConstructTypeHost;
#else
    return Base::getConstructData(cell, constructData);
#endif
}
...
Comment 1 Csaba Osztrogonác 2015-10-19 02:44:46 PDT
Created attachment 263460 [details]
Patch
Comment 2 youenn fablet 2015-10-19 02:59:02 PDT
LGTM.
Thanks for fixing it again.
Comment 3 WebKit Commit Bot 2015-10-19 14:22:24 PDT
Comment on attachment 263460 [details]
Patch

Clearing flags on attachment: 263460

Committed r191316: <http://trac.webkit.org/changeset/191316>
Comment 4 WebKit Commit Bot 2015-10-19 14:22:28 PDT
All reviewed patches have been landed.  Closing bug.