https://trac.webkit.org/changeset/191176 broke the !ENABLE(FOO) builds because of a mistake in the binding generator. DerivedSources/WebCore/JSCompositionEvent.cpp: In static member function 'static JSC::ConstructType WebCore::JSDOMConstructor<JSClass>::getConstructData(JSC::JSCell*, JSC::ConstructData&) [with JSClass = WebCore::JSCompositionEvent]': DerivedSources/WebCore/JSCompositionEvent.cpp:131:35: error: 'cell' was not declared in this scope DerivedSources/WebCore/JSCompositionEvent.cpp:133:1: error: control reaches end of non-void function [-Werror=return-type] WebKitBuild/Release/DerivedSources/WebCore/JSCompositionEvent.cpp ------------------------------------------------------------------ ... template<> ConstructType JSCompositionEventConstructor::getConstructData(JSCell*, ConstructData& constructData) { #if ENABLE(DOM4_EVENTS_CONSTRUCTOR) constructData.native.function = construct; return ConstructTypeHost; #else return Base::getConstructData(cell, constructData); #endif } ...
Created attachment 263460 [details] Patch
LGTM. Thanks for fixing it again.
Comment on attachment 263460 [details] Patch Clearing flags on attachment: 263460 Committed r191316: <http://trac.webkit.org/changeset/191316>
All reviewed patches have been landed. Closing bug.