Bug 150311 - [EFL] ContextMenu doesn't work correctly on MiniBrowser after r191194.
Summary: [EFL] ContextMenu doesn't work correctly on MiniBrowser after r191194.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hunseop Jeong
URL:
Keywords:
Depends on: 150310
Blocks:
  Show dependency tree / graph
 
Reported: 2015-10-18 21:55 PDT by Hunseop Jeong
Modified: 2015-10-20 18:53 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.38 KB, patch)
2015-10-19 21:13 PDT, Hunseop Jeong 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hunseop Jeong 2015-10-18 21:55:40 PDT 
ContextMenu doesn't work correctly on MiniBrowser and test_ewk2_text_checker API test(https://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/25018/steps/API%20tests/logs/stdio) failed after r191194.
Comment 1 Hunseop Jeong 2015-10-18 22:00:25 PDT 
I make the patch to fix the contextMenu(https://bugs.webkit.org/show_bug.cgi?id=150310).
Comment 2 Hunseop Jeong 2015-10-19 04:14:09 PDT 
This bug was fixed at http://trac.webkit.org/changeset/191282.
Comment 3 Gyuyoung Kim 2015-10-19 18:04:23 PDT 
(In reply to comment #2)
> This bug was fixed at http://trac.webkit.org/changeset/191282.

I understood that r191282 didn't fix context menu perfectly. That's why I allowed to land it without API test. And this bug is to support API test for showContextMenu().

However you closed this bug as soon as r191282 is closed. If r191282 can fix context menu, we needed to pass or support API test as well. Hmm you didn't understand what I wanted.
Comment 4 Hunseop Jeong 2015-10-19 21:13:50 PDT 
Created attachment 263548 [details]
Patch
Comment 5 Hunseop Jeong 2015-10-19 21:17:09 PDT 
I think showContextMenu() test is covered by test_ewk2_context_menu.
How about your opinion?
test_ewk2_context_menu was suppressed after r168925.
Comment 6 WebKit Commit Bot 2015-10-20 18:53:51 PDT 
Comment on attachment 263548 [details]
Patch

Clearing flags on attachment: 263548

Committed r191368: <http://trac.webkit.org/changeset/191368>
Comment 7 WebKit Commit Bot 2015-10-20 18:53:55 PDT 
All reviewed patches have been landed.  Closing bug.