Bug 150306 - Shadow GraphicsContext's ImageInterpolationQuality inside GraphicsContextState
Summary: Shadow GraphicsContext's ImageInterpolationQuality inside GraphicsContextState
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-18 15:42 PDT by Myles C. Maxfield
Modified: 2015-10-19 21:23 PDT (History)
0 users

See Also:

Attachments
Patch (8.22 KB, patch)
2015-10-18 15:45 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (8.23 KB, patch)
2015-10-19 11:21 PDT, Myles C. Maxfield 		simon.fraser: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2015-10-18 15:42:06 PDT 
Shadow GraphicsContext's ImageInterpolationQuality inside GraphicsContextState
Comment 1 Myles C. Maxfield 2015-10-18 15:45:22 PDT 
Created attachment 263430 [details]
Patch
Comment 2 Darin Adler 2015-10-18 15:55:52 PDT 
Comment on attachment 263430 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=263430&action=review

> Source/WebCore/ChangeLog:11
> +        When getting the ImageInterpolationQuality, there is no need to round-trip through
> +        the platform's graphics context. This patch migrates this piece of state to the
> +        existing idiom of having a setter in GraphicsContext.cpp which sets the relevent
> +        state in GraphicsContextState and then calls into a platform-specific setter.

I don’t understand what’s going on with this sequence of patches. Are we going to shadow all the state from the platform graphics contexts?
Comment 3 Myles C. Maxfield 2015-10-19 11:21:51 PDT 
Created attachment 263493 [details]
Patch
Comment 4 Simon Fraser (smfr) 2015-10-19 11:26:46 PDT 
Comment on attachment 263493 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=263493&action=review

> Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp:117
> +static InterpolationQuality convertInterpolationQuality(CGInterpolationQuality quality)

Can this be a C++ operator?
Comment 5 Myles C. Maxfield 2015-10-19 21:21:37 PDT 
Comment on attachment 263493 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=263493&action=review

>> Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp:117
>> +static InterpolationQuality convertInterpolationQuality(CGInterpolationQuality quality)
> 
> Can this be a C++ operator?

error: conversion function must be a non-static member function
Comment 6 Myles C. Maxfield 2015-10-19 21:23:43 PDT 
Committed r191330: <http://trac.webkit.org/changeset/191330>