Next step in clean-up for Color and ColorSpace
Created attachment 263431 [details] Patch
I uploaded the large patch of my work in progress. It compiles on Mac, but probably doesn’t compile anywhere else or pass tests yet. For the most part, I want to get some feedback for some of the terminology I am using, syntax and function names. I’ll also shave off various parts of this patch and land them independently. The patch gets rid of all the use of ColorSpace alongside Color, since we plan to handle that inside the Color class itself. It also eliminates the obsolete RGBA32 class. There is also substantial reduction in the use of the concept of "device RGB", which is not really a color space concept that exists on any platform at this time. Some other small cleanup in the patch.
Attachment 263431 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:55: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:111: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:114: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:103: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/mock/ScrollbarThemeMock.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:248: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:260: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:265: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:277: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:287: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:756: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:758: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm:79: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:812: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:817: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/cg/BitmapImageCG.cpp:171: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2079: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2085: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:3255: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/NumberInputType.cpp:151: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:72: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:82: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderLayer.cpp:3702: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:438: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:443: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:449: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:455: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:460: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:53: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:77: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:83: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:89: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:95: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/Shared/mac/ArgumentCodersMac.mm:327: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/mac/ColorMac.mm:39: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/BorderValue.h:74: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/css/CSSParser.cpp:7698: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/inspector/InspectorDOMAgent.cpp:120: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:84: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:84: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/rendering/style/RenderStyle.cpp:1642: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:405: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:445: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:479: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:505: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1275: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1276: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2075: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2076: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2084: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2085: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2088: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2094: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2096: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:638: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1219: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1223: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1225: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1227: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1229: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1235: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1237: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1245: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1247: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1251: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1259: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1261: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1263: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1265: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1267: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1271: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1282: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/CollapsedBorderValue.h:56: Missing space before { [whitespace/braces] [5] Total errors found: 77 in 258 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 263552 [details] Patch
Attachment 263552 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:55: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:111: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:114: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:103: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/mock/ScrollbarThemeMock.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:248: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:260: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:265: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:277: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:287: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:756: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:758: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm:79: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:812: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:817: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/cg/BitmapImageCG.cpp:171: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2079: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2085: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:3255: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:192: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:198: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:199: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/NumberInputType.cpp:151: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:72: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:82: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderLayer.cpp:3702: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:77: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:83: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:89: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:95: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:438: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:443: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:449: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:455: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:460: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:53: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/Shared/mac/ArgumentCodersMac.mm:327: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/win/PlatformCAAnimationWin.cpp:486: Missing space around : in range-based for statement [whitespace/colon] [4] ERROR: Source/WebCore/platform/graphics/mac/ColorMac.mm:39: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/BorderValue.h:74: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/css/CSSParser.cpp:7698: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/inspector/InspectorDOMAgent.cpp:120: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:84: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:84: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/rendering/style/RenderStyle.cpp:1642: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:305: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:316: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:405: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:445: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:479: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:505: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1275: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1276: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2075: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2076: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2084: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2085: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2088: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2094: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2096: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:638: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1201: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1205: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1207: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1209: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1211: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1217: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1219: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1227: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1229: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1233: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1241: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1245: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1247: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1249: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1253: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1264: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/CollapsedBorderValue.h:56: Missing space before { [whitespace/braces] [5] Total errors found: 83 in 267 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 263578 [details] Patch
Attachment 263578 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:55: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:111: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:114: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:103: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/mock/ScrollbarThemeMock.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:248: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:260: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:265: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:277: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:287: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:756: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:758: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm:79: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:812: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:817: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/cg/BitmapImageCG.cpp:171: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2079: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2085: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:3255: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:192: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:198: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:199: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/NumberInputType.cpp:151: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:72: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:82: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderLayer.cpp:3699: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:77: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:83: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:89: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:95: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:438: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:443: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:449: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:455: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:460: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:53: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/Shared/mac/ArgumentCodersMac.mm:327: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/win/GraphicsContextCGWin.cpp:176: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/mac/ColorMac.mm:39: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/BorderValue.h:74: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/css/CSSParser.cpp:7698: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/inspector/InspectorDOMAgent.cpp:120: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:80: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:86: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/rendering/style/RenderStyle.cpp:1642: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:305: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:316: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:405: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:445: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:479: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:505: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1275: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1276: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2075: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2076: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2084: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2085: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2088: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2094: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2096: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:638: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1201: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1205: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1207: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1209: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1211: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1217: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1219: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1227: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1229: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1233: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1241: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1245: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1247: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1249: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1253: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1264: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/CollapsedBorderValue.h:56: Missing space before { [whitespace/braces] [5] Total errors found: 84 in 270 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 263578 [details] Patch Attachment 263578 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/312018 Number of test failures exceeded the failure limit.
Created attachment 263579 [details] Archive of layout-test-results from ews101 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-mavericks Platform: Mac OS X 10.9.5
Comment on attachment 263578 [details] Patch Attachment 263578 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/312019 Number of test failures exceeded the failure limit.
Created attachment 263580 [details] Archive of layout-test-results from ews104 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Created attachment 263583 [details] Patch
Attachment 263583 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:55: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:111: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:114: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:103: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/mock/ScrollbarThemeMock.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:248: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:260: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:265: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:277: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:287: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:756: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:758: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/DateInputType.cpp:70: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm:79: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:812: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:817: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/cg/BitmapImageCG.cpp:171: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2079: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2085: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:3255: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:192: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:198: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:199: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/NumberInputType.cpp:151: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:72: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:82: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderLayer.cpp:3699: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:77: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:83: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:89: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:95: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:438: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:443: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:449: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:455: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:460: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:53: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/Shared/mac/ArgumentCodersMac.mm:327: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/win/GraphicsContextCGWin.cpp:176: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/mac/ColorMac.mm:39: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/BorderValue.h:74: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/css/CSSParser.cpp:7698: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/inspector/InspectorDOMAgent.cpp:120: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:80: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:86: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/rendering/style/RenderStyle.cpp:1642: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:305: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:316: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:405: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:445: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:479: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:505: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1275: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1276: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2075: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2076: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2084: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2085: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2088: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2094: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2096: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:638: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1201: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1205: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1207: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1209: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1211: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1217: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1219: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1227: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1229: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1233: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1241: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1245: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1247: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1249: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1253: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1264: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/CollapsedBorderValue.h:56: Missing space before { [whitespace/braces] [5] Total errors found: 85 in 272 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 263583 [details] Patch Attachment 263583 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/312324 Number of test failures exceeded the failure limit.
Created attachment 263585 [details] Archive of layout-test-results from ews103 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-mavericks Platform: Mac OS X 10.9.5
Comment on attachment 263583 [details] Patch Attachment 263583 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/312328 Number of test failures exceeded the failure limit.
Created attachment 263587 [details] Archive of layout-test-results from ews104 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Comment on attachment 263583 [details] Patch Attachment 263583 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/312679 Number of test failures exceeded the failure limit.
Created attachment 263599 [details] Archive of layout-test-results from ews115 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-yosemite Platform: Mac OS X 10.10.5
Created attachment 264038 [details] Patch
Attachment 264038 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:55: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:111: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:114: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:103: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/mock/ScrollbarThemeMock.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:248: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:260: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:265: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:277: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:287: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:756: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:758: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm:79: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:812: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:817: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/cg/BitmapImageCG.cpp:171: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2079: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2085: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:3255: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:192: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:198: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:199: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/NumberInputType.cpp:151: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:72: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:82: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderLayer.cpp:3695: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:77: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:83: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:89: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:95: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:438: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:443: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:449: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:455: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:460: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.h:172: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:53: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/Shared/mac/ArgumentCodersMac.mm:327: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/win/GraphicsContextCGWin.cpp:176: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/mac/ColorMac.mm:39: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/BorderValue.h:74: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/css/CSSParser.cpp:7745: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/inspector/InspectorDOMAgent.cpp:120: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:80: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:86: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/rendering/style/RenderStyle.cpp:1642: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/svg/SVGAnimatedColor.cpp:102: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:305: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:316: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:405: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:445: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:479: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:505: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1275: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1276: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2075: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2076: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2084: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2085: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2088: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2094: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2096: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:638: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1201: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1205: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1207: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1209: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1211: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1217: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1219: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1227: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1229: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1233: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1241: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1245: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1247: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1249: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1253: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1264: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/CollapsedBorderValue.h:56: Missing space before { [whitespace/braces] [5] Total errors found: 86 in 287 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 264038 [details] Patch Attachment 264038 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/338744 New failing tests: css3/selectors3/xml/css3-modsel-68.xml imported/w3c/css/css-multicol-1/multicol-rule-style-inset-001.xht imported/w3c/css/css-multicol-1/multicol-rule-style-outset-001.xht css2.1/20110323/border-conflict-element-001d.htm fast/table/paint-section-borders-without-cells-vertical-lr.html css3/selectors3/html/css3-modsel-68.html imported/w3c/css/css-multicol-1/multicol-rule-style-groove-001.xht fast/table/paint-section-borders-without-cells.html css3/selectors3/xhtml/css3-modsel-68.xml css3/selectors3/html/css3-modsel-24.html fast/forms/basic-selects.html fast/table/paint-section-borders-without-cells-rtl.html svg/hixie/perf/007.xml fast/forms/disabled-select-change-index.html fast/css-intrinsic-dimensions/height-css-tables-collapsed.html fast/forms/file/file-input-disabled.html svg/custom/mask-colorspace.svg css3/selectors3/xhtml/css3-modsel-24.xml fast/table/paint-section-borders-without-cells-vertical-rl.html editing/mac/attributed-string/anchor-element.html imported/w3c/css/css-multicol-1/multicol-rule-style-ridge-001.xht css3/selectors3/xml/css3-modsel-24.xml editing/mac/attributed-string/basic.html svg/custom/fill-opacity-hsl.svg
Created attachment 264039 [details] Archive of layout-test-results from ews100 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-mavericks Platform: Mac OS X 10.9.5
Comment on attachment 264038 [details] Patch Attachment 264038 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/338750 New failing tests: css3/selectors3/xml/css3-modsel-68.xml imported/w3c/css/css-multicol-1/multicol-rule-style-inset-001.xht imported/w3c/css/css-multicol-1/multicol-rule-style-outset-001.xht css2.1/20110323/border-conflict-element-001d.htm fast/table/paint-section-borders-without-cells-vertical-lr.html css3/selectors3/html/css3-modsel-68.html imported/w3c/css/css-multicol-1/multicol-rule-style-groove-001.xht fast/table/paint-section-borders-without-cells.html css3/selectors3/xhtml/css3-modsel-68.xml css3/selectors3/html/css3-modsel-24.html fast/forms/basic-selects.html fast/table/paint-section-borders-without-cells-rtl.html svg/hixie/perf/007.xml fast/forms/disabled-select-change-index.html fast/css-intrinsic-dimensions/height-css-tables-collapsed.html fast/forms/file/file-input-disabled.html svg/custom/mask-colorspace.svg css3/selectors3/xhtml/css3-modsel-24.xml fast/table/paint-section-borders-without-cells-vertical-rl.html imported/w3c/css/css-multicol-1/multicol-rule-style-ridge-001.xht css3/selectors3/xml/css3-modsel-24.xml svg/custom/fill-opacity-hsl.svg
Created attachment 264040 [details] Archive of layout-test-results from ews107 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Comment on attachment 264038 [details] Patch Attachment 264038 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/338746 New failing tests: imported/w3c/css/css-multicol-1/multicol-rule-style-groove-001.xht fast/table/paint-section-borders-without-cells.html fast/css-intrinsic-dimensions/height-css-tables-collapsed.html imported/w3c/css/css-multicol-1/multicol-rule-style-ridge-001.xht imported/w3c/css/css-multicol-1/multicol-rule-style-inset-001.xht fast/table/paint-section-borders-without-cells-vertical-rl.html fast/dom/attribute-legacy-colors.html imported/w3c/css/css-multicol-1/multicol-rule-style-outset-001.xht css2.1/20110323/border-conflict-element-001d.htm fast/table/paint-section-borders-without-cells-rtl.html svg/custom/mask-colorspace.svg svg/hixie/perf/007.xml fast/table/paint-section-borders-without-cells-vertical-lr.html svg/custom/fill-opacity-hsl.svg
Created attachment 264041 [details] Archive of layout-test-results from ews112 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-yosemite Platform: Mac OS X 10.10.5
Created attachment 264132 [details] Patch
Attachment 264132 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:55: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:111: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:114: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:103: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:782: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:784: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:863: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:864: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:865: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:866: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/mock/ScrollbarThemeMock.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:248: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:260: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:265: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:277: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:287: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:305: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:316: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:756: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:758: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm:79: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:812: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:817: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/WebPage/ios/FindControllerIOS.mm:56: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/cg/BitmapImageCG.cpp:171: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2067: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2073: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:3243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:192: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:198: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:199: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/NumberInputType.cpp:151: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:72: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:82: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderLayer.cpp:3695: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:77: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:83: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:89: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:95: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:438: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:443: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:449: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:455: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:460: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.h:172: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:53: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/Shared/mac/ArgumentCodersMac.mm:327: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/win/GraphicsContextCGWin.cpp:176: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/mac/ColorMac.mm:39: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/BorderValue.h:74: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/css/CSSParser.cpp:7745: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/inspector/InspectorDOMAgent.cpp:120: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:80: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:86: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/rendering/style/RenderStyle.cpp:1642: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/svg/SVGAnimatedColor.cpp:102: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:403: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:443: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:477: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:503: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1273: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1274: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2073: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2074: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2082: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2083: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2086: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2092: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2094: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:638: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1201: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1205: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1207: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1209: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1211: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1217: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1219: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1227: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1229: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1233: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1241: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1245: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1247: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1249: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1253: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1264: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/CollapsedBorderValue.h:56: Missing space before { [whitespace/braces] [5] Total errors found: 93 in 297 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 264132 [details] Patch Attachment 264132 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/344822 New failing tests: svg/hixie/perf/007.xml accessibility/content-editable-as-textarea.html fast/forms/disabled-select-change-index.html css3/selectors3/xml/css3-modsel-68.xml fast/css/hsla-color.html css3/selectors3/xml/css3-modsel-24.xml fast/forms/file/file-input-disabled.html css3/selectors3/xhtml/css3-modsel-24.xml css3/calc/color-rgb.html css3/selectors3/html/css3-modsel-24.html svg/custom/mask-colorspace.svg css3/selectors3/xhtml/css3-modsel-68.xml fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-color.html svg/custom/fill-opacity-hsl.svg editing/mac/attributed-string/anchor-element.html fast/forms/basic-selects.html css3/calc/color-hsl.html editing/mac/attributed-string/basic.html fast/css/hsl-color.html css3/selectors3/html/css3-modsel-68.html
Created attachment 264136 [details] Archive of layout-test-results from ews101 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-mavericks Platform: Mac OS X 10.9.5
Comment on attachment 264132 [details] Patch Attachment 264132 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/344823 New failing tests: svg/hixie/perf/007.xml accessibility/content-editable-as-textarea.html fast/forms/disabled-select-change-index.html css3/selectors3/xml/css3-modsel-24.xml fast/css/hsla-color.html css3/selectors3/xml/css3-modsel-68.xml fast/forms/file/file-input-disabled.html css3/selectors3/xhtml/css3-modsel-24.xml css3/calc/color-rgb.html css3/selectors3/html/css3-modsel-24.html svg/custom/mask-colorspace.svg css3/selectors3/xhtml/css3-modsel-68.xml fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-color.html fast/forms/basic-selects.html css3/calc/color-hsl.html svg/custom/fill-opacity-hsl.svg fast/css/hsl-color.html css3/selectors3/html/css3-modsel-68.html
Created attachment 264137 [details] Archive of layout-test-results from ews107 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Comment on attachment 264132 [details] Patch Attachment 264132 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/344819 New failing tests: svg/hixie/perf/007.xml accessibility/content-editable-as-textarea.html fast/forms/disabled-select-change-index.html css3/selectors3/xml/css3-modsel-68.xml fast/css/hsla-color.html css3/selectors3/xml/css3-modsel-24.xml fast/dom/attribute-legacy-colors.html css3/selectors3/xhtml/css3-modsel-24.xml fast/forms/file/file-input-disabled.html css3/calc/color-rgb.html css3/selectors3/html/css3-modsel-24.html svg/custom/mask-colorspace.svg css3/selectors3/xhtml/css3-modsel-68.xml fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-color.html fast/forms/basic-selects.html css3/calc/color-hsl.html svg/custom/fill-opacity-hsl.svg fast/css/hsl-color.html css3/selectors3/html/css3-modsel-68.html
Created attachment 264138 [details] Archive of layout-test-results from ews115 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 264132 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=264132&action=review > Source/WebCore/platform/graphics/Color.h:70 > +// To conver this into a color channel byte we multiply by 255, round and clamp into the range [0,255]. "conver" > Source/WebCore/platform/graphics/GraphicsLayer.cpp:35 > -#include "TextStream.h" > +#include "SVGRenderTreeAsText.h" This seems odd and is a layering violation. > Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:-1007 > -#if !PLATFORM(WIN) && !PLATFORM(IOS) > - CGColorSpaceRef colorSpace = CGImageGetColorSpace(m_pendingContentsImage.get()); > - > - static CGColorSpaceRef deviceRGB = CGColorSpaceCreateDeviceRGB(); > - if (colorSpace && CFEqual(colorSpace, deviceRGB)) { > - // CoreGraphics renders images tagged with DeviceRGB using the color space of the main display. When we hand such > - // images to CA we need to tag them similarly so CA rendering matches CG rendering. > - static CGColorSpaceRef genericRGB = CGDisplayCopyColorSpace(kCGDirectMainDisplay); > - m_pendingContentsImage = adoptCF(CGImageCreateCopyWithColorSpace(m_pendingContentsImage.get(), genericRGB)); > - } > -#endif Not sure why this is removable?
(In reply to comment #36) > Comment on attachment 264132 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=264132&action=review > > Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:-1007 > > -#if !PLATFORM(WIN) && !PLATFORM(IOS) > > - CGColorSpaceRef colorSpace = CGImageGetColorSpace(m_pendingContentsImage.get()); > > - > > - static CGColorSpaceRef deviceRGB = CGColorSpaceCreateDeviceRGB(); > > - if (colorSpace && CFEqual(colorSpace, deviceRGB)) { > > - // CoreGraphics renders images tagged with DeviceRGB using the color space of the main display. When we hand such > > - // images to CA we need to tag them similarly so CA rendering matches CG rendering. > > - static CGColorSpaceRef genericRGB = CGDisplayCopyColorSpace(kCGDirectMainDisplay); > > - m_pendingContentsImage = adoptCF(CGImageCreateCopyWithColorSpace(m_pendingContentsImage.get(), genericRGB)); > > - } > > -#endif > > Not sure why this is removable? IIRC (from patches I worked on that never landed), this test is no longer ever true; CGImageGetColorSpace no longer ever returns something that == DeviceRGB. Untagged images will return sRGB here (and there's another trick using ImageIO if you really want to tell if it was untagged).
Comment on attachment 264132 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=264132&action=review >> Source/WebCore/platform/graphics/GraphicsLayer.cpp:35 >> +#include "SVGRenderTreeAsText.h" > > This seems odd and is a layering violation. I think this is no longer needed after your recent patch to improve TextStream, Simon. SVGRenderTreeAsText.h used to be the place with the << operator for RGBA. I’ll change this back before landing anything. I’ll probably just search for SVGRenderTreeAsText.h and reduce inclusion of that as much as possible. >>> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:-1007 >>> -#endif >> >> Not sure why this is removable? > > IIRC (from patches I worked on that never landed), this test is no longer ever true; CGImageGetColorSpace no longer ever returns something that == DeviceRGB. Untagged images will return sRGB here (and there's another trick using ImageIO if you really want to tell if it was untagged). That’s right. This is something that should be landed separately right away and doesn’t need to wait for the rest of this patch. I’ll be trying to do that, carve off pieces of it and land it, soon.
Created attachment 264293 [details] Patch
Created attachment 264488 [details] Patch
Attachment 264488 [details] did not pass style-queue: ERROR: Source/WebCore/html/canvas/CanvasStyle.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:72: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:82: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2067: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2073: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:3243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:438: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:443: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:449: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:455: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:460: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm:79: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.h:172: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:77: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:83: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:89: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:95: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/win/GraphicsContextCGWin.cpp:176: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/css/CSSParser.cpp:7745: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/svg/SVGAnimatedColor.cpp:102: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:305: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:316: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:403: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:443: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:477: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:503: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1273: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1274: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2073: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2074: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2082: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2083: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2086: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2092: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2094: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:638: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1201: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1205: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1207: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1209: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1211: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1217: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1219: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1227: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1229: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1233: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1241: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1245: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1247: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1249: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1253: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1264: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:248: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:260: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:265: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:277: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:287: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:103: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:192: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:198: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:199: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/Shared/mac/ArgumentCodersMac.mm:327: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:80: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:86: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/rendering/style/RenderStyle.cpp:1642: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:812: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:817: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/WebPage/ios/FindControllerIOS.mm:56: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/cg/BitmapImageCG.cpp:171: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:756: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:758: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/mac/ColorMac.mm:39: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:782: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:784: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:863: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:864: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:865: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:866: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:55: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:111: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:114: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/mock/ScrollbarThemeMock.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:53: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/BorderValue.h:74: Missing space before { [whitespace/braces] [5] ERROR: LayoutTests/platform/mac/svg/hixie/perf/007-expected.png:0: Image lacks a checksum. Generate pngs using run-webkit-tests to ensure they have a checksum. [image/png] [5] ERROR: Source/WebCore/inspector/InspectorDOMAgent.cpp:120: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderLayer.cpp:3695: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/CollapsedBorderValue.h:56: Missing space before { [whitespace/braces] [5] Total errors found: 93 in 321 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 264488 [details] Patch Attachment 264488 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/364671 New failing tests: css3/selectors3/xml/css3-modsel-24.xml css3/selectors3/xml/css3-modsel-68.xml css3/selectors3/xhtml/css3-modsel-24.xml css3/selectors3/xhtml/css3-modsel-68.xml css3/selectors3/html/css3-modsel-24.html editing/mac/attributed-string/anchor-element.html accessibility/content-editable-as-textarea.html editing/mac/attributed-string/basic.html css3/selectors3/html/css3-modsel-68.html
Created attachment 264492 [details] Archive of layout-test-results from ews101 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-mavericks Platform: Mac OS X 10.9.5
Comment on attachment 264488 [details] Patch Attachment 264488 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/364675 New failing tests: css3/selectors3/xml/css3-modsel-24.xml css3/selectors3/xml/css3-modsel-68.xml css3/selectors3/xhtml/css3-modsel-24.xml css3/selectors3/xhtml/css3-modsel-68.xml css3/selectors3/html/css3-modsel-24.html accessibility/content-editable-as-textarea.html css3/selectors3/html/css3-modsel-68.html
Comment on attachment 264488 [details] Patch Attachment 264488 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/364673 New failing tests: accessibility/content-editable-as-textarea.html fast/dom/attribute-legacy-colors.html
Created attachment 264493 [details] Archive of layout-test-results from ews106 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Created attachment 264494 [details] Archive of layout-test-results from ews116 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-yosemite Platform: Mac OS X 10.10.5
Created attachment 264495 [details] Patch
Attachment 264495 [details] did not pass style-queue: ERROR: Source/WebCore/html/canvas/CanvasStyle.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:72: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:82: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2067: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2073: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:3243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:433: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:438: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:444: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:450: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:455: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm:79: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.h:172: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:77: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:83: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:89: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:95: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/win/GraphicsContextCGWin.cpp:176: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/css/CSSParser.cpp:7745: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/svg/SVGAnimatedColor.cpp:102: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:305: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:316: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:403: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:443: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:477: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:503: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1273: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1274: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2073: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2074: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2082: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2083: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2086: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2092: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2094: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:638: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1201: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1205: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1207: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1209: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1211: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1217: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1219: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1227: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1229: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1233: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1241: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1245: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1247: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1249: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1253: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1264: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:248: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:260: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:265: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:277: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:287: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderLayer.cpp:3695: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:103: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:192: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:198: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:199: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/Shared/mac/ArgumentCodersMac.mm:327: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:80: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:86: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/rendering/style/RenderStyle.cpp:1642: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:812: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:817: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/WebPage/ios/FindControllerIOS.mm:56: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/cg/BitmapImageCG.cpp:171: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:756: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:758: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/mac/ColorMac.mm:39: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:782: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:784: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:863: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:864: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:865: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:866: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:55: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:111: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:114: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/mock/ScrollbarThemeMock.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:53: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/BorderValue.h:74: Missing space before { [whitespace/braces] [5] ERROR: LayoutTests/platform/mac/svg/hixie/perf/007-expected.png:0: Image lacks a checksum. Generate pngs using run-webkit-tests to ensure they have a checksum. [image/png] [5] ERROR: Source/WebCore/inspector/InspectorDOMAgent.cpp:120: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/CollapsedBorderValue.h:56: Missing space before { [whitespace/braces] [5] Total errors found: 93 in 337 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 264497 [details] Patch
Attachment 264497 [details] did not pass style-queue: ERROR: Source/WebCore/html/canvas/CanvasStyle.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:72: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:82: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2067: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2073: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:3243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:433: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:438: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:444: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:450: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:455: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm:79: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.h:172: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:77: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:83: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:89: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:95: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/win/GraphicsContextCGWin.cpp:176: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/css/CSSParser.cpp:7745: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/svg/SVGAnimatedColor.cpp:102: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:305: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:316: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:403: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:443: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:477: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:503: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1273: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1274: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2073: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2074: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2082: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2083: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2086: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2092: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2094: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:638: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1201: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1205: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1207: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1209: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1211: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1217: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1219: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1227: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1229: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1233: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1241: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1245: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1247: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1249: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1253: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1264: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:248: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:260: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:265: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:277: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:287: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderLayer.cpp:3695: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:103: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:192: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:198: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:199: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/Shared/mac/ArgumentCodersMac.mm:327: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:80: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:86: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/rendering/style/RenderStyle.cpp:1642: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:812: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:817: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/WebPage/ios/FindControllerIOS.mm:56: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/cg/BitmapImageCG.cpp:171: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:756: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:758: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/mac/ColorMac.mm:39: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:782: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:784: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:863: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:864: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:865: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:866: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:883: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:884: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:895: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:896: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:897: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:898: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:899: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:900: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:904: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:905: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:906: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:55: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:111: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:114: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/mock/ScrollbarThemeMock.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:53: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/BorderValue.h:74: Missing space before { [whitespace/braces] [5] ERROR: LayoutTests/platform/mac/svg/hixie/perf/007-expected.png:0: Image lacks a checksum. Generate pngs using run-webkit-tests to ensure they have a checksum. [image/png] [5] ERROR: Source/WebCore/inspector/InspectorDOMAgent.cpp:120: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/CollapsedBorderValue.h:56: Missing space before { [whitespace/braces] [5] Total errors found: 104 in 341 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 264527 [details] Patch
Attachment 264527 [details] did not pass style-queue: ERROR: Source/WebCore/html/canvas/CanvasStyle.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:72: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:82: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2067: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2073: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:3243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:433: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:438: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:444: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:450: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:455: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm:79: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.h:172: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:77: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:83: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:89: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:95: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/win/GraphicsContextCGWin.cpp:176: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/css/CSSParser.cpp:7745: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/svg/SVGAnimatedColor.cpp:102: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:305: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:316: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:403: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:443: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:477: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:503: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1273: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1274: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2073: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2074: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2082: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2083: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2086: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2092: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2094: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:638: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1201: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1205: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1207: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1209: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1211: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1217: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1219: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1227: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1229: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1233: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1241: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1245: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1247: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1249: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1253: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1264: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:248: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:260: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:265: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:277: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:287: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:219: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:220: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:238: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:239: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:240: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/cairo/BitmapImageCairo.cpp:144: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderLayer.cpp:3695: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:103: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:192: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:198: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:199: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/Shared/mac/ArgumentCodersMac.mm:327: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:80: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:86: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/rendering/style/RenderStyle.cpp:1642: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:812: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:817: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/WebPage/ios/FindControllerIOS.mm:56: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/cg/BitmapImageCG.cpp:171: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:756: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:758: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/mac/ColorMac.mm:39: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:782: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:784: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:863: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:864: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:865: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:866: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:883: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:884: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:895: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:896: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:897: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:898: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:899: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:900: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:904: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:905: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:906: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:55: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:111: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:114: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/mock/ScrollbarThemeMock.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:53: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/BorderValue.h:74: Missing space before { [whitespace/braces] [5] ERROR: LayoutTests/platform/mac/svg/hixie/perf/007-expected.png:0: Image lacks a checksum. Generate pngs using run-webkit-tests to ensure they have a checksum. [image/png] [5] ERROR: Source/WebCore/inspector/InspectorDOMAgent.cpp:120: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/CollapsedBorderValue.h:56: Missing space before { [whitespace/braces] [5] Total errors found: 110 in 347 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 264528 [details] Patch
Created attachment 264529 [details] Patch
Attachment 264529 [details] did not pass style-queue: ERROR: Source/WebCore/html/canvas/CanvasStyle.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:72: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:82: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2067: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2073: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:3243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:433: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:438: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:444: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:450: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:455: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm:79: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.h:172: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:77: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:83: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:89: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:95: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/win/GraphicsContextCGWin.cpp:176: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/css/CSSParser.cpp:7745: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/svg/SVGAnimatedColor.cpp:102: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:305: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:316: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:403: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:443: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:477: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:503: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1273: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1274: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2073: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2074: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2082: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2083: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2086: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2092: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2094: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:638: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1201: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1205: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1207: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1209: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1211: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1217: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1219: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1227: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1229: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1233: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1241: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1245: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1247: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1249: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1253: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1264: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:248: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:260: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:265: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:277: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:287: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:219: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:220: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:238: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:239: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:240: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/cairo/BitmapImageCairo.cpp:144: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderLayer.cpp:3695: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:103: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:192: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:198: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:199: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/Shared/mac/ArgumentCodersMac.mm:327: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:80: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:86: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/rendering/style/RenderStyle.cpp:1642: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:812: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:817: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/WebPage/ios/FindControllerIOS.mm:56: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/cg/BitmapImageCG.cpp:171: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:756: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:758: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/mac/ColorMac.mm:39: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:782: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:784: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:863: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:864: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:865: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:866: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:883: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:884: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:895: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:896: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:897: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:898: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:899: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:900: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:904: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:905: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:906: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:55: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:111: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:114: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/mock/ScrollbarThemeMock.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/mac/WebView/WebIndicateLayer.mm:52: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:53: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/BorderValue.h:74: Missing space before { [whitespace/braces] [5] ERROR: LayoutTests/platform/mac/svg/hixie/perf/007-expected.png:0: Image lacks a checksum. Generate pngs using run-webkit-tests to ensure they have a checksum. [image/png] [5] ERROR: Source/WebCore/inspector/InspectorDOMAgent.cpp:120: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/CollapsedBorderValue.h:56: Missing space before { [whitespace/braces] [5] Total errors found: 111 in 349 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 264533 [details] Patch
Attachment 264533 [details] did not pass style-queue: ERROR: Source/WebCore/html/canvas/CanvasStyle.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:72: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:82: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2067: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2073: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:3243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:433: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:438: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:444: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:450: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:455: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm:79: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.h:172: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:77: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:83: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:89: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:95: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/win/GraphicsContextCGWin.cpp:176: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/css/CSSParser.cpp:7745: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/svg/SVGAnimatedColor.cpp:102: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:305: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:316: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:403: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:443: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:477: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:503: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1273: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1274: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2073: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2074: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2082: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2083: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2086: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2092: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2094: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:638: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1201: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1205: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1207: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1209: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1211: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1217: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1219: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1227: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1229: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1233: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1241: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1245: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1247: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1249: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1253: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1264: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:248: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:260: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:265: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:277: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:287: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:219: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:220: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:238: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:239: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:240: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/cairo/BitmapImageCairo.cpp:144: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderLayer.cpp:3695: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:103: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:192: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:198: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:199: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/Shared/mac/ArgumentCodersMac.mm:327: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:80: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:86: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/rendering/style/RenderStyle.cpp:1642: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:812: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:817: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/WebPage/ios/FindControllerIOS.mm:56: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/cg/BitmapImageCG.cpp:171: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:756: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:758: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/mac/ColorMac.mm:39: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:782: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:784: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:863: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:864: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:865: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:866: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:883: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:884: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:895: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:896: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:897: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:898: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:899: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:900: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:904: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:905: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:906: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:55: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:111: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:114: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/mock/ScrollbarThemeMock.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/mac/WebView/WebIndicateLayer.mm:52: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:53: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/BorderValue.h:74: Missing space before { [whitespace/braces] [5] ERROR: LayoutTests/platform/mac/svg/hixie/perf/007-expected.png:0: Image lacks a checksum. Generate pngs using run-webkit-tests to ensure they have a checksum. [image/png] [5] ERROR: Source/WebCore/inspector/InspectorDOMAgent.cpp:120: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/CollapsedBorderValue.h:56: Missing space before { [whitespace/braces] [5] Total errors found: 111 in 349 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 264539 [details] Patch
Attachment 264539 [details] did not pass style-queue: ERROR: Source/WebCore/html/canvas/CanvasStyle.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:72: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:82: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2067: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2073: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:3243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:433: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:438: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:444: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:450: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:455: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm:79: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.h:172: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:77: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:83: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:89: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:95: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/win/GraphicsContextCGWin.cpp:176: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/css/CSSParser.cpp:7745: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/svg/SVGAnimatedColor.cpp:102: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:305: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:316: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:403: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:443: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:477: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:503: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1273: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1274: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2073: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2074: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2082: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2083: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2086: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2092: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2094: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:638: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1201: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1205: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1207: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1209: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1211: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1217: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1219: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1227: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1229: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1233: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1241: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1245: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1247: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1249: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1253: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1264: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:248: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:260: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:265: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:277: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:287: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:219: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:220: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:238: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:239: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:240: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/cairo/BitmapImageCairo.cpp:144: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderLayer.cpp:3695: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:103: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:192: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:198: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:199: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/Shared/mac/ArgumentCodersMac.mm:327: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:80: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:86: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/rendering/style/RenderStyle.cpp:1642: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:812: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:817: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/WebPage/ios/FindControllerIOS.mm:56: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/cg/BitmapImageCG.cpp:171: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:756: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:758: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/mac/ColorMac.mm:39: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:782: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:784: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:863: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:864: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:865: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:866: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:883: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:884: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:895: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:896: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:897: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:898: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:899: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:900: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:904: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:905: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:906: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:55: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:111: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:114: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/mock/ScrollbarThemeMock.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/mac/WebView/WebIndicateLayer.mm:52: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:53: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/BorderValue.h:74: Missing space before { [whitespace/braces] [5] ERROR: LayoutTests/platform/mac/svg/hixie/perf/007-expected.png:0: Image lacks a checksum. Generate pngs using run-webkit-tests to ensure they have a checksum. [image/png] [5] ERROR: Source/WebCore/inspector/InspectorDOMAgent.cpp:120: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/CollapsedBorderValue.h:56: Missing space before { [whitespace/braces] [5] Total errors found: 111 in 349 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 264545 [details] Patch
Attachment 264545 [details] did not pass style-queue: ERROR: Source/WebCore/html/canvas/CanvasStyle.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:72: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:82: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2067: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2073: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:3243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:433: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:438: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:444: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:450: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:455: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm:79: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.h:172: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:77: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:83: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:89: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:95: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/win/GraphicsContextCGWin.cpp:176: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/css/CSSParser.cpp:7745: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/svg/SVGAnimatedColor.cpp:102: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:305: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:316: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:403: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:443: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:477: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:503: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1273: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1274: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2073: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2074: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2082: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2083: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2086: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2092: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2094: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:638: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1201: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1205: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1207: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1209: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1211: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1217: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1219: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1227: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1229: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1233: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1241: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1245: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1247: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1249: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1253: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1264: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:248: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:260: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:265: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:277: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:287: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:219: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:220: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:238: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:239: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:240: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/cairo/BitmapImageCairo.cpp:144: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderLayer.cpp:3695: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:103: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:192: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:198: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:199: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/Shared/mac/ArgumentCodersMac.mm:327: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:80: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:86: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/rendering/style/RenderStyle.cpp:1642: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:812: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:817: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/WebPage/ios/FindControllerIOS.mm:56: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/cg/BitmapImageCG.cpp:171: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:756: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:758: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:2401: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/mac/ColorMac.mm:39: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:782: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:784: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:863: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:864: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:865: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:866: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:883: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:884: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:895: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:896: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:897: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:898: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:899: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:900: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:904: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:905: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:906: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:55: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:111: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:114: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/mock/ScrollbarThemeMock.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/mac/WebView/WebIndicateLayer.mm:52: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:53: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/BorderValue.h:74: Missing space before { [whitespace/braces] [5] ERROR: LayoutTests/platform/mac/svg/hixie/perf/007-expected.png:0: Image lacks a checksum. Generate pngs using run-webkit-tests to ensure they have a checksum. [image/png] [5] ERROR: Source/WebCore/inspector/InspectorDOMAgent.cpp:120: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/CollapsedBorderValue.h:56: Missing space before { [whitespace/braces] [5] Total errors found: 112 in 349 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 264551 [details] Patch
Attachment 264551 [details] did not pass style-queue: ERROR: Source/WebCore/html/canvas/CanvasStyle.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:72: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:82: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2067: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2073: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:3243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:433: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:438: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:444: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:450: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:455: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm:79: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.h:172: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:77: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:83: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:89: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:95: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/win/GraphicsContextCGWin.cpp:176: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/css/CSSParser.cpp:7745: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/svg/SVGAnimatedColor.cpp:102: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:305: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:316: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:403: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:443: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:477: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:503: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1273: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1274: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2073: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2074: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2082: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2083: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2086: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2092: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2094: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:638: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1201: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1205: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1207: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1209: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1211: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1217: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1219: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1227: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1229: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1233: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1241: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1245: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1247: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1249: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1253: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1264: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:248: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:260: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:265: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:277: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:287: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:219: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:220: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:238: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:239: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:240: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/cairo/BitmapImageCairo.cpp:144: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderLayer.cpp:3695: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:103: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:192: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:198: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:199: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/Shared/mac/ArgumentCodersMac.mm:327: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:80: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:86: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/rendering/style/RenderStyle.cpp:1642: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:812: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:817: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/WebPage/ios/FindControllerIOS.mm:56: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/cg/BitmapImageCG.cpp:171: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:756: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:758: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:2401: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/mac/ColorMac.mm:39: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:782: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:784: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:863: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:864: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:865: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:866: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:883: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:884: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:895: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:896: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:897: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:898: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:899: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:900: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:904: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:905: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:906: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:55: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:111: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:114: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/mock/ScrollbarThemeMock.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/mac/WebView/WebIndicateLayer.mm:52: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:53: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/BorderValue.h:74: Missing space before { [whitespace/braces] [5] ERROR: LayoutTests/platform/mac/svg/hixie/perf/007-expected.png:0: Image lacks a checksum. Generate pngs using run-webkit-tests to ensure they have a checksum. [image/png] [5] ERROR: Source/WebCore/inspector/InspectorDOMAgent.cpp:120: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/CollapsedBorderValue.h:56: Missing space before { [whitespace/braces] [5] Total errors found: 112 in 348 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 264553 [details] Patch
Created attachment 264555 [details] Patch
Attachment 264555 [details] did not pass style-queue: ERROR: Source/WebCore/html/canvas/CanvasStyle.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:72: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:82: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2067: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2073: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:3243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:433: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:438: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:444: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:450: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:455: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm:79: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.h:172: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:77: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:83: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:89: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:95: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/win/GraphicsContextCGWin.cpp:176: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/css/CSSParser.cpp:7745: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/svg/SVGAnimatedColor.cpp:102: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:305: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:316: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:403: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:443: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:477: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:503: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1273: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1274: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2073: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2074: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2082: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2083: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2086: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2092: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2094: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:638: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1201: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1205: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1207: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1209: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1211: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1217: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1219: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1227: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1229: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1233: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1241: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1245: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1247: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1249: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1253: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1264: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:248: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:260: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:265: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:277: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:287: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:219: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:220: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:238: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:239: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:240: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/cairo/BitmapImageCairo.cpp:144: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderLayer.cpp:3695: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:103: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:192: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:198: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:199: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/Shared/mac/ArgumentCodersMac.mm:327: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:80: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:86: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/rendering/style/RenderStyle.cpp:1642: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:812: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:817: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/WebPage/ios/FindControllerIOS.mm:56: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/cg/BitmapImageCG.cpp:171: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:756: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:758: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:2401: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/mac/ColorMac.mm:39: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:782: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:784: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:863: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:864: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:865: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:866: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:883: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:884: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:895: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:896: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:897: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:898: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:899: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:900: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:904: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:905: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:906: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:55: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:111: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:114: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/mock/ScrollbarThemeMock.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/mac/WebView/WebIndicateLayer.mm:52: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:53: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/BorderValue.h:74: Missing space before { [whitespace/braces] [5] ERROR: LayoutTests/platform/mac/svg/hixie/perf/007-expected.png:0: Image lacks a checksum. Generate pngs using run-webkit-tests to ensure they have a checksum. [image/png] [5] ERROR: Source/WebCore/inspector/InspectorDOMAgent.cpp:120: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/CollapsedBorderValue.h:56: Missing space before { [whitespace/braces] [5] Total errors found: 112 in 345 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 264558 [details] Patch
Attachment 264558 [details] did not pass style-queue: ERROR: Source/WebCore/html/canvas/CanvasStyle.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:72: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:82: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2067: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2073: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:3243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:433: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:438: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:444: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:450: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:455: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm:79: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.h:172: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:77: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:83: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:89: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:95: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/win/GraphicsContextCGWin.cpp:176: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/css/CSSParser.cpp:7745: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/svg/SVGAnimatedColor.cpp:102: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:305: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:316: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:403: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:443: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:477: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:503: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1273: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1274: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2073: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2074: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2082: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2083: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2086: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2092: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2094: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:638: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1201: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1205: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1207: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1209: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1211: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1217: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1219: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1227: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1229: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1233: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1241: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1245: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1247: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1249: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1253: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1264: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:248: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:260: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:265: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:277: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:287: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:219: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:220: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:238: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:239: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:240: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/cairo/BitmapImageCairo.cpp:144: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderLayer.cpp:3695: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:103: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:192: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:198: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:199: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/Shared/mac/ArgumentCodersMac.mm:327: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:80: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:86: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/rendering/style/RenderStyle.cpp:1642: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:812: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:817: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/WebPage/ios/FindControllerIOS.mm:56: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/cg/BitmapImageCG.cpp:171: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:756: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:758: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:2401: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/mac/ColorMac.mm:39: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:782: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:784: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:863: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:864: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:865: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:866: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:883: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:884: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:895: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:896: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:897: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:898: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:899: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:900: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:904: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:905: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:906: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:55: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:111: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:114: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/mock/ScrollbarThemeMock.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/mac/WebView/WebIndicateLayer.mm:52: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:53: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/BorderValue.h:74: Missing space before { [whitespace/braces] [5] ERROR: LayoutTests/platform/mac/svg/hixie/perf/007-expected.png:0: Image lacks a checksum. Generate pngs using run-webkit-tests to ensure they have a checksum. [image/png] [5] ERROR: Source/WebCore/inspector/InspectorDOMAgent.cpp:120: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/CollapsedBorderValue.h:56: Missing space before { [whitespace/braces] [5] Total errors found: 112 in 344 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 264662 [details] Patch
Attachment 264662 [details] did not pass style-queue: ERROR: Source/WebCore/html/canvas/CanvasStyle.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:72: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:82: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2067: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2073: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:3243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:433: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:438: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:444: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:450: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:455: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm:79: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.h:172: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:77: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:83: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:89: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:95: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/win/GraphicsContextCGWin.cpp:176: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/css/CSSParser.cpp:7744: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/svg/SVGAnimatedColor.cpp:102: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:305: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:316: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:403: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:443: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:477: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:503: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1273: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1274: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2073: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2074: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2082: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2083: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2086: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2092: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2094: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:638: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1201: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1205: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1207: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1209: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1211: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1217: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1219: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1227: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1229: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1233: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1241: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1245: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1247: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1249: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1253: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1264: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:248: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:260: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:265: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:277: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:287: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:219: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:220: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:238: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:239: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:240: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/cairo/BitmapImageCairo.cpp:144: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderLayer.cpp:3695: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:103: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:192: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:198: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:199: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeEfl.cpp:437: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeEfl.cpp:629: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeEfl.cpp:630: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeEfl.cpp:631: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/Shared/mac/ArgumentCodersMac.mm:327: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:80: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:86: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/rendering/style/RenderStyle.cpp:1642: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/FrameView.cpp:418: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/dom/Document.cpp:812: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:817: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/WebPage/ios/FindControllerIOS.mm:56: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/cg/BitmapImageCG.cpp:171: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:756: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:758: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:2401: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/mac/ColorMac.mm:39: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:775: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:777: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:856: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:857: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:858: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:859: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:876: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:877: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:888: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:889: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:890: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:891: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:892: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:893: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:897: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:898: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:899: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/gtk/ColorGtk.cpp:29: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:55: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:111: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:114: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/mock/ScrollbarThemeMock.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/mac/WebView/WebIndicateLayer.mm:52: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:53: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/BorderValue.h:74: Missing space before { [whitespace/braces] [5] ERROR: LayoutTests/platform/mac/svg/hixie/perf/007-expected.png:0: Image lacks a checksum. Generate pngs using run-webkit-tests to ensure they have a checksum. [image/png] [5] ERROR: Source/WebCore/inspector/InspectorDOMAgent.cpp:120: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/CollapsedBorderValue.h:56: Missing space before { [whitespace/braces] [5] Total errors found: 118 in 345 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 264795 [details] Patch
I'm going to take on the part of removing all the ColorSpace arguments (possibly stuplidly).
Created attachment 264938 [details] Patch
Attachment 264938 [details] did not pass style-queue: ERROR: Source/WebCore/html/canvas/CanvasStyle.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:72: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:82: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2067: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2073: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:3243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:433: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:438: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:444: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:450: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:455: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm:79: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.h:172: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:77: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:83: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:89: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:95: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/win/GraphicsContextCGWin.cpp:176: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/css/CSSParser.cpp:7744: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/svg/SVGAnimatedColor.cpp:102: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:305: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:316: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:403: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:443: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:477: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:503: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1273: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1274: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2077: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2078: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2086: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2087: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2090: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2096: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2098: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:638: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1201: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1205: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1207: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1209: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1211: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1217: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1219: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1227: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1229: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1233: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1241: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1245: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1247: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1249: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1253: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1264: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:263: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:275: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:280: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:292: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:302: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:169: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:170: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:171: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:173: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:174: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:177: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:178: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/cairo/BitmapImageCairo.cpp:144: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderLayer.cpp:3695: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:103: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:192: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:198: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:199: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeEfl.cpp:437: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeEfl.cpp:629: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeEfl.cpp:630: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeEfl.cpp:631: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/Shared/mac/ArgumentCodersMac.mm:327: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:80: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:86: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/rendering/style/RenderStyle.cpp:1642: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/FrameView.cpp:418: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/dom/Document.cpp:812: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:817: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/WebPage/ios/FindControllerIOS.mm:56: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/cg/BitmapImageCG.cpp:171: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:756: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:758: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:2402: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/mac/ColorMac.mm:39: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:775: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:777: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:856: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:857: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:858: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:859: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:876: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:877: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:888: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:889: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:890: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:891: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:892: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:893: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:897: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:898: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:899: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/gtk/ColorGtk.cpp:29: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:55: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:111: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:114: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/mock/ScrollbarThemeMock.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/mac/WebView/WebIndicateLayer.mm:52: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:53: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/BorderValue.h:74: Missing space before { [whitespace/braces] [5] ERROR: LayoutTests/platform/mac/svg/hixie/perf/007-expected.png:0: Image lacks a checksum. Generate pngs using run-webkit-tests to ensure they have a checksum. [image/png] [5] ERROR: Source/WebCore/inspector/InspectorDOMAgent.cpp:120: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/CollapsedBorderValue.h:56: Missing space before { [whitespace/braces] [5] Total errors found: 120 in 345 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 265008 [details] Patch
Attachment 265008 [details] did not pass style-queue: ERROR: Source/WebCore/html/canvas/CanvasStyle.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:72: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:82: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2067: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2073: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:3243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:433: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:438: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:444: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:450: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:455: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm:79: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.h:172: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:77: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:83: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:89: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:95: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/win/GraphicsContextCGWin.cpp:176: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/css/CSSParser.cpp:7744: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/svg/SVGAnimatedColor.cpp:102: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:305: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:316: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:403: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:443: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:477: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:503: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1273: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1274: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2077: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2078: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2086: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2087: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2090: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2096: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2098: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:638: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1201: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1205: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1207: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1209: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1211: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1217: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1219: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1227: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1229: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1233: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1241: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1245: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1247: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1249: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1253: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1264: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:263: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:275: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:280: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:292: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:302: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:169: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:170: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:171: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:173: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:174: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:177: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:178: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/cairo/BitmapImageCairo.cpp:144: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderLayer.cpp:3695: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:103: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:192: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:198: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:199: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeEfl.cpp:437: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeEfl.cpp:629: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeEfl.cpp:630: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeEfl.cpp:631: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/Shared/mac/ArgumentCodersMac.mm:327: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:80: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:86: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/rendering/style/RenderStyle.cpp:1642: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/FrameView.cpp:418: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/dom/Document.cpp:812: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:817: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/WebPage/ios/FindControllerIOS.mm:56: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/cg/BitmapImageCG.cpp:171: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:756: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:758: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:2402: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/mac/ColorMac.mm:39: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:775: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:777: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:856: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:857: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:858: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:859: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:876: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:877: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:888: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:889: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:890: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:891: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:892: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:893: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:897: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:898: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:899: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/gtk/ColorGtk.cpp:29: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:55: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:111: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:114: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/mock/ScrollbarThemeMock.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/mac/WebView/WebIndicateLayer.mm:52: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:53: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/BorderValue.h:74: Missing space before { [whitespace/braces] [5] ERROR: LayoutTests/platform/mac/svg/hixie/perf/007-expected.png:0: Image lacks a checksum. Generate pngs using run-webkit-tests to ensure they have a checksum. [image/png] [5] ERROR: Source/WebCore/inspector/InspectorDOMAgent.cpp:120: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/gtk/InputMethodFilter.cpp:157: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/gtk/InputMethodFilter.cpp:265: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/CollapsedBorderValue.h:56: Missing space before { [whitespace/braces] [5] Total errors found: 122 in 347 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 265010 [details] Patch
Attachment 265010 [details] did not pass style-queue: ERROR: Source/WebCore/html/canvas/CanvasStyle.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:72: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:82: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2067: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2073: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:3243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:433: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:438: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:444: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:450: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:455: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm:79: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.h:172: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:77: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:83: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:89: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:95: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/win/GraphicsContextCGWin.cpp:176: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/css/CSSParser.cpp:7744: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/svg/SVGAnimatedColor.cpp:102: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:305: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:316: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:403: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:443: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:477: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:503: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1273: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1274: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2077: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2078: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2086: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2087: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2090: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2096: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2098: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:638: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1201: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1205: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1207: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1209: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1211: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1217: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1219: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1227: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1229: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1233: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1241: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1245: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1247: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1249: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1253: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1264: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:263: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:275: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:280: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:292: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:302: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:169: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:170: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:171: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:173: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:174: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:177: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:178: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/cairo/BitmapImageCairo.cpp:144: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderLayer.cpp:3695: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:103: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:192: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:198: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:199: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeEfl.cpp:437: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeEfl.cpp:629: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeEfl.cpp:630: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeEfl.cpp:631: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/Shared/mac/ArgumentCodersMac.mm:327: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:80: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:86: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/rendering/style/RenderStyle.cpp:1642: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/FrameView.cpp:418: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/dom/Document.cpp:812: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:817: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/WebPage/ios/FindControllerIOS.mm:56: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/cg/BitmapImageCG.cpp:171: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/efl/ewk_color_picker.cpp:56: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:756: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:758: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:2402: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/mac/ColorMac.mm:39: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:775: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:777: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:856: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:857: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:858: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:859: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:876: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:877: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:888: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:889: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:890: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:891: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:892: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:893: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:897: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:898: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:899: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/gtk/ColorGtk.cpp:29: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:55: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:111: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:114: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/mock/ScrollbarThemeMock.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/mac/WebView/WebIndicateLayer.mm:52: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:53: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/BorderValue.h:74: Missing space before { [whitespace/braces] [5] ERROR: LayoutTests/platform/mac/svg/hixie/perf/007-expected.png:0: Image lacks a checksum. Generate pngs using run-webkit-tests to ensure they have a checksum. [image/png] [5] ERROR: Source/WebCore/inspector/InspectorDOMAgent.cpp:120: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/gtk/InputMethodFilter.cpp:157: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/gtk/InputMethodFilter.cpp:265: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/CollapsedBorderValue.h:56: Missing space before { [whitespace/braces] [5] Total errors found: 123 in 348 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 265019 [details] Patch
Attachment 265019 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:55: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:111: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:114: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/DebugPageOverlays.cpp:84: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/DebugPageOverlays.cpp:123: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/ios/LegacyTileCache.mm:478: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/ios/LegacyTileCache.mm:480: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/FrameView.cpp:418: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:316: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:395: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:400: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:666: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:685: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:686: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:775: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:777: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:856: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:857: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:858: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:859: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:876: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:877: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:888: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:889: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:890: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:891: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:892: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:893: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:897: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:898: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:899: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/mock/ScrollbarThemeMock.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:264: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:276: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:281: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:293: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:304: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:305: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:316: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:169: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:170: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:171: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:173: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:174: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:177: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:178: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/cairo/BitmapImageCairo.cpp:144: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm:79: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:812: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:817: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/WebPage/ios/FindControllerIOS.mm:56: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/cg/BitmapImageCG.cpp:171: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorClient.cpp:150: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:103: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2066: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2072: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:3242: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:192: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:198: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:199: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeEfl.cpp:437: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeEfl.cpp:629: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeEfl.cpp:630: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeEfl.cpp:631: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:72: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:82: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/efl/ewk_color_picker.cpp:56: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:756: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:758: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:433: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:438: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:444: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:450: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:455: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.h:172: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:53: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:77: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:83: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:89: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:95: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/Shared/mac/ArgumentCodersMac.mm:327: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/win/GraphicsContextCGWin.cpp:176: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/mac/ColorMac.mm:39: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/BorderValue.h:74: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/css/CSSParser.cpp:7744: Missing space before { [whitespace/braces] [5] ERROR: LayoutTests/platform/mac/svg/hixie/perf/007-expected.png:0: Image lacks a checksum. Generate pngs using run-webkit-tests to ensure they have a checksum. [image/png] [5] ERROR: Source/WebCore/inspector/InspectorDOMAgent.cpp:120: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/gtk/ColorGtk.cpp:29: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:80: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:86: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/rendering/style/RenderStyle.cpp:1642: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/svg/SVGAnimatedColor.cpp:102: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderLayer.cpp:1824: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderLayer.cpp:3695: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:2402: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/mac/WebView/WebIndicateLayer.mm:52: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:403: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:443: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:477: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:503: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1273: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1274: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2080: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2081: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2089: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2090: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2093: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2099: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2101: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/gtk/InputMethodFilter.cpp:157: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/gtk/InputMethodFilter.cpp:265: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:638: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1201: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1205: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1207: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1209: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1211: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1217: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1219: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1227: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1229: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1233: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1241: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1245: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1247: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1249: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1253: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1264: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/CollapsedBorderValue.h:56: Missing space before { [whitespace/braces] [5] Total errors found: 135 in 240 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 265022 [details] Patch
Dean is doing a lot of work in this area, moving the Color class forward; I am going to abandon this particular patch and this particular specific direction.