WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED WONTFIX
150305
Next step in clean-up for Color and ColorSpace
https://bugs.webkit.org/show_bug.cgi?id=150305
Summary
Next step in clean-up for Color and ColorSpace
Darin Adler
Reported
2015-10-18 15:35:50 PDT
Next step in clean-up for Color and ColorSpace
Attachments
Patch
(603.16 KB, patch)
2015-10-18 15:54 PDT
,
Darin Adler
no flags
Details
Formatted Diff
Diff
Patch
(620.93 KB, patch)
2015-10-19 22:13 PDT
,
Darin Adler
no flags
Details
Formatted Diff
Diff
Patch
(634.25 KB, patch)
2015-10-20 07:32 PDT
,
Darin Adler
no flags
Details
Formatted Diff
Diff
Archive of layout-test-results from ews101 for mac-mavericks
(194.50 KB, application/zip)
2015-10-20 08:35 PDT
,
Build Bot
no flags
Details
Archive of layout-test-results from ews104 for mac-mavericks-wk2
(179.72 KB, application/zip)
2015-10-20 08:37 PDT
,
Build Bot
no flags
Details
Patch
(639.01 KB, patch)
2015-10-20 09:31 PDT
,
Darin Adler
no flags
Details
Formatted Diff
Diff
Archive of layout-test-results from ews103 for mac-mavericks
(634.32 KB, application/zip)
2015-10-20 10:20 PDT
,
Build Bot
no flags
Details
Archive of layout-test-results from ews104 for mac-mavericks-wk2
(667.19 KB, application/zip)
2015-10-20 10:25 PDT
,
Build Bot
no flags
Details
Archive of layout-test-results from ews115 for mac-yosemite
(698.40 KB, application/zip)
2015-10-20 12:24 PDT
,
Build Bot
no flags
Details
Patch
(661.20 KB, patch)
2015-10-25 23:18 PDT
,
Darin Adler
no flags
Details
Formatted Diff
Diff
Archive of layout-test-results from ews100 for mac-mavericks
(2.96 MB, application/zip)
2015-10-26 00:21 PDT
,
Build Bot
no flags
Details
Archive of layout-test-results from ews107 for mac-mavericks-wk2
(3.00 MB, application/zip)
2015-10-26 00:24 PDT
,
Build Bot
no flags
Details
Archive of layout-test-results from ews112 for mac-yosemite
(2.59 MB, application/zip)
2015-10-26 00:31 PDT
,
Build Bot
no flags
Details
Patch
(750.46 KB, patch)
2015-10-27 09:26 PDT
,
Darin Adler
no flags
Details
Formatted Diff
Diff
Archive of layout-test-results from ews101 for mac-mavericks
(2.99 MB, application/zip)
2015-10-27 10:30 PDT
,
Build Bot
no flags
Details
Archive of layout-test-results from ews107 for mac-mavericks-wk2
(3.01 MB, application/zip)
2015-10-27 10:33 PDT
,
Build Bot
no flags
Details
Archive of layout-test-results from ews115 for mac-yosemite
(3.06 MB, application/zip)
2015-10-27 10:40 PDT
,
Build Bot
no flags
Details
Patch
(860.70 KB, patch)
2015-10-28 20:30 PDT
,
Darin Adler
no flags
Details
Formatted Diff
Diff
Patch
(1.89 MB, patch)
2015-10-31 15:10 PDT
,
Darin Adler
no flags
Details
Formatted Diff
Diff
Archive of layout-test-results from ews101 for mac-mavericks
(850.14 KB, application/zip)
2015-10-31 16:49 PDT
,
Build Bot
no flags
Details
Archive of layout-test-results from ews106 for mac-mavericks-wk2
(857.46 KB, application/zip)
2015-10-31 16:51 PDT
,
Build Bot
no flags
Details
Archive of layout-test-results from ews116 for mac-yosemite
(1002.37 KB, application/zip)
2015-10-31 16:51 PDT
,
Build Bot
no flags
Details
Patch
(1.92 MB, patch)
2015-10-31 19:05 PDT
,
Darin Adler
no flags
Details
Formatted Diff
Diff
Patch
(1.93 MB, patch)
2015-10-31 19:45 PDT
,
Darin Adler
no flags
Details
Formatted Diff
Diff
Patch
(1.95 MB, patch)
2015-11-01 13:00 PST
,
Darin Adler
no flags
Details
Formatted Diff
Diff
Patch
(785.40 KB, patch)
2015-11-01 14:07 PST
,
Darin Adler
no flags
Details
Formatted Diff
Diff
Patch
(1.96 MB, patch)
2015-11-01 14:09 PST
,
Darin Adler
no flags
Details
Formatted Diff
Diff
Patch
(1.96 MB, patch)
2015-11-01 14:43 PST
,
Darin Adler
no flags
Details
Formatted Diff
Diff
Patch
(1.96 MB, patch)
2015-11-01 15:01 PST
,
Darin Adler
no flags
Details
Formatted Diff
Diff
Patch
(1.89 MB, patch)
2015-11-01 17:09 PST
,
Darin Adler
no flags
Details
Formatted Diff
Diff
Patch
(1.89 MB, patch)
2015-11-01 19:12 PST
,
Darin Adler
no flags
Details
Formatted Diff
Diff
Patch
(1.89 MB, patch)
2015-11-01 21:57 PST
,
Darin Adler
no flags
Details
Formatted Diff
Diff
Patch
(1.88 MB, patch)
2015-11-01 22:13 PST
,
Darin Adler
no flags
Details
Formatted Diff
Diff
Patch
(1.88 MB, patch)
2015-11-01 23:10 PST
,
Darin Adler
no flags
Details
Formatted Diff
Diff
Patch
(1.89 MB, patch)
2015-11-02 21:16 PST
,
Darin Adler
no flags
Details
Formatted Diff
Diff
Patch
(1.89 MB, patch)
2015-11-04 09:49 PST
,
Darin Adler
no flags
Details
Formatted Diff
Diff
Patch
(1.89 MB, patch)
2015-11-06 07:43 PST
,
Darin Adler
no flags
Details
Formatted Diff
Diff
Patch
(1.89 MB, patch)
2015-11-07 16:29 PST
,
Darin Adler
no flags
Details
Formatted Diff
Diff
Patch
(1.89 MB, patch)
2015-11-07 21:25 PST
,
Darin Adler
no flags
Details
Formatted Diff
Diff
Patch
(1.61 MB, patch)
2015-11-08 10:42 PST
,
Darin Adler
no flags
Details
Formatted Diff
Diff
Patch
(1.61 MB, patch)
2015-11-08 13:01 PST
,
Darin Adler
no flags
Details
Formatted Diff
Diff
Show Obsolete
(40)
View All
Add attachment
proposed patch, testcase, etc.
Darin Adler
Comment 1
2015-10-18 15:54:28 PDT
Created
attachment 263431
[details]
Patch
Darin Adler
Comment 2
2015-10-18 16:19:58 PDT
I uploaded the large patch of my work in progress. It compiles on Mac, but probably doesn’t compile anywhere else or pass tests yet. For the most part, I want to get some feedback for some of the terminology I am using, syntax and function names. I’ll also shave off various parts of this patch and land them independently. The patch gets rid of all the use of ColorSpace alongside Color, since we plan to handle that inside the Color class itself. It also eliminates the obsolete RGBA32 class. There is also substantial reduction in the use of the concept of "device RGB", which is not really a color space concept that exists on any platform at this time. Some other small cleanup in the patch.
WebKit Commit Bot
Comment 3
2015-10-18 16:20:41 PDT
Attachment 263431
[details]
did not pass style-queue: ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:55: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:111: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:114: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:103: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/mock/ScrollbarThemeMock.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:248: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:260: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:265: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:277: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:287: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:756: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:758: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm:79: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:812: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:817: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/cg/BitmapImageCG.cpp:171: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2079: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2085: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:3255: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/NumberInputType.cpp:151: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:72: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:82: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderLayer.cpp:3702: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:438: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:443: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:449: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:455: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:460: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:53: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:77: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:83: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:89: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:95: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/Shared/mac/ArgumentCodersMac.mm:327: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/mac/ColorMac.mm:39: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/BorderValue.h:74: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/css/CSSParser.cpp:7698: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/inspector/InspectorDOMAgent.cpp:120: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:84: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:84: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/rendering/style/RenderStyle.cpp:1642: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:405: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:445: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:479: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:505: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1275: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1276: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2075: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2076: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2084: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2085: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2088: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2094: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2096: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:638: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1219: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1223: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1225: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1227: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1229: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1235: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1237: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1245: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1247: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1251: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1259: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1261: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1263: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1265: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1267: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1271: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1282: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/CollapsedBorderValue.h:56: Missing space before { [whitespace/braces] [5] Total errors found: 77 in 258 files If any of these errors are false positives, please file a bug against check-webkit-style.
Darin Adler
Comment 4
2015-10-19 22:13:29 PDT
Created
attachment 263552
[details]
Patch
WebKit Commit Bot
Comment 5
2015-10-19 22:16:37 PDT
Attachment 263552
[details]
did not pass style-queue: ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:55: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:111: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:114: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:103: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/mock/ScrollbarThemeMock.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:248: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:260: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:265: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:277: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:287: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:756: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:758: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm:79: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:812: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:817: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/cg/BitmapImageCG.cpp:171: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2079: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2085: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:3255: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:192: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:198: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:199: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/NumberInputType.cpp:151: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:72: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:82: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderLayer.cpp:3702: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:77: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:83: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:89: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:95: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:438: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:443: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:449: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:455: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:460: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:53: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/Shared/mac/ArgumentCodersMac.mm:327: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/win/PlatformCAAnimationWin.cpp:486: Missing space around : in range-based for statement [whitespace/colon] [4] ERROR: Source/WebCore/platform/graphics/mac/ColorMac.mm:39: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/BorderValue.h:74: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/css/CSSParser.cpp:7698: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/inspector/InspectorDOMAgent.cpp:120: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:84: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:84: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/rendering/style/RenderStyle.cpp:1642: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:305: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:316: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:405: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:445: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:479: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:505: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1275: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1276: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2075: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2076: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2084: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2085: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2088: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2094: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2096: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:638: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1201: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1205: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1207: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1209: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1211: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1217: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1219: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1227: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1229: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1233: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1241: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1245: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1247: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1249: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1253: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1264: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/CollapsedBorderValue.h:56: Missing space before { [whitespace/braces] [5] Total errors found: 83 in 267 files If any of these errors are false positives, please file a bug against check-webkit-style.
Darin Adler
Comment 6
2015-10-20 07:32:24 PDT
Created
attachment 263578
[details]
Patch
WebKit Commit Bot
Comment 7
2015-10-20 07:51:55 PDT
Attachment 263578
[details]
did not pass style-queue: ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:55: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:111: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:114: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:103: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/mock/ScrollbarThemeMock.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:248: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:260: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:265: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:277: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:287: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:756: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:758: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm:79: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:812: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:817: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/cg/BitmapImageCG.cpp:171: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2079: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2085: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:3255: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:192: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:198: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:199: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/NumberInputType.cpp:151: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:72: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:82: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderLayer.cpp:3699: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:77: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:83: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:89: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:95: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:438: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:443: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:449: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:455: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:460: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:53: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/Shared/mac/ArgumentCodersMac.mm:327: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/win/GraphicsContextCGWin.cpp:176: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/mac/ColorMac.mm:39: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/BorderValue.h:74: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/css/CSSParser.cpp:7698: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/inspector/InspectorDOMAgent.cpp:120: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:80: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:86: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/rendering/style/RenderStyle.cpp:1642: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:305: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:316: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:405: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:445: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:479: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:505: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1275: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1276: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2075: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2076: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2084: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2085: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2088: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2094: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2096: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:638: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1201: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1205: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1207: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1209: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1211: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1217: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1219: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1227: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1229: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1233: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1241: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1245: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1247: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1249: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1253: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1264: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/CollapsedBorderValue.h:56: Missing space before { [whitespace/braces] [5] Total errors found: 84 in 270 files If any of these errors are false positives, please file a bug against check-webkit-style.
Build Bot
Comment 8
2015-10-20 08:35:08 PDT
Comment on
attachment 263578
[details]
Patch
Attachment 263578
[details]
did not pass mac-ews (mac): Output:
http://webkit-queues.webkit.org/results/312018
Number of test failures exceeded the failure limit.
Build Bot
Comment 9
2015-10-20 08:35:11 PDT
Created
attachment 263579
[details]
Archive of layout-test-results from ews101 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-mavericks Platform: Mac OS X 10.9.5
Build Bot
Comment 10
2015-10-20 08:37:52 PDT
Comment on
attachment 263578
[details]
Patch
Attachment 263578
[details]
did not pass mac-wk2-ews (mac-wk2): Output:
http://webkit-queues.webkit.org/results/312019
Number of test failures exceeded the failure limit.
Build Bot
Comment 11
2015-10-20 08:37:56 PDT
Created
attachment 263580
[details]
Archive of layout-test-results from ews104 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Darin Adler
Comment 12
2015-10-20 09:31:54 PDT
Created
attachment 263583
[details]
Patch
WebKit Commit Bot
Comment 13
2015-10-20 09:35:52 PDT
Attachment 263583
[details]
did not pass style-queue: ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:55: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:111: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:114: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:103: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/mock/ScrollbarThemeMock.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:248: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:260: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:265: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:277: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:287: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:756: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:758: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/DateInputType.cpp:70: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm:79: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:812: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:817: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/cg/BitmapImageCG.cpp:171: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2079: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2085: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:3255: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:192: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:198: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:199: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/NumberInputType.cpp:151: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:72: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:82: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderLayer.cpp:3699: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:77: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:83: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:89: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:95: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:438: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:443: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:449: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:455: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:460: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:53: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/Shared/mac/ArgumentCodersMac.mm:327: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/win/GraphicsContextCGWin.cpp:176: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/mac/ColorMac.mm:39: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/BorderValue.h:74: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/css/CSSParser.cpp:7698: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/inspector/InspectorDOMAgent.cpp:120: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:80: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:86: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/rendering/style/RenderStyle.cpp:1642: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:305: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:316: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:405: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:445: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:479: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:505: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1275: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1276: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2075: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2076: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2084: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2085: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2088: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2094: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2096: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:638: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1201: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1205: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1207: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1209: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1211: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1217: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1219: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1227: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1229: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1233: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1241: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1245: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1247: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1249: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1253: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1264: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/CollapsedBorderValue.h:56: Missing space before { [whitespace/braces] [5] Total errors found: 85 in 272 files If any of these errors are false positives, please file a bug against check-webkit-style.
Build Bot
Comment 14
2015-10-20 10:20:20 PDT
Comment on
attachment 263583
[details]
Patch
Attachment 263583
[details]
did not pass mac-ews (mac): Output:
http://webkit-queues.webkit.org/results/312324
Number of test failures exceeded the failure limit.
Build Bot
Comment 15
2015-10-20 10:20:24 PDT
Created
attachment 263585
[details]
Archive of layout-test-results from ews103 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-mavericks Platform: Mac OS X 10.9.5
Build Bot
Comment 16
2015-10-20 10:25:11 PDT
Comment on
attachment 263583
[details]
Patch
Attachment 263583
[details]
did not pass mac-wk2-ews (mac-wk2): Output:
http://webkit-queues.webkit.org/results/312328
Number of test failures exceeded the failure limit.
Build Bot
Comment 17
2015-10-20 10:25:14 PDT
Created
attachment 263587
[details]
Archive of layout-test-results from ews104 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Build Bot
Comment 18
2015-10-20 12:24:12 PDT
Comment on
attachment 263583
[details]
Patch
Attachment 263583
[details]
did not pass mac-debug-ews (mac): Output:
http://webkit-queues.webkit.org/results/312679
Number of test failures exceeded the failure limit.
Build Bot
Comment 19
2015-10-20 12:24:16 PDT
Created
attachment 263599
[details]
Archive of layout-test-results from ews115 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-yosemite Platform: Mac OS X 10.10.5
Darin Adler
Comment 20
2015-10-25 23:18:25 PDT
Created
attachment 264038
[details]
Patch
WebKit Commit Bot
Comment 21
2015-10-25 23:21:03 PDT
Attachment 264038
[details]
did not pass style-queue: ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:55: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:111: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:114: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:103: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/mock/ScrollbarThemeMock.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:248: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:260: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:265: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:277: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:287: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:756: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:758: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm:79: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:812: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:817: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/cg/BitmapImageCG.cpp:171: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2079: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2085: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:3255: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:192: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:198: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:199: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/NumberInputType.cpp:151: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:72: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:82: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderLayer.cpp:3695: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:77: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:83: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:89: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:95: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:438: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:443: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:449: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:455: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:460: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.h:172: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:53: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/Shared/mac/ArgumentCodersMac.mm:327: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/win/GraphicsContextCGWin.cpp:176: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/mac/ColorMac.mm:39: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/BorderValue.h:74: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/css/CSSParser.cpp:7745: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/inspector/InspectorDOMAgent.cpp:120: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:80: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:86: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/rendering/style/RenderStyle.cpp:1642: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/svg/SVGAnimatedColor.cpp:102: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:305: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:316: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:405: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:445: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:479: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:505: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1275: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1276: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2075: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2076: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2084: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2085: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2088: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2094: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2096: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:638: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1201: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1205: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1207: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1209: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1211: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1217: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1219: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1227: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1229: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1233: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1241: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1245: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1247: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1249: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1253: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1264: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/CollapsedBorderValue.h:56: Missing space before { [whitespace/braces] [5] Total errors found: 86 in 287 files If any of these errors are false positives, please file a bug against check-webkit-style.
Build Bot
Comment 22
2015-10-26 00:21:09 PDT
Comment on
attachment 264038
[details]
Patch
Attachment 264038
[details]
did not pass mac-ews (mac): Output:
http://webkit-queues.webkit.org/results/338744
New failing tests: css3/selectors3/xml/css3-modsel-68.xml imported/w3c/css/css-multicol-1/multicol-rule-style-inset-001.xht imported/w3c/css/css-multicol-1/multicol-rule-style-outset-001.xht css2.1/20110323/border-conflict-element-001d.htm fast/table/paint-section-borders-without-cells-vertical-lr.html css3/selectors3/html/css3-modsel-68.html imported/w3c/css/css-multicol-1/multicol-rule-style-groove-001.xht fast/table/paint-section-borders-without-cells.html css3/selectors3/xhtml/css3-modsel-68.xml css3/selectors3/html/css3-modsel-24.html fast/forms/basic-selects.html fast/table/paint-section-borders-without-cells-rtl.html svg/hixie/perf/007.xml fast/forms/disabled-select-change-index.html fast/css-intrinsic-dimensions/height-css-tables-collapsed.html fast/forms/file/file-input-disabled.html svg/custom/mask-colorspace.svg css3/selectors3/xhtml/css3-modsel-24.xml fast/table/paint-section-borders-without-cells-vertical-rl.html editing/mac/attributed-string/anchor-element.html imported/w3c/css/css-multicol-1/multicol-rule-style-ridge-001.xht css3/selectors3/xml/css3-modsel-24.xml editing/mac/attributed-string/basic.html svg/custom/fill-opacity-hsl.svg
Build Bot
Comment 23
2015-10-26 00:21:18 PDT
Created
attachment 264039
[details]
Archive of layout-test-results from ews100 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-mavericks Platform: Mac OS X 10.9.5
Build Bot
Comment 24
2015-10-26 00:24:44 PDT
Comment on
attachment 264038
[details]
Patch
Attachment 264038
[details]
did not pass mac-wk2-ews (mac-wk2): Output:
http://webkit-queues.webkit.org/results/338750
New failing tests: css3/selectors3/xml/css3-modsel-68.xml imported/w3c/css/css-multicol-1/multicol-rule-style-inset-001.xht imported/w3c/css/css-multicol-1/multicol-rule-style-outset-001.xht css2.1/20110323/border-conflict-element-001d.htm fast/table/paint-section-borders-without-cells-vertical-lr.html css3/selectors3/html/css3-modsel-68.html imported/w3c/css/css-multicol-1/multicol-rule-style-groove-001.xht fast/table/paint-section-borders-without-cells.html css3/selectors3/xhtml/css3-modsel-68.xml css3/selectors3/html/css3-modsel-24.html fast/forms/basic-selects.html fast/table/paint-section-borders-without-cells-rtl.html svg/hixie/perf/007.xml fast/forms/disabled-select-change-index.html fast/css-intrinsic-dimensions/height-css-tables-collapsed.html fast/forms/file/file-input-disabled.html svg/custom/mask-colorspace.svg css3/selectors3/xhtml/css3-modsel-24.xml fast/table/paint-section-borders-without-cells-vertical-rl.html imported/w3c/css/css-multicol-1/multicol-rule-style-ridge-001.xht css3/selectors3/xml/css3-modsel-24.xml svg/custom/fill-opacity-hsl.svg
Build Bot
Comment 25
2015-10-26 00:24:49 PDT
Created
attachment 264040
[details]
Archive of layout-test-results from ews107 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Build Bot
Comment 26
2015-10-26 00:31:03 PDT
Comment on
attachment 264038
[details]
Patch
Attachment 264038
[details]
did not pass mac-debug-ews (mac): Output:
http://webkit-queues.webkit.org/results/338746
New failing tests: imported/w3c/css/css-multicol-1/multicol-rule-style-groove-001.xht fast/table/paint-section-borders-without-cells.html fast/css-intrinsic-dimensions/height-css-tables-collapsed.html imported/w3c/css/css-multicol-1/multicol-rule-style-ridge-001.xht imported/w3c/css/css-multicol-1/multicol-rule-style-inset-001.xht fast/table/paint-section-borders-without-cells-vertical-rl.html fast/dom/attribute-legacy-colors.html imported/w3c/css/css-multicol-1/multicol-rule-style-outset-001.xht css2.1/20110323/border-conflict-element-001d.htm fast/table/paint-section-borders-without-cells-rtl.html svg/custom/mask-colorspace.svg svg/hixie/perf/007.xml fast/table/paint-section-borders-without-cells-vertical-lr.html svg/custom/fill-opacity-hsl.svg
Build Bot
Comment 27
2015-10-26 00:31:07 PDT
Created
attachment 264041
[details]
Archive of layout-test-results from ews112 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-yosemite Platform: Mac OS X 10.10.5
Darin Adler
Comment 28
2015-10-27 09:26:44 PDT
Created
attachment 264132
[details]
Patch
WebKit Commit Bot
Comment 29
2015-10-27 09:30:35 PDT
Attachment 264132
[details]
did not pass style-queue: ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:55: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:111: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:114: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:103: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:782: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:784: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:863: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:864: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:865: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:866: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/mock/ScrollbarThemeMock.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:248: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:260: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:265: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:277: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:287: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:305: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:316: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:756: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:758: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm:79: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:812: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:817: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/WebPage/ios/FindControllerIOS.mm:56: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/cg/BitmapImageCG.cpp:171: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2067: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2073: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:3243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:192: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:198: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:199: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/NumberInputType.cpp:151: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:72: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:82: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderLayer.cpp:3695: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:77: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:83: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:89: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:95: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:438: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:443: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:449: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:455: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:460: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.h:172: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:53: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/Shared/mac/ArgumentCodersMac.mm:327: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/win/GraphicsContextCGWin.cpp:176: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/mac/ColorMac.mm:39: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/BorderValue.h:74: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/css/CSSParser.cpp:7745: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/inspector/InspectorDOMAgent.cpp:120: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:80: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:86: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/rendering/style/RenderStyle.cpp:1642: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/svg/SVGAnimatedColor.cpp:102: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:403: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:443: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:477: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:503: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1273: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1274: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2073: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2074: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2082: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2083: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2086: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2092: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2094: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:638: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1201: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1205: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1207: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1209: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1211: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1217: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1219: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1227: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1229: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1233: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1241: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1245: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1247: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1249: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1253: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1264: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/CollapsedBorderValue.h:56: Missing space before { [whitespace/braces] [5] Total errors found: 93 in 297 files If any of these errors are false positives, please file a bug against check-webkit-style.
Build Bot
Comment 30
2015-10-27 10:30:21 PDT
Comment on
attachment 264132
[details]
Patch
Attachment 264132
[details]
did not pass mac-ews (mac): Output:
http://webkit-queues.webkit.org/results/344822
New failing tests: svg/hixie/perf/007.xml accessibility/content-editable-as-textarea.html fast/forms/disabled-select-change-index.html css3/selectors3/xml/css3-modsel-68.xml fast/css/hsla-color.html css3/selectors3/xml/css3-modsel-24.xml fast/forms/file/file-input-disabled.html css3/selectors3/xhtml/css3-modsel-24.xml css3/calc/color-rgb.html css3/selectors3/html/css3-modsel-24.html svg/custom/mask-colorspace.svg css3/selectors3/xhtml/css3-modsel-68.xml fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-color.html svg/custom/fill-opacity-hsl.svg editing/mac/attributed-string/anchor-element.html fast/forms/basic-selects.html css3/calc/color-hsl.html editing/mac/attributed-string/basic.html fast/css/hsl-color.html css3/selectors3/html/css3-modsel-68.html
Build Bot
Comment 31
2015-10-27 10:30:26 PDT
Created
attachment 264136
[details]
Archive of layout-test-results from ews101 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-mavericks Platform: Mac OS X 10.9.5
Build Bot
Comment 32
2015-10-27 10:33:16 PDT
Comment on
attachment 264132
[details]
Patch
Attachment 264132
[details]
did not pass mac-wk2-ews (mac-wk2): Output:
http://webkit-queues.webkit.org/results/344823
New failing tests: svg/hixie/perf/007.xml accessibility/content-editable-as-textarea.html fast/forms/disabled-select-change-index.html css3/selectors3/xml/css3-modsel-24.xml fast/css/hsla-color.html css3/selectors3/xml/css3-modsel-68.xml fast/forms/file/file-input-disabled.html css3/selectors3/xhtml/css3-modsel-24.xml css3/calc/color-rgb.html css3/selectors3/html/css3-modsel-24.html svg/custom/mask-colorspace.svg css3/selectors3/xhtml/css3-modsel-68.xml fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-color.html fast/forms/basic-selects.html css3/calc/color-hsl.html svg/custom/fill-opacity-hsl.svg fast/css/hsl-color.html css3/selectors3/html/css3-modsel-68.html
Build Bot
Comment 33
2015-10-27 10:33:20 PDT
Created
attachment 264137
[details]
Archive of layout-test-results from ews107 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Build Bot
Comment 34
2015-10-27 10:40:17 PDT
Comment on
attachment 264132
[details]
Patch
Attachment 264132
[details]
did not pass mac-debug-ews (mac): Output:
http://webkit-queues.webkit.org/results/344819
New failing tests: svg/hixie/perf/007.xml accessibility/content-editable-as-textarea.html fast/forms/disabled-select-change-index.html css3/selectors3/xml/css3-modsel-68.xml fast/css/hsla-color.html css3/selectors3/xml/css3-modsel-24.xml fast/dom/attribute-legacy-colors.html css3/selectors3/xhtml/css3-modsel-24.xml fast/forms/file/file-input-disabled.html css3/calc/color-rgb.html css3/selectors3/html/css3-modsel-24.html svg/custom/mask-colorspace.svg css3/selectors3/xhtml/css3-modsel-68.xml fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-color.html fast/forms/basic-selects.html css3/calc/color-hsl.html svg/custom/fill-opacity-hsl.svg fast/css/hsl-color.html css3/selectors3/html/css3-modsel-68.html
Build Bot
Comment 35
2015-10-27 10:40:20 PDT
Created
attachment 264138
[details]
Archive of layout-test-results from ews115 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-yosemite Platform: Mac OS X 10.10.5
Simon Fraser (smfr)
Comment 36
2015-10-27 18:04:15 PDT
Comment on
attachment 264132
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=264132&action=review
> Source/WebCore/platform/graphics/Color.h:70 > +// To conver this into a color channel byte we multiply by 255, round and clamp into the range [0,255].
"conver"
> Source/WebCore/platform/graphics/GraphicsLayer.cpp:35 > -#include "TextStream.h" > +#include "SVGRenderTreeAsText.h"
This seems odd and is a layering violation.
> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:-1007 > -#if !PLATFORM(WIN) && !PLATFORM(IOS) > - CGColorSpaceRef colorSpace = CGImageGetColorSpace(m_pendingContentsImage.get()); > - > - static CGColorSpaceRef deviceRGB = CGColorSpaceCreateDeviceRGB(); > - if (colorSpace && CFEqual(colorSpace, deviceRGB)) { > - // CoreGraphics renders images tagged with DeviceRGB using the color space of the main display. When we hand such > - // images to CA we need to tag them similarly so CA rendering matches CG rendering. > - static CGColorSpaceRef genericRGB = CGDisplayCopyColorSpace(kCGDirectMainDisplay); > - m_pendingContentsImage = adoptCF(CGImageCreateCopyWithColorSpace(m_pendingContentsImage.get(), genericRGB)); > - } > -#endif
Not sure why this is removable?
Tim Horton
Comment 37
2015-10-27 18:16:16 PDT
(In reply to
comment #36
)
> Comment on
attachment 264132
[details]
> Patch > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=264132&action=review
> > Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:-1007 > > -#if !PLATFORM(WIN) && !PLATFORM(IOS) > > - CGColorSpaceRef colorSpace = CGImageGetColorSpace(m_pendingContentsImage.get()); > > - > > - static CGColorSpaceRef deviceRGB = CGColorSpaceCreateDeviceRGB(); > > - if (colorSpace && CFEqual(colorSpace, deviceRGB)) { > > - // CoreGraphics renders images tagged with DeviceRGB using the color space of the main display. When we hand such > > - // images to CA we need to tag them similarly so CA rendering matches CG rendering. > > - static CGColorSpaceRef genericRGB = CGDisplayCopyColorSpace(kCGDirectMainDisplay); > > - m_pendingContentsImage = adoptCF(CGImageCreateCopyWithColorSpace(m_pendingContentsImage.get(), genericRGB)); > > - } > > -#endif > > Not sure why this is removable?
IIRC (from patches I worked on that never landed), this test is no longer ever true; CGImageGetColorSpace no longer ever returns something that == DeviceRGB. Untagged images will return sRGB here (and there's another trick using ImageIO if you really want to tell if it was untagged).
Darin Adler
Comment 38
2015-10-28 08:50:22 PDT
Comment on
attachment 264132
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=264132&action=review
>> Source/WebCore/platform/graphics/GraphicsLayer.cpp:35 >> +#include "SVGRenderTreeAsText.h" > > This seems odd and is a layering violation.
I think this is no longer needed after your recent patch to improve TextStream, Simon. SVGRenderTreeAsText.h used to be the place with the << operator for RGBA. I’ll change this back before landing anything. I’ll probably just search for SVGRenderTreeAsText.h and reduce inclusion of that as much as possible.
>>> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:-1007 >>> -#endif >> >> Not sure why this is removable? > > IIRC (from patches I worked on that never landed), this test is no longer ever true; CGImageGetColorSpace no longer ever returns something that == DeviceRGB. Untagged images will return sRGB here (and there's another trick using ImageIO if you really want to tell if it was untagged).
That’s right. This is something that should be landed separately right away and doesn’t need to wait for the rest of this patch. I’ll be trying to do that, carve off pieces of it and land it, soon.
Darin Adler
Comment 39
2015-10-28 20:30:42 PDT
Created
attachment 264293
[details]
Patch
Darin Adler
Comment 40
2015-10-31 15:10:03 PDT
Created
attachment 264488
[details]
Patch
WebKit Commit Bot
Comment 41
2015-10-31 15:49:46 PDT
Attachment 264488
[details]
did not pass style-queue: ERROR: Source/WebCore/html/canvas/CanvasStyle.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:72: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:82: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2067: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2073: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:3243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:438: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:443: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:449: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:455: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:460: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm:79: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.h:172: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:77: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:83: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:89: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:95: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/win/GraphicsContextCGWin.cpp:176: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/css/CSSParser.cpp:7745: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/svg/SVGAnimatedColor.cpp:102: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:305: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:316: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:403: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:443: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:477: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:503: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1273: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1274: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2073: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2074: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2082: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2083: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2086: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2092: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2094: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:638: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1201: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1205: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1207: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1209: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1211: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1217: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1219: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1227: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1229: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1233: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1241: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1245: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1247: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1249: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1253: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1264: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:248: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:260: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:265: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:277: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:287: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:103: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:192: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:198: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:199: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/Shared/mac/ArgumentCodersMac.mm:327: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:80: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:86: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/rendering/style/RenderStyle.cpp:1642: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:812: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:817: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/WebPage/ios/FindControllerIOS.mm:56: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/cg/BitmapImageCG.cpp:171: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:756: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:758: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/mac/ColorMac.mm:39: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:782: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:784: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:863: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:864: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:865: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:866: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:55: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:111: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:114: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/mock/ScrollbarThemeMock.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:53: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/BorderValue.h:74: Missing space before { [whitespace/braces] [5] ERROR: LayoutTests/platform/mac/svg/hixie/perf/007-expected.png:0: Image lacks a checksum. Generate pngs using run-webkit-tests to ensure they have a checksum. [image/png] [5] ERROR: Source/WebCore/inspector/InspectorDOMAgent.cpp:120: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderLayer.cpp:3695: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/CollapsedBorderValue.h:56: Missing space before { [whitespace/braces] [5] Total errors found: 93 in 321 files If any of these errors are false positives, please file a bug against check-webkit-style.
Build Bot
Comment 42
2015-10-31 16:49:13 PDT
Comment on
attachment 264488
[details]
Patch
Attachment 264488
[details]
did not pass mac-ews (mac): Output:
http://webkit-queues.webkit.org/results/364671
New failing tests: css3/selectors3/xml/css3-modsel-24.xml css3/selectors3/xml/css3-modsel-68.xml css3/selectors3/xhtml/css3-modsel-24.xml css3/selectors3/xhtml/css3-modsel-68.xml css3/selectors3/html/css3-modsel-24.html editing/mac/attributed-string/anchor-element.html accessibility/content-editable-as-textarea.html editing/mac/attributed-string/basic.html css3/selectors3/html/css3-modsel-68.html
Build Bot
Comment 43
2015-10-31 16:49:17 PDT
Created
attachment 264492
[details]
Archive of layout-test-results from ews101 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-mavericks Platform: Mac OS X 10.9.5
Build Bot
Comment 44
2015-10-31 16:51:41 PDT
Comment on
attachment 264488
[details]
Patch
Attachment 264488
[details]
did not pass mac-wk2-ews (mac-wk2): Output:
http://webkit-queues.webkit.org/results/364675
New failing tests: css3/selectors3/xml/css3-modsel-24.xml css3/selectors3/xml/css3-modsel-68.xml css3/selectors3/xhtml/css3-modsel-24.xml css3/selectors3/xhtml/css3-modsel-68.xml css3/selectors3/html/css3-modsel-24.html accessibility/content-editable-as-textarea.html css3/selectors3/html/css3-modsel-68.html
Build Bot
Comment 45
2015-10-31 16:51:44 PDT
Comment on
attachment 264488
[details]
Patch
Attachment 264488
[details]
did not pass mac-debug-ews (mac): Output:
http://webkit-queues.webkit.org/results/364673
New failing tests: accessibility/content-editable-as-textarea.html fast/dom/attribute-legacy-colors.html
Build Bot
Comment 46
2015-10-31 16:51:45 PDT
Created
attachment 264493
[details]
Archive of layout-test-results from ews106 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Build Bot
Comment 47
2015-10-31 16:51:48 PDT
Created
attachment 264494
[details]
Archive of layout-test-results from ews116 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-yosemite Platform: Mac OS X 10.10.5
Darin Adler
Comment 48
2015-10-31 19:05:27 PDT
Created
attachment 264495
[details]
Patch
WebKit Commit Bot
Comment 49
2015-10-31 19:10:15 PDT
Attachment 264495
[details]
did not pass style-queue: ERROR: Source/WebCore/html/canvas/CanvasStyle.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:72: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:82: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2067: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2073: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:3243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:433: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:438: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:444: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:450: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:455: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm:79: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.h:172: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:77: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:83: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:89: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:95: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/win/GraphicsContextCGWin.cpp:176: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/css/CSSParser.cpp:7745: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/svg/SVGAnimatedColor.cpp:102: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:305: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:316: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:403: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:443: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:477: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:503: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1273: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1274: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2073: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2074: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2082: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2083: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2086: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2092: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2094: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:638: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1201: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1205: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1207: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1209: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1211: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1217: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1219: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1227: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1229: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1233: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1241: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1245: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1247: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1249: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1253: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1264: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:248: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:260: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:265: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:277: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:287: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderLayer.cpp:3695: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:103: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:192: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:198: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:199: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/Shared/mac/ArgumentCodersMac.mm:327: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:80: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:86: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/rendering/style/RenderStyle.cpp:1642: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:812: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:817: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/WebPage/ios/FindControllerIOS.mm:56: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/cg/BitmapImageCG.cpp:171: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:756: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:758: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/mac/ColorMac.mm:39: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:782: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:784: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:863: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:864: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:865: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:866: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:55: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:111: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:114: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/mock/ScrollbarThemeMock.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:53: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/BorderValue.h:74: Missing space before { [whitespace/braces] [5] ERROR: LayoutTests/platform/mac/svg/hixie/perf/007-expected.png:0: Image lacks a checksum. Generate pngs using run-webkit-tests to ensure they have a checksum. [image/png] [5] ERROR: Source/WebCore/inspector/InspectorDOMAgent.cpp:120: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/CollapsedBorderValue.h:56: Missing space before { [whitespace/braces] [5] Total errors found: 93 in 337 files If any of these errors are false positives, please file a bug against check-webkit-style.
Darin Adler
Comment 50
2015-10-31 19:45:49 PDT
Created
attachment 264497
[details]
Patch
WebKit Commit Bot
Comment 51
2015-10-31 19:49:28 PDT
Attachment 264497
[details]
did not pass style-queue: ERROR: Source/WebCore/html/canvas/CanvasStyle.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:72: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:82: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2067: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2073: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:3243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:433: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:438: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:444: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:450: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:455: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm:79: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.h:172: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:77: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:83: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:89: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:95: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/win/GraphicsContextCGWin.cpp:176: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/css/CSSParser.cpp:7745: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/svg/SVGAnimatedColor.cpp:102: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:305: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:316: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:403: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:443: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:477: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:503: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1273: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1274: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2073: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2074: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2082: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2083: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2086: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2092: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2094: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:638: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1201: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1205: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1207: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1209: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1211: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1217: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1219: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1227: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1229: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1233: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1241: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1245: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1247: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1249: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1253: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1264: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:248: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:260: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:265: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:277: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:287: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderLayer.cpp:3695: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:103: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:192: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:198: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:199: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/Shared/mac/ArgumentCodersMac.mm:327: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:80: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:86: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/rendering/style/RenderStyle.cpp:1642: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:812: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:817: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/WebPage/ios/FindControllerIOS.mm:56: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/cg/BitmapImageCG.cpp:171: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:756: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:758: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/mac/ColorMac.mm:39: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:782: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:784: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:863: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:864: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:865: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:866: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:883: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:884: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:895: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:896: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:897: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:898: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:899: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:900: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:904: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:905: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:906: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:55: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:111: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:114: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/mock/ScrollbarThemeMock.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:53: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/BorderValue.h:74: Missing space before { [whitespace/braces] [5] ERROR: LayoutTests/platform/mac/svg/hixie/perf/007-expected.png:0: Image lacks a checksum. Generate pngs using run-webkit-tests to ensure they have a checksum. [image/png] [5] ERROR: Source/WebCore/inspector/InspectorDOMAgent.cpp:120: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/CollapsedBorderValue.h:56: Missing space before { [whitespace/braces] [5] Total errors found: 104 in 341 files If any of these errors are false positives, please file a bug against check-webkit-style.
Darin Adler
Comment 52
2015-11-01 13:00:32 PST
Created
attachment 264527
[details]
Patch
WebKit Commit Bot
Comment 53
2015-11-01 13:05:13 PST
Attachment 264527
[details]
did not pass style-queue: ERROR: Source/WebCore/html/canvas/CanvasStyle.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:72: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:82: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2067: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2073: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:3243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:433: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:438: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:444: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:450: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:455: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm:79: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.h:172: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:77: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:83: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:89: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:95: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/win/GraphicsContextCGWin.cpp:176: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/css/CSSParser.cpp:7745: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/svg/SVGAnimatedColor.cpp:102: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:305: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:316: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:403: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:443: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:477: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:503: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1273: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1274: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2073: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2074: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2082: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2083: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2086: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2092: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2094: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:638: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1201: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1205: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1207: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1209: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1211: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1217: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1219: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1227: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1229: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1233: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1241: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1245: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1247: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1249: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1253: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1264: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:248: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:260: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:265: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:277: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:287: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:219: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:220: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:238: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:239: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:240: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/cairo/BitmapImageCairo.cpp:144: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderLayer.cpp:3695: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:103: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:192: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:198: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:199: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/Shared/mac/ArgumentCodersMac.mm:327: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:80: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:86: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/rendering/style/RenderStyle.cpp:1642: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:812: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:817: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/WebPage/ios/FindControllerIOS.mm:56: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/cg/BitmapImageCG.cpp:171: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:756: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:758: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/mac/ColorMac.mm:39: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:782: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:784: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:863: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:864: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:865: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:866: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:883: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:884: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:895: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:896: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:897: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:898: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:899: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:900: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:904: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:905: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:906: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:55: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:111: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:114: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/mock/ScrollbarThemeMock.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:53: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/BorderValue.h:74: Missing space before { [whitespace/braces] [5] ERROR: LayoutTests/platform/mac/svg/hixie/perf/007-expected.png:0: Image lacks a checksum. Generate pngs using run-webkit-tests to ensure they have a checksum. [image/png] [5] ERROR: Source/WebCore/inspector/InspectorDOMAgent.cpp:120: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/CollapsedBorderValue.h:56: Missing space before { [whitespace/braces] [5] Total errors found: 110 in 347 files If any of these errors are false positives, please file a bug against check-webkit-style.
Darin Adler
Comment 54
2015-11-01 14:07:10 PST
Created
attachment 264528
[details]
Patch
Darin Adler
Comment 55
2015-11-01 14:09:30 PST
Created
attachment 264529
[details]
Patch
WebKit Commit Bot
Comment 56
2015-11-01 14:13:42 PST
Attachment 264529
[details]
did not pass style-queue: ERROR: Source/WebCore/html/canvas/CanvasStyle.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:72: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:82: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2067: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2073: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:3243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:433: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:438: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:444: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:450: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:455: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm:79: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.h:172: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:77: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:83: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:89: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:95: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/win/GraphicsContextCGWin.cpp:176: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/css/CSSParser.cpp:7745: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/svg/SVGAnimatedColor.cpp:102: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:305: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:316: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:403: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:443: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:477: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:503: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1273: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1274: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2073: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2074: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2082: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2083: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2086: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2092: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2094: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:638: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1201: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1205: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1207: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1209: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1211: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1217: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1219: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1227: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1229: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1233: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1241: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1245: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1247: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1249: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1253: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1264: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:248: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:260: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:265: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:277: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:287: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:219: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:220: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:238: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:239: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:240: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/cairo/BitmapImageCairo.cpp:144: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderLayer.cpp:3695: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:103: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:192: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:198: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:199: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/Shared/mac/ArgumentCodersMac.mm:327: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:80: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:86: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/rendering/style/RenderStyle.cpp:1642: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:812: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:817: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/WebPage/ios/FindControllerIOS.mm:56: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/cg/BitmapImageCG.cpp:171: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:756: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:758: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/mac/ColorMac.mm:39: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:782: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:784: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:863: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:864: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:865: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:866: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:883: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:884: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:895: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:896: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:897: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:898: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:899: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:900: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:904: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:905: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:906: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:55: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:111: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:114: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/mock/ScrollbarThemeMock.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/mac/WebView/WebIndicateLayer.mm:52: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:53: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/BorderValue.h:74: Missing space before { [whitespace/braces] [5] ERROR: LayoutTests/platform/mac/svg/hixie/perf/007-expected.png:0: Image lacks a checksum. Generate pngs using run-webkit-tests to ensure they have a checksum. [image/png] [5] ERROR: Source/WebCore/inspector/InspectorDOMAgent.cpp:120: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/CollapsedBorderValue.h:56: Missing space before { [whitespace/braces] [5] Total errors found: 111 in 349 files If any of these errors are false positives, please file a bug against check-webkit-style.
Darin Adler
Comment 57
2015-11-01 14:43:35 PST
Created
attachment 264533
[details]
Patch
WebKit Commit Bot
Comment 58
2015-11-01 14:47:58 PST
Attachment 264533
[details]
did not pass style-queue: ERROR: Source/WebCore/html/canvas/CanvasStyle.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:72: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:82: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2067: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2073: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:3243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:433: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:438: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:444: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:450: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:455: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm:79: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.h:172: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:77: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:83: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:89: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:95: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/win/GraphicsContextCGWin.cpp:176: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/css/CSSParser.cpp:7745: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/svg/SVGAnimatedColor.cpp:102: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:305: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:316: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:403: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:443: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:477: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:503: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1273: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1274: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2073: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2074: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2082: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2083: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2086: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2092: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2094: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:638: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1201: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1205: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1207: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1209: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1211: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1217: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1219: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1227: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1229: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1233: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1241: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1245: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1247: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1249: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1253: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1264: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:248: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:260: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:265: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:277: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:287: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:219: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:220: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:238: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:239: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:240: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/cairo/BitmapImageCairo.cpp:144: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderLayer.cpp:3695: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:103: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:192: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:198: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:199: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/Shared/mac/ArgumentCodersMac.mm:327: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:80: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:86: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/rendering/style/RenderStyle.cpp:1642: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:812: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:817: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/WebPage/ios/FindControllerIOS.mm:56: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/cg/BitmapImageCG.cpp:171: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:756: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:758: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/mac/ColorMac.mm:39: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:782: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:784: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:863: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:864: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:865: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:866: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:883: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:884: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:895: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:896: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:897: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:898: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:899: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:900: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:904: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:905: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:906: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:55: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:111: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:114: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/mock/ScrollbarThemeMock.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/mac/WebView/WebIndicateLayer.mm:52: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:53: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/BorderValue.h:74: Missing space before { [whitespace/braces] [5] ERROR: LayoutTests/platform/mac/svg/hixie/perf/007-expected.png:0: Image lacks a checksum. Generate pngs using run-webkit-tests to ensure they have a checksum. [image/png] [5] ERROR: Source/WebCore/inspector/InspectorDOMAgent.cpp:120: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/CollapsedBorderValue.h:56: Missing space before { [whitespace/braces] [5] Total errors found: 111 in 349 files If any of these errors are false positives, please file a bug against check-webkit-style.
Darin Adler
Comment 59
2015-11-01 15:01:56 PST
Created
attachment 264539
[details]
Patch
WebKit Commit Bot
Comment 60
2015-11-01 15:17:19 PST
Attachment 264539
[details]
did not pass style-queue: ERROR: Source/WebCore/html/canvas/CanvasStyle.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:72: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:82: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2067: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2073: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:3243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:433: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:438: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:444: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:450: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:455: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm:79: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.h:172: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:77: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:83: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:89: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:95: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/win/GraphicsContextCGWin.cpp:176: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/css/CSSParser.cpp:7745: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/svg/SVGAnimatedColor.cpp:102: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:305: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:316: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:403: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:443: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:477: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:503: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1273: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1274: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2073: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2074: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2082: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2083: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2086: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2092: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2094: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:638: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1201: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1205: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1207: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1209: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1211: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1217: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1219: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1227: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1229: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1233: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1241: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1245: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1247: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1249: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1253: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1264: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:248: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:260: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:265: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:277: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:287: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:219: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:220: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:238: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:239: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:240: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/cairo/BitmapImageCairo.cpp:144: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderLayer.cpp:3695: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:103: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:192: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:198: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:199: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/Shared/mac/ArgumentCodersMac.mm:327: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:80: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:86: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/rendering/style/RenderStyle.cpp:1642: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:812: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:817: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/WebPage/ios/FindControllerIOS.mm:56: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/cg/BitmapImageCG.cpp:171: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:756: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:758: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/mac/ColorMac.mm:39: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:782: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:784: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:863: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:864: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:865: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:866: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:883: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:884: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:895: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:896: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:897: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:898: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:899: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:900: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:904: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:905: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:906: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:55: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:111: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:114: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/mock/ScrollbarThemeMock.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/mac/WebView/WebIndicateLayer.mm:52: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:53: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/BorderValue.h:74: Missing space before { [whitespace/braces] [5] ERROR: LayoutTests/platform/mac/svg/hixie/perf/007-expected.png:0: Image lacks a checksum. Generate pngs using run-webkit-tests to ensure they have a checksum. [image/png] [5] ERROR: Source/WebCore/inspector/InspectorDOMAgent.cpp:120: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/CollapsedBorderValue.h:56: Missing space before { [whitespace/braces] [5] Total errors found: 111 in 349 files If any of these errors are false positives, please file a bug against check-webkit-style.
Darin Adler
Comment 61
2015-11-01 17:09:13 PST
Created
attachment 264545
[details]
Patch
WebKit Commit Bot
Comment 62
2015-11-01 17:17:02 PST
Attachment 264545
[details]
did not pass style-queue: ERROR: Source/WebCore/html/canvas/CanvasStyle.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:72: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:82: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2067: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2073: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:3243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:433: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:438: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:444: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:450: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:455: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm:79: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.h:172: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:77: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:83: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:89: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:95: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/win/GraphicsContextCGWin.cpp:176: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/css/CSSParser.cpp:7745: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/svg/SVGAnimatedColor.cpp:102: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:305: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:316: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:403: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:443: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:477: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:503: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1273: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1274: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2073: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2074: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2082: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2083: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2086: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2092: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2094: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:638: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1201: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1205: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1207: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1209: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1211: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1217: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1219: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1227: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1229: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1233: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1241: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1245: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1247: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1249: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1253: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1264: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:248: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:260: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:265: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:277: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:287: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:219: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:220: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:238: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:239: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:240: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/cairo/BitmapImageCairo.cpp:144: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderLayer.cpp:3695: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:103: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:192: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:198: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:199: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/Shared/mac/ArgumentCodersMac.mm:327: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:80: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:86: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/rendering/style/RenderStyle.cpp:1642: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:812: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:817: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/WebPage/ios/FindControllerIOS.mm:56: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/cg/BitmapImageCG.cpp:171: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:756: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:758: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:2401: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/mac/ColorMac.mm:39: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:782: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:784: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:863: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:864: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:865: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:866: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:883: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:884: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:895: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:896: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:897: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:898: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:899: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:900: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:904: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:905: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:906: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:55: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:111: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:114: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/mock/ScrollbarThemeMock.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/mac/WebView/WebIndicateLayer.mm:52: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:53: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/BorderValue.h:74: Missing space before { [whitespace/braces] [5] ERROR: LayoutTests/platform/mac/svg/hixie/perf/007-expected.png:0: Image lacks a checksum. Generate pngs using run-webkit-tests to ensure they have a checksum. [image/png] [5] ERROR: Source/WebCore/inspector/InspectorDOMAgent.cpp:120: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/CollapsedBorderValue.h:56: Missing space before { [whitespace/braces] [5] Total errors found: 112 in 349 files If any of these errors are false positives, please file a bug against check-webkit-style.
Darin Adler
Comment 63
2015-11-01 19:12:49 PST
Created
attachment 264551
[details]
Patch
WebKit Commit Bot
Comment 64
2015-11-01 19:39:57 PST
Attachment 264551
[details]
did not pass style-queue: ERROR: Source/WebCore/html/canvas/CanvasStyle.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:72: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:82: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2067: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2073: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:3243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:433: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:438: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:444: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:450: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:455: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm:79: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.h:172: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:77: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:83: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:89: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:95: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/win/GraphicsContextCGWin.cpp:176: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/css/CSSParser.cpp:7745: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/svg/SVGAnimatedColor.cpp:102: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:305: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:316: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:403: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:443: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:477: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:503: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1273: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1274: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2073: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2074: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2082: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2083: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2086: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2092: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2094: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:638: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1201: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1205: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1207: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1209: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1211: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1217: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1219: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1227: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1229: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1233: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1241: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1245: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1247: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1249: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1253: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1264: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:248: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:260: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:265: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:277: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:287: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:219: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:220: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:238: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:239: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:240: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/cairo/BitmapImageCairo.cpp:144: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderLayer.cpp:3695: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:103: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:192: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:198: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:199: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/Shared/mac/ArgumentCodersMac.mm:327: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:80: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:86: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/rendering/style/RenderStyle.cpp:1642: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:812: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:817: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/WebPage/ios/FindControllerIOS.mm:56: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/cg/BitmapImageCG.cpp:171: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:756: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:758: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:2401: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/mac/ColorMac.mm:39: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:782: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:784: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:863: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:864: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:865: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:866: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:883: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:884: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:895: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:896: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:897: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:898: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:899: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:900: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:904: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:905: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:906: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:55: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:111: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:114: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/mock/ScrollbarThemeMock.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/mac/WebView/WebIndicateLayer.mm:52: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:53: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/BorderValue.h:74: Missing space before { [whitespace/braces] [5] ERROR: LayoutTests/platform/mac/svg/hixie/perf/007-expected.png:0: Image lacks a checksum. Generate pngs using run-webkit-tests to ensure they have a checksum. [image/png] [5] ERROR: Source/WebCore/inspector/InspectorDOMAgent.cpp:120: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/CollapsedBorderValue.h:56: Missing space before { [whitespace/braces] [5] Total errors found: 112 in 348 files If any of these errors are false positives, please file a bug against check-webkit-style.
Darin Adler
Comment 65
2015-11-01 21:57:35 PST
Created
attachment 264553
[details]
Patch
Darin Adler
Comment 66
2015-11-01 22:13:29 PST
Created
attachment 264555
[details]
Patch
WebKit Commit Bot
Comment 67
2015-11-01 22:17:40 PST
Attachment 264555
[details]
did not pass style-queue: ERROR: Source/WebCore/html/canvas/CanvasStyle.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:72: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:82: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2067: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2073: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:3243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:433: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:438: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:444: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:450: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:455: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm:79: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.h:172: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:77: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:83: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:89: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:95: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/win/GraphicsContextCGWin.cpp:176: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/css/CSSParser.cpp:7745: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/svg/SVGAnimatedColor.cpp:102: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:305: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:316: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:403: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:443: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:477: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:503: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1273: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1274: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2073: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2074: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2082: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2083: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2086: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2092: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2094: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:638: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1201: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1205: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1207: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1209: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1211: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1217: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1219: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1227: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1229: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1233: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1241: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1245: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1247: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1249: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1253: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1264: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:248: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:260: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:265: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:277: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:287: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:219: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:220: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:238: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:239: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:240: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/cairo/BitmapImageCairo.cpp:144: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderLayer.cpp:3695: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:103: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:192: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:198: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:199: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/Shared/mac/ArgumentCodersMac.mm:327: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:80: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:86: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/rendering/style/RenderStyle.cpp:1642: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:812: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:817: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/WebPage/ios/FindControllerIOS.mm:56: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/cg/BitmapImageCG.cpp:171: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:756: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:758: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:2401: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/mac/ColorMac.mm:39: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:782: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:784: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:863: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:864: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:865: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:866: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:883: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:884: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:895: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:896: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:897: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:898: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:899: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:900: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:904: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:905: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:906: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:55: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:111: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:114: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/mock/ScrollbarThemeMock.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/mac/WebView/WebIndicateLayer.mm:52: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:53: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/BorderValue.h:74: Missing space before { [whitespace/braces] [5] ERROR: LayoutTests/platform/mac/svg/hixie/perf/007-expected.png:0: Image lacks a checksum. Generate pngs using run-webkit-tests to ensure they have a checksum. [image/png] [5] ERROR: Source/WebCore/inspector/InspectorDOMAgent.cpp:120: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/CollapsedBorderValue.h:56: Missing space before { [whitespace/braces] [5] Total errors found: 112 in 345 files If any of these errors are false positives, please file a bug against check-webkit-style.
Darin Adler
Comment 68
2015-11-01 23:10:53 PST
Created
attachment 264558
[details]
Patch
WebKit Commit Bot
Comment 69
2015-11-01 23:15:26 PST
Attachment 264558
[details]
did not pass style-queue: ERROR: Source/WebCore/html/canvas/CanvasStyle.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:72: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:82: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2067: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2073: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:3243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:433: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:438: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:444: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:450: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:455: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm:79: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.h:172: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:77: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:83: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:89: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:95: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/win/GraphicsContextCGWin.cpp:176: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/css/CSSParser.cpp:7745: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/svg/SVGAnimatedColor.cpp:102: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:305: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:316: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:403: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:443: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:477: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:503: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1273: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1274: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2073: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2074: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2082: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2083: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2086: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2092: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2094: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:638: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1201: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1205: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1207: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1209: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1211: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1217: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1219: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1227: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1229: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1233: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1241: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1245: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1247: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1249: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1253: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1264: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:248: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:260: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:265: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:277: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:287: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:219: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:220: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:238: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:239: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:240: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/cairo/BitmapImageCairo.cpp:144: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderLayer.cpp:3695: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:103: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:192: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:198: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:199: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/Shared/mac/ArgumentCodersMac.mm:327: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:80: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:86: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/rendering/style/RenderStyle.cpp:1642: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:812: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:817: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/WebPage/ios/FindControllerIOS.mm:56: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/cg/BitmapImageCG.cpp:171: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:756: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:758: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:2401: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/mac/ColorMac.mm:39: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:782: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:784: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:863: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:864: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:865: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:866: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:883: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:884: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:895: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:896: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:897: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:898: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:899: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:900: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:904: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:905: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:906: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:55: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:111: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:114: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/mock/ScrollbarThemeMock.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/mac/WebView/WebIndicateLayer.mm:52: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:53: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/BorderValue.h:74: Missing space before { [whitespace/braces] [5] ERROR: LayoutTests/platform/mac/svg/hixie/perf/007-expected.png:0: Image lacks a checksum. Generate pngs using run-webkit-tests to ensure they have a checksum. [image/png] [5] ERROR: Source/WebCore/inspector/InspectorDOMAgent.cpp:120: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/CollapsedBorderValue.h:56: Missing space before { [whitespace/braces] [5] Total errors found: 112 in 344 files If any of these errors are false positives, please file a bug against check-webkit-style.
Darin Adler
Comment 70
2015-11-02 21:16:02 PST
Created
attachment 264662
[details]
Patch
WebKit Commit Bot
Comment 71
2015-11-02 21:38:30 PST
Attachment 264662
[details]
did not pass style-queue: ERROR: Source/WebCore/html/canvas/CanvasStyle.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:72: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:82: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2067: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2073: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:3243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:433: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:438: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:444: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:450: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:455: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm:79: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.h:172: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:77: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:83: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:89: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:95: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/win/GraphicsContextCGWin.cpp:176: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/css/CSSParser.cpp:7744: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/svg/SVGAnimatedColor.cpp:102: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:305: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:316: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:403: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:443: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:477: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:503: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1273: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1274: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2073: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2074: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2082: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2083: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2086: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2092: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2094: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:638: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1201: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1205: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1207: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1209: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1211: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1217: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1219: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1227: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1229: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1233: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1241: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1245: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1247: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1249: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1253: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1264: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:248: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:260: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:265: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:277: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:287: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:219: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:220: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:238: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:239: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:240: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/cairo/BitmapImageCairo.cpp:144: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderLayer.cpp:3695: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:103: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:192: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:198: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:199: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeEfl.cpp:437: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeEfl.cpp:629: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeEfl.cpp:630: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeEfl.cpp:631: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/Shared/mac/ArgumentCodersMac.mm:327: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:80: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:86: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/rendering/style/RenderStyle.cpp:1642: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/FrameView.cpp:418: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/dom/Document.cpp:812: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:817: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/WebPage/ios/FindControllerIOS.mm:56: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/cg/BitmapImageCG.cpp:171: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:756: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:758: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:2401: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/mac/ColorMac.mm:39: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:775: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:777: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:856: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:857: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:858: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:859: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:876: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:877: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:888: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:889: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:890: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:891: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:892: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:893: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:897: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:898: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:899: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/gtk/ColorGtk.cpp:29: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:55: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:111: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:114: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/mock/ScrollbarThemeMock.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/mac/WebView/WebIndicateLayer.mm:52: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:53: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/BorderValue.h:74: Missing space before { [whitespace/braces] [5] ERROR: LayoutTests/platform/mac/svg/hixie/perf/007-expected.png:0: Image lacks a checksum. Generate pngs using run-webkit-tests to ensure they have a checksum. [image/png] [5] ERROR: Source/WebCore/inspector/InspectorDOMAgent.cpp:120: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/CollapsedBorderValue.h:56: Missing space before { [whitespace/braces] [5] Total errors found: 118 in 345 files If any of these errors are false positives, please file a bug against check-webkit-style.
Darin Adler
Comment 72
2015-11-04 09:49:16 PST
Created
attachment 264795
[details]
Patch
Simon Fraser (smfr)
Comment 73
2015-11-05 21:27:33 PST
I'm going to take on the part of removing all the ColorSpace arguments (possibly stuplidly).
Darin Adler
Comment 74
2015-11-06 07:43:32 PST
Created
attachment 264938
[details]
Patch
WebKit Commit Bot
Comment 75
2015-11-06 08:28:05 PST
Attachment 264938
[details]
did not pass style-queue: ERROR: Source/WebCore/html/canvas/CanvasStyle.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:72: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:82: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2067: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2073: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:3243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:433: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:438: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:444: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:450: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:455: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm:79: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.h:172: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:77: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:83: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:89: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:95: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/win/GraphicsContextCGWin.cpp:176: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/css/CSSParser.cpp:7744: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/svg/SVGAnimatedColor.cpp:102: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:305: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:316: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:403: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:443: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:477: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:503: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1273: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1274: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2077: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2078: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2086: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2087: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2090: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2096: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2098: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:638: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1201: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1205: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1207: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1209: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1211: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1217: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1219: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1227: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1229: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1233: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1241: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1245: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1247: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1249: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1253: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1264: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:263: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:275: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:280: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:292: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:302: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:169: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:170: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:171: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:173: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:174: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:177: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:178: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/cairo/BitmapImageCairo.cpp:144: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderLayer.cpp:3695: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:103: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:192: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:198: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:199: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeEfl.cpp:437: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeEfl.cpp:629: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeEfl.cpp:630: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeEfl.cpp:631: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/Shared/mac/ArgumentCodersMac.mm:327: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:80: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:86: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/rendering/style/RenderStyle.cpp:1642: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/FrameView.cpp:418: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/dom/Document.cpp:812: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:817: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/WebPage/ios/FindControllerIOS.mm:56: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/cg/BitmapImageCG.cpp:171: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:756: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:758: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:2402: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/mac/ColorMac.mm:39: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:775: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:777: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:856: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:857: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:858: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:859: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:876: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:877: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:888: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:889: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:890: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:891: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:892: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:893: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:897: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:898: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:899: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/gtk/ColorGtk.cpp:29: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:55: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:111: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:114: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/mock/ScrollbarThemeMock.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/mac/WebView/WebIndicateLayer.mm:52: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:53: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/BorderValue.h:74: Missing space before { [whitespace/braces] [5] ERROR: LayoutTests/platform/mac/svg/hixie/perf/007-expected.png:0: Image lacks a checksum. Generate pngs using run-webkit-tests to ensure they have a checksum. [image/png] [5] ERROR: Source/WebCore/inspector/InspectorDOMAgent.cpp:120: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/CollapsedBorderValue.h:56: Missing space before { [whitespace/braces] [5] Total errors found: 120 in 345 files If any of these errors are false positives, please file a bug against check-webkit-style.
Darin Adler
Comment 76
2015-11-07 16:29:33 PST
Created
attachment 265008
[details]
Patch
WebKit Commit Bot
Comment 77
2015-11-07 16:46:36 PST
Attachment 265008
[details]
did not pass style-queue: ERROR: Source/WebCore/html/canvas/CanvasStyle.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:72: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:82: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2067: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2073: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:3243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:433: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:438: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:444: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:450: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:455: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm:79: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.h:172: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:77: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:83: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:89: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:95: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/win/GraphicsContextCGWin.cpp:176: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/css/CSSParser.cpp:7744: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/svg/SVGAnimatedColor.cpp:102: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:305: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:316: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:403: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:443: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:477: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:503: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1273: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1274: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2077: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2078: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2086: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2087: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2090: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2096: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2098: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:638: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1201: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1205: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1207: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1209: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1211: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1217: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1219: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1227: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1229: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1233: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1241: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1245: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1247: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1249: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1253: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1264: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:263: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:275: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:280: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:292: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:302: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:169: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:170: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:171: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:173: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:174: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:177: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:178: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/cairo/BitmapImageCairo.cpp:144: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderLayer.cpp:3695: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:103: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:192: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:198: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:199: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeEfl.cpp:437: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeEfl.cpp:629: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeEfl.cpp:630: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeEfl.cpp:631: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/Shared/mac/ArgumentCodersMac.mm:327: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:80: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:86: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/rendering/style/RenderStyle.cpp:1642: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/FrameView.cpp:418: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/dom/Document.cpp:812: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:817: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/WebPage/ios/FindControllerIOS.mm:56: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/cg/BitmapImageCG.cpp:171: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:756: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:758: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:2402: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/mac/ColorMac.mm:39: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:775: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:777: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:856: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:857: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:858: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:859: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:876: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:877: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:888: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:889: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:890: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:891: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:892: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:893: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:897: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:898: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:899: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/gtk/ColorGtk.cpp:29: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:55: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:111: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:114: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/mock/ScrollbarThemeMock.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/mac/WebView/WebIndicateLayer.mm:52: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:53: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/BorderValue.h:74: Missing space before { [whitespace/braces] [5] ERROR: LayoutTests/platform/mac/svg/hixie/perf/007-expected.png:0: Image lacks a checksum. Generate pngs using run-webkit-tests to ensure they have a checksum. [image/png] [5] ERROR: Source/WebCore/inspector/InspectorDOMAgent.cpp:120: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/gtk/InputMethodFilter.cpp:157: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/gtk/InputMethodFilter.cpp:265: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/CollapsedBorderValue.h:56: Missing space before { [whitespace/braces] [5] Total errors found: 122 in 347 files If any of these errors are false positives, please file a bug against check-webkit-style.
Darin Adler
Comment 78
2015-11-07 21:25:17 PST
Created
attachment 265010
[details]
Patch
WebKit Commit Bot
Comment 79
2015-11-07 22:12:00 PST
Attachment 265010
[details]
did not pass style-queue: ERROR: Source/WebCore/html/canvas/CanvasStyle.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:72: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:82: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2067: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2073: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:3243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:433: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:438: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:444: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:450: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:455: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm:79: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.h:172: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:77: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:83: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:89: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:95: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/win/GraphicsContextCGWin.cpp:176: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/css/CSSParser.cpp:7744: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/svg/SVGAnimatedColor.cpp:102: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:305: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:316: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:403: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:443: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:477: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:503: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1273: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1274: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2077: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2078: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2086: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2087: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2090: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2096: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2098: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:638: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1201: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1205: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1207: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1209: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1211: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1217: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1219: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1227: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1229: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1233: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1241: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1245: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1247: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1249: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1253: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1264: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:263: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:275: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:280: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:292: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:302: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:169: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:170: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:171: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:173: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:174: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:177: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:178: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/cairo/BitmapImageCairo.cpp:144: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderLayer.cpp:3695: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:103: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:192: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:198: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:199: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeEfl.cpp:437: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeEfl.cpp:629: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeEfl.cpp:630: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeEfl.cpp:631: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/Shared/mac/ArgumentCodersMac.mm:327: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:80: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:86: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/rendering/style/RenderStyle.cpp:1642: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/FrameView.cpp:418: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/dom/Document.cpp:812: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:817: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/WebPage/ios/FindControllerIOS.mm:56: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/cg/BitmapImageCG.cpp:171: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/efl/ewk_color_picker.cpp:56: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:756: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:758: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:2402: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/mac/ColorMac.mm:39: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:775: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:777: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:856: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:857: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:858: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:859: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:876: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:877: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:888: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:889: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:890: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:891: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:892: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:893: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:897: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:898: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:899: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/gtk/ColorGtk.cpp:29: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:55: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:111: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:114: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/mock/ScrollbarThemeMock.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/mac/WebView/WebIndicateLayer.mm:52: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:53: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/BorderValue.h:74: Missing space before { [whitespace/braces] [5] ERROR: LayoutTests/platform/mac/svg/hixie/perf/007-expected.png:0: Image lacks a checksum. Generate pngs using run-webkit-tests to ensure they have a checksum. [image/png] [5] ERROR: Source/WebCore/inspector/InspectorDOMAgent.cpp:120: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/gtk/InputMethodFilter.cpp:157: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/gtk/InputMethodFilter.cpp:265: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/CollapsedBorderValue.h:56: Missing space before { [whitespace/braces] [5] Total errors found: 123 in 348 files If any of these errors are false positives, please file a bug against check-webkit-style.
Darin Adler
Comment 80
2015-11-08 10:42:39 PST
Created
attachment 265019
[details]
Patch
WebKit Commit Bot
Comment 81
2015-11-08 10:58:15 PST
Attachment 265019
[details]
did not pass style-queue: ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:55: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:111: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp:114: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/DebugPageOverlays.cpp:84: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/DebugPageOverlays.cpp:123: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/ios/LegacyTileCache.mm:478: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/ios/LegacyTileCache.mm:480: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/FrameView.cpp:418: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:316: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:395: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:400: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:666: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:685: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:686: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:775: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:777: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:856: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:857: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:858: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:859: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:876: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:877: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:888: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:889: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:890: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:891: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:892: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:893: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:897: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:898: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeIOS.mm:899: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/mock/ScrollbarThemeMock.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:264: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:276: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:281: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:293: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/Color.cpp:304: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:305: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeWin.cpp:316: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:169: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:170: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:171: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:173: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:174: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:177: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:178: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/cairo/BitmapImageCairo.cpp:144: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.cpp:105: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm:79: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:812: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/dom/Document.cpp:817: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/WebPage/ios/FindControllerIOS.mm:56: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/cg/BitmapImageCG.cpp:171: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorClient.cpp:150: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:103: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2066: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2072: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:3242: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:192: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:198: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/win/DragImageWin.cpp:199: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeEfl.cpp:437: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeEfl.cpp:629: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeEfl.cpp:630: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeEfl.cpp:631: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:72: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderFrameSet.cpp:82: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/efl/ewk_color_picker.cpp:56: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:756: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:758: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:433: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:438: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:444: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:450: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:455: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.h:172: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:47: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/StepRange.cpp:53: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:77: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:83: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:89: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderEmbeddedObject.cpp:95: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/Shared/mac/ArgumentCodersMac.mm:327: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/win/GraphicsContextCGWin.cpp:176: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/mac/ColorMac.mm:39: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/BorderValue.h:74: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/css/CSSParser.cpp:7744: Missing space before { [whitespace/braces] [5] ERROR: LayoutTests/platform/mac/svg/hixie/perf/007-expected.png:0: Image lacks a checksum. Generate pngs using run-webkit-tests to ensure they have a checksum. [image/png] [5] ERROR: Source/WebCore/inspector/InspectorDOMAgent.cpp:120: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/gtk/ColorGtk.cpp:29: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:80: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:85: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/html/canvas/CanvasStyle.h:86: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/rendering/style/RenderStyle.cpp:1642: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/svg/SVGAnimatedColor.cpp:102: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderLayer.cpp:1824: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderLayer.cpp:3695: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:2402: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/mac/WebView/WebIndicateLayer.mm:52: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:403: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:443: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:477: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:503: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1273: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:1274: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2080: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2081: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2089: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2090: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2093: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2099: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderThemeMac.mm:2101: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/gtk/InputMethodFilter.cpp:157: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/gtk/InputMethodFilter.cpp:265: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:638: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1201: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1205: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1207: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1209: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1211: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1217: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1219: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1227: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1229: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1233: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1241: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1243: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1245: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1247: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1249: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1253: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/RenderTheme.cpp:1264: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/rendering/style/CollapsedBorderValue.h:56: Missing space before { [whitespace/braces] [5] Total errors found: 135 in 240 files If any of these errors are false positives, please file a bug against check-webkit-style.
Darin Adler
Comment 82
2015-11-08 13:01:11 PST
Created
attachment 265022
[details]
Patch
Darin Adler
Comment 83
2016-11-11 08:51:20 PST
Dean is doing a lot of work in this area, moving the Color class forward; I am going to abandon this particular patch and this particular specific direction.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug