Add missing #if ENABLE(CONTENT_EXTENSIONS) for successful builds with CONTENT_EXTENSIONS=OFF.
Created attachment 263420 [details] Patch
Created attachment 263421 [details] Patch
Comment on attachment 263421 [details] Patch Clearing flags on attachment: 263421 Committed r191266: <http://trac.webkit.org/changeset/191266>
All reviewed patches have been landed. Closing bug.
(In reply to comment #3) > Comment on attachment 263421 [details] > Patch > > Clearing flags on attachment: 263421 > > Committed r191266: <http://trac.webkit.org/changeset/191266> Why did you need this change? ContentExtensionActions.h is properly guarded with ENABLE(CONTENT_EXTENSIONS. https://trac.webkit.org/browser/trunk/Source/WebCore/contentextensions/ContentExtensionActions.h It's not common to use guards for include statements.
> Why did you need this change? ContentExtensionActions.h > is properly guarded with ENABLE(CONTENT_EXTENSIONS. Because I got errors "cannot include ContentExtensionActions.h" while building on Visual Studio with ENABLE_CONTENT_EXTENSION=OFF (this is the default value in the AppleWin target). Honestly, I don't know exactly why the errors occur. I just simply followed other cases like ContentExtensionRule.h. But today I realized through webkit.org/b/150300 that our Visual Studio projects are not being managed well, so I think the root cause of the problem might be elsewhere. > It's not common to use guards for include statements. I agree with your point, but I can find so many cases like this in our codebase. How do I understand this?