Bug 150302 - Add missing #if ENABLE(CONTENT_EXTENSIONS) for successful builds with ENABLE_CONTENT_EXTENSIONS=OFF
Summary: Add missing #if ENABLE(CONTENT_EXTENSIONS) for successful builds with ENABLE_...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sungmann Cho
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-18 07:05 PDT by Sungmann Cho
Modified: 2015-10-19 06:34 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.74 KB, patch)
2015-10-18 07:09 PDT, Sungmann Cho
no flags Details | Formatted Diff | Diff
Patch (1.42 KB, patch)
2015-10-18 07:58 PDT, Sungmann Cho
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sungmann Cho 2015-10-18 07:05:46 PDT
Add missing #if ENABLE(CONTENT_EXTENSIONS) for successful builds with CONTENT_EXTENSIONS=OFF.
Comment 1 Sungmann Cho 2015-10-18 07:09:28 PDT
Created attachment 263420 [details]
Patch
Comment 2 Sungmann Cho 2015-10-18 07:58:32 PDT
Created attachment 263421 [details]
Patch
Comment 3 WebKit Commit Bot 2015-10-18 16:37:20 PDT
Comment on attachment 263421 [details]
Patch

Clearing flags on attachment: 263421

Committed r191266: <http://trac.webkit.org/changeset/191266>
Comment 4 WebKit Commit Bot 2015-10-18 16:37:24 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Csaba Osztrogonác 2015-10-19 00:49:11 PDT
(In reply to comment #3)
> Comment on attachment 263421 [details]
> Patch
> 
> Clearing flags on attachment: 263421
> 
> Committed r191266: <http://trac.webkit.org/changeset/191266>

Why did you need this change? ContentExtensionActions.h 
is properly guarded with ENABLE(CONTENT_EXTENSIONS.

https://trac.webkit.org/browser/trunk/Source/WebCore/contentextensions/ContentExtensionActions.h 

It's not common to use guards for include statements.
Comment 6 Sungmann Cho 2015-10-19 06:34:30 PDT
> Why did you need this change? ContentExtensionActions.h 
> is properly guarded with ENABLE(CONTENT_EXTENSIONS.

Because I got errors "cannot include ContentExtensionActions.h"
while building on Visual Studio with ENABLE_CONTENT_EXTENSION=OFF
(this is the default value in the AppleWin target). Honestly,
I don't know exactly why the errors occur. I just simply followed
other cases like ContentExtensionRule.h. But today I realized
through webkit.org/b/150300 that our Visual Studio projects are
not being managed well, so I think the root cause of the problem
might be elsewhere.

> It's not common to use guards for include statements.

I agree with your point, but I can find so many cases like this
in our codebase. How do I understand this?