Bug 150299 - [GTK] Remove WebKitContextMenu related missing annotation warnings
Summary: [GTK] Remove WebKitContextMenu related missing annotation warnings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joonghun Park
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-18 05:01 PDT by Joonghun Park
Modified: 2015-10-24 12:50 PDT (History)
6 users (show)

See Also:


Attachments
Patch (1.74 KB, patch)
2015-10-18 05:12 PDT, Joonghun Park
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joonghun Park 2015-10-18 05:01:14 PDT
The warnings below occurs currently, because when executing g-ir-scanner, it doesn't consider WebKitContextMenu related cpp files, but only h files.

Source/WebKit2/UIProcess/API/gtk/WebKitContextMenuItem.h:81: Warning: WebKit2WebExtension: webkit_context_menu_item_get_action: return value: Missing (transfer) annotation
Source/WebKit2/UIProcess/API/gtk/WebKitContextMenuItem.h:94: Warning: WebKit2WebExtension: webkit_context_menu_item_get_submenu: return value: Missing (transfer) annotation
Source/WebKit2/UIProcess/API/gtk/WebKitContextMenu.h:86: Warning: WebKit2WebExtension: webkit_context_menu_get_items: return value: Missing (element-type) annotation
Source/WebKit2/UIProcess/API/gtk/WebKitContextMenu.h:92: Warning: WebKit2WebExtension: webkit_context_menu_first: return value: Missing (transfer) annotation
Source/WebKit2/UIProcess/API/gtk/WebKitContextMenu.h:95: Warning: WebKit2WebExtension: webkit_context_menu_last: return value: Missing (transfer) annotation
Source/WebKit2/UIProcess/API/gtk/WebKitContextMenu.h:98: Warning: WebKit2WebExtension: webkit_context_menu_get_item_at_position: return value: Missing (transfer) annotation
Source/WebKit2/UIProcess/API/gtk/WebKitContextMenu.h:66: Warning: WebKit2WebExtension: webkit_context_menu_new_with_items: argument items: Missing (element-type) annotation
Comment 1 Joonghun Park 2015-10-18 05:12:37 PDT
Created attachment 263417 [details]
Patch
Comment 2 WebKit Commit Bot 2015-10-18 16:48:18 PDT
Comment on attachment 263417 [details]
Patch

Clearing flags on attachment: 263417

Committed r191272: <http://trac.webkit.org/changeset/191272>
Comment 3 WebKit Commit Bot 2015-10-18 16:48:22 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Carlos Garcia Campos 2015-10-18 22:51:48 PDT
I always wondered why those warnings happened only when building the extensions gir, thanks!
Comment 5 Joonghun Park 2015-10-18 23:06:20 PDT
(In reply to comment #4)
> I always wondered why those warnings happened only when building the
> extensions gir, thanks!

It was my pleasure :)
Comment 6 Michael Catanzaro 2015-10-24 12:50:34 PDT
(In reply to comment #4)
> I always wondered why those warnings happened only when building the
> extensions gir, thanks!

Yeah, this one had stumped me too; thanks Joonghun!