uint64_t implementation can be differ in each platform. It leads to build failure in some platform, for example Ubuntu. So type casting is needed to match the argument type to the string format in LOG call.
Created attachment 263373 [details] Patch
I don't think type casting is right solution here. I would suggest to use PRIu64 macro. So, the fix will be: #define __STDC_FORMAT_MACROS #include <inttypes.h> LOG(IndexedDB, "IDBDatabase::fireVersionChangeEvent - current version %"PRIu64", requested version %"PRIu64, currentVersion, requestedVersion);
(In reply to comment #2) > I don't think type casting is right solution here. > I would suggest to use PRIu64 macro. > > So, the fix will be: > > #define __STDC_FORMAT_MACROS > #include <inttypes.h> > > > LOG(IndexedDB, "IDBDatabase::fireVersionChangeEvent - current version > %"PRIu64", requested version %"PRIu64, currentVersion, requestedVersion); Thank you for your advice :) Your solution is the right one. I will apply your comment right away.
Created attachment 263422 [details] Patch
Comment on attachment 263422 [details] Patch Clearing flags on attachment: 263422 Committed r191265: <http://trac.webkit.org/changeset/191265>
All reviewed patches have been landed. Closing bug.