Bug 150277 - [EFL] Fix debug build break since r191198
Summary: [EFL] Fix debug build break since r191198
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joonghun Park
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-17 07:55 PDT by Joonghun Park
Modified: 2015-10-18 16:29 PDT (History)
6 users (show)

See Also:


Attachments
Patch (1.92 KB, patch)
2015-10-17 07:58 PDT, Joonghun Park
no flags Details | Formatted Diff | Diff
Patch (5.83 KB, patch)
2015-10-18 08:47 PDT, Joonghun Park
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joonghun Park 2015-10-17 07:55:40 PDT
uint64_t implementation can be differ in each platform. It leads to build failure in some platform, for example Ubuntu.
So type casting is needed to match the argument type to the string format in LOG call.
Comment 1 Joonghun Park 2015-10-17 07:58:59 PDT
Created attachment 263373 [details]
Patch
Comment 2 Viatcheslav Ostapenko 2015-10-18 06:57:33 PDT
I don't think type casting is right solution here.
I would suggest to use PRIu64 macro.

So, the fix will be:

#define __STDC_FORMAT_MACROS
#include <inttypes.h>


LOG(IndexedDB, "IDBDatabase::fireVersionChangeEvent - current version %"PRIu64", requested version %"PRIu64, currentVersion, requestedVersion);
Comment 3 Joonghun Park 2015-10-18 08:12:23 PDT
(In reply to comment #2)
> I don't think type casting is right solution here.
> I would suggest to use PRIu64 macro.
> 
> So, the fix will be:
> 
> #define __STDC_FORMAT_MACROS
> #include <inttypes.h>
> 
> 
> LOG(IndexedDB, "IDBDatabase::fireVersionChangeEvent - current version
> %"PRIu64", requested version %"PRIu64, currentVersion, requestedVersion);

Thank you for your advice :) Your solution is the right one.
I will apply your comment right away.
Comment 4 Joonghun Park 2015-10-18 08:47:32 PDT
Created attachment 263422 [details]
Patch
Comment 5 WebKit Commit Bot 2015-10-18 16:29:54 PDT
Comment on attachment 263422 [details]
Patch

Clearing flags on attachment: 263422

Committed r191265: <http://trac.webkit.org/changeset/191265>
Comment 6 WebKit Commit Bot 2015-10-18 16:29:58 PDT
All reviewed patches have been landed.  Closing bug.