RESOLVED FIXED 150269
Enhance TextStream for logging, remove subclasses, log more things 
https://bugs.webkit.org/show_bug.cgi?id=150269
Summary Enhance TextStream for logging, remove subclasses, log more things
Simon Fraser (smfr)
Reported 2015-10-16 22:35:11 PDT
Enhance TextStream for logging, remove subclasses, log more things
Attachments
Patch (126.54 KB, patch)
2015-10-16 22:39 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (126.91 KB, patch)
2015-10-16 23:10 PDT, Simon Fraser (smfr) 		zalan: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2015-10-16 22:39:33 PDT
Created attachment 263359 [details] Patch
Simon Fraser (smfr)
Comment 2 2015-10-16 23:10:14 PDT
Created attachment 263361 [details] Patch
Myles C. Maxfield
Comment 3 2015-10-17 11:01:42 PDT
Comment on attachment 263361 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=263361&action=review LGTM, but i'll wait for thorton to r+ it. > Source/WebCore/ChangeLog:58 > + * platform/graphics/ca/PlatformCAAnimation.cpp: Added. Why did you make a new file for this? > Source/WebCore/CMakeLists.txt:2142 > + platform/animation/TimingFunction.cpp Shouldn't there be additions for the new header files? > Source/WebCore/platform/animation/TimingFunction.cpp:1 > +/* Why did you make a new file for this?
Simon Fraser (smfr)
Comment 4 2015-10-17 11:06:46 PDT
(In reply to comment #3) > Comment on attachment 263361 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=263361&action=review > > LGTM, but i'll wait for thorton to r+ it. > > > Source/WebCore/ChangeLog:58 > > + * platform/graphics/ca/PlatformCAAnimation.cpp: Added. > > Why did you make a new file for this? Because there was only the .h file, and I don't want PlatformCAAnimation.h pulling in TextStream.h. > > Source/WebCore/CMakeLists.txt:2142 > > + platform/animation/TimingFunction.cpp > > Shouldn't there be additions for the new header files? Header files are existing. > > Source/WebCore/platform/animation/TimingFunction.cpp:1 > > +/* > > Why did you make a new file for this? Ditto.
Simon Fraser (smfr)
Comment 5 2015-10-17 11:36:57 PDT
https://trac.webkit.org/r191243
Note You need to log in before you can comment on or make changes to this bug.