RESOLVED FIXED 150238
Finalize bug 149952 patch 
https://bugs.webkit.org/show_bug.cgi?id=150238
Summary Finalize bug 149952 patch
youenn fablet
Reported 2015-10-16 10:17:21 PDT
Following on bug 149952, we should fix what Darin mentionned: > Source/WebCore/bindings/js/JSDOMConstructor.h:32 > + static JSC::Structure* createStructure(JSC::VM&, JSC::JSGlobalObject&, JSC::JSValue); I noticed one tiny mistake that we should return and fix. I don’t think the meaning of JSC::JSValue is clear here without the argument name, prototype. > Source/WebCore/bindings/js/JSDOMConstructor.h:137 > +template<typename JSClass> void JSDOMConstructor<JSClass>::finishCreation(JSC::VM& vm, JSDOMGlobalObject& globalObject) In the final patch you landed this was one of the only function templates without “inline”. Was that intentional? If not, I suggest adding the inline. > Source/WebCore/bindings/js/JSDOMConstructor.h:144 > +template<typename JSClass> JSC::ConstructType JSDOMConstructor<JSClass>::getConstructData(JSC::JSCell*, JSC::ConstructData& constructData) In the final patch you landed this was one of the only function templates without “inline”. Was that intentional? If not, I suggest adding the inline.
Attachments
Patch (3.50 KB, patch)
2015-10-16 10:24 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2015-10-16 10:24:15 PDT
Created attachment 263283 [details] Patch
WebKit Commit Bot
Comment 2 2015-10-17 00:10:48 PDT
Comment on attachment 263283 [details] Patch Clearing flags on attachment: 263283 Committed r191238: <http://trac.webkit.org/changeset/191238>
WebKit Commit Bot
Comment 3 2015-10-17 00:10:52 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.