Bug 150237 - Computed style should work correctly with slotted elements that have display:none
Summary: Computed style should work correctly with slotted elements that have display:...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 150263
Blocks: 148695
  Show dependency treegraph
 
Reported: 2015-10-16 10:14 PDT by Antti Koivisto
Modified: 2015-10-18 15:16 PDT (History)
7 users (show)

See Also:


Attachments
patch (16.41 KB, patch)
2015-10-16 11:15 PDT, Antti Koivisto
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-mavericks (693.75 KB, application/zip)
2015-10-16 11:53 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews106 for mac-mavericks-wk2 (1018.48 KB, application/zip)
2015-10-16 11:54 PDT, Build Bot
no flags Details
patch (17.81 KB, patch)
2015-10-16 12:06 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff
patch (18.86 KB, patch)
2015-10-18 14:42 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2015-10-16 10:14:25 PDT
If an element has display:none we don't normally retain or even compute its style (as it is not rendered). If getComputedStyle is invoked for such element we resolve the style (along with any ancestors) and cache it separately to rare data. This path needs to work with slotted elements in shadow trees.
Comment 1 Antti Koivisto 2015-10-16 11:15:48 PDT
Created attachment 263296 [details]
patch
Comment 2 Build Bot 2015-10-16 11:53:10 PDT
Comment on attachment 263296 [details]
patch

Attachment 263296 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/296425

New failing tests:
editing/style/apply-style-atomic.html
Comment 3 Build Bot 2015-10-16 11:53:14 PDT
Created attachment 263302 [details]
Archive of layout-test-results from ews103 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 4 Build Bot 2015-10-16 11:54:48 PDT
Comment on attachment 263296 [details]
patch

Attachment 263296 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/296412

New failing tests:
editing/style/apply-style-atomic.html
Comment 5 Build Bot 2015-10-16 11:54:51 PDT
Created attachment 263303 [details]
Archive of layout-test-results from ews106 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 6 Antti Koivisto 2015-10-16 12:06:07 PDT
Created attachment 263304 [details]
patch
Comment 7 Andreas Kling 2015-10-16 12:13:55 PDT
Comment on attachment 263304 [details]
patch

r=me
Comment 8 WebKit Commit Bot 2015-10-16 13:51:00 PDT
Comment on attachment 263304 [details]
patch

Clearing flags on attachment: 263304

Committed r191204: <http://trac.webkit.org/changeset/191204>
Comment 9 WebKit Commit Bot 2015-10-16 13:51:05 PDT
All reviewed patches have been landed.  Closing bug.
Comment 10 Ryan Haddad 2015-10-16 15:52:28 PDT
This appears to have caused fast/forms/select-live-pseudo-selectors.html to crash on mac debug builds.

http://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fforms%2Fselect-live-pseudo-selectors.html
Comment 11 Ryan Haddad 2015-10-16 15:58:46 PDT
platform/mac/fast/objc/dom-html-select-live-pseudo-selectors.html is crashing as well on wk1 debug

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=platform%2Fmac%2Ffast%2Fobjc%2Fdom-html-select-live-pseudo-selectors.html
Comment 12 Antti Koivisto 2015-10-18 14:42:10 PDT
Created attachment 263428 [details]
patch
Comment 13 Antti Koivisto 2015-10-18 15:16:50 PDT
https://trac.webkit.org/r191262