RESOLVED FIXED 150237
Computed style should work correctly with slotted elements that have display:none 
https://bugs.webkit.org/show_bug.cgi?id=150237
Summary Computed style should work correctly with slotted elements that have display:...
Antti Koivisto
Reported 2015-10-16 10:14:25 PDT
If an element has display:none we don't normally retain or even compute its style (as it is not rendered). If getComputedStyle is invoked for such element we resolve the style (along with any ancestors) and cache it separately to rare data. This path needs to work with slotted elements in shadow trees.
Attachments
patch (16.41 KB, patch)
2015-10-16 11:15 PDT, Antti Koivisto 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews103 for mac-mavericks (693.75 KB, application/zip)
2015-10-16 11:53 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from ews106 for mac-mavericks-wk2 (1018.48 KB, application/zip)
2015-10-16 11:54 PDT, Build Bot 		no flags
Details
patch (17.81 KB, patch)
2015-10-16 12:06 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (18.86 KB, patch)
2015-10-18 14:42 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2015-10-16 11:15:48 PDT
Created attachment 263296 [details] patch
Build Bot
Comment 2 2015-10-16 11:53:10 PDT
Comment on attachment 263296 [details] patch Attachment 263296 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/296425 New failing tests: editing/style/apply-style-atomic.html
Build Bot
Comment 3 2015-10-16 11:53:14 PDT
Created attachment 263302 [details] Archive of layout-test-results from ews103 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-mavericks Platform: Mac OS X 10.9.5
Build Bot
Comment 4 2015-10-16 11:54:48 PDT
Comment on attachment 263296 [details] patch Attachment 263296 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/296412 New failing tests: editing/style/apply-style-atomic.html
Build Bot
Comment 5 2015-10-16 11:54:51 PDT
Created attachment 263303 [details] Archive of layout-test-results from ews106 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Antti Koivisto
Comment 6 2015-10-16 12:06:07 PDT
Created attachment 263304 [details] patch
Andreas Kling
Comment 7 2015-10-16 12:13:55 PDT
Comment on attachment 263304 [details] patch r=me
WebKit Commit Bot
Comment 8 2015-10-16 13:51:00 PDT
Comment on attachment 263304 [details] patch Clearing flags on attachment: 263304 Committed r191204: <http://trac.webkit.org/changeset/191204>
WebKit Commit Bot
Comment 9 2015-10-16 13:51:05 PDT
All reviewed patches have been landed. Closing bug.
Ryan Haddad
Comment 10 2015-10-16 15:52:28 PDT
This appears to have caused fast/forms/select-live-pseudo-selectors.html to crash on mac debug builds. http://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fforms%2Fselect-live-pseudo-selectors.html
Ryan Haddad
Comment 11 2015-10-16 15:58:46 PDT
platform/mac/fast/objc/dom-html-select-live-pseudo-selectors.html is crashing as well on wk1 debug https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=platform%2Fmac%2Ffast%2Fobjc%2Fdom-html-select-live-pseudo-selectors.html
Antti Koivisto
Comment 12 2015-10-18 14:42:10 PDT
Created attachment 263428 [details] patch
Antti Koivisto
Comment 13 2015-10-18 15:16:50 PDT
https://trac.webkit.org/r191262
Note You need to log in before you can comment on or make changes to this bug.