Bug 150219 - Hook up autolayout intrinsic sizing for WKWebView
Summary: Hook up autolayout intrinsic sizing for WKWebView
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-15 19:35 PDT by Tim Horton
Modified: 2015-10-16 10:31 PDT (History)
4 users (show)

See Also:

Attachments
Patch (21.56 KB, patch)
2015-10-15 19:39 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (21.31 KB, patch)
2015-10-15 19:43 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (21.45 KB, patch)
2015-10-16 10:05 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (21.46 KB, patch)
2015-10-16 10:24 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (21.48 KB, patch)
2015-10-16 10:28 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2015-10-15 19:35:18 PDT 
Hook up autolayout intrinsic sizing for WKWebView
Comment 1 Tim Horton 2015-10-15 19:39:30 PDT 
Created attachment 263238 [details]
Patch
Comment 2 Tim Horton 2015-10-15 19:43:08 PDT 
Created attachment 263239 [details]
Patch
Comment 3 Tim Horton 2015-10-16 10:05:13 PDT 
Created attachment 263280 [details]
Patch
Comment 4 Tim Horton 2015-10-16 10:06:11 PDT 
Comment on attachment 263280 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=263280&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:719
> +        intrinsicContentSizeAcknowledgingFlexibleWidth.width = NSViewNoInstrinsicMetric;

This one needs to be noIntrinsicMetric too.
Comment 5 Tim Horton 2015-10-16 10:24:57 PDT 
Created attachment 263285 [details]
Patch
Comment 6 Anders Carlsson 2015-10-16 10:26:16 PDT 
Comment on attachment 263285 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=263285&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:189
> +@property (nonatomic, setter=_setMinimumLayoutWidth:) CGFloat _minimumLayoutWidth;

Needs WK_AVAILABLE
Comment 7 Tim Horton 2015-10-16 10:28:38 PDT 
Created attachment 263286 [details]
Patch
Comment 8 Tim Horton 2015-10-16 10:31:29 PDT 
http://trac.webkit.org/changeset/191183