Bug 150162 - Implement iterator for traversing composed ancestors
Summary: Implement iterator for traversing composed ancestors
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 148695
  Show dependency tree / graph
 
Reported: 2015-10-15 05:24 PDT by Antti Koivisto
Modified: 2015-10-15 08:13 PDT (History)
10 users (show)

See Also:

Attachments
patch (28.41 KB, patch)
2015-10-15 05:42 PDT, Antti Koivisto 		buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-mavericks (895.72 KB, application/zip)
2015-10-15 06:26 PDT, Build Bot 		no flags Details
patch (28.49 KB, patch)
2015-10-15 06:27 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2015-10-15 05:24:32 PDT 
The existing general purpose iterator can traverse parent chain but not efficiently (since it builds stack). Add a separate stackless iterator for ancestor chain traversal.
Comment 1 Antti Koivisto 2015-10-15 05:42:33 PDT 
Created attachment 263145 [details]
patch
Comment 2 Build Bot 2015-10-15 06:26:28 PDT 
Comment on attachment 263145 [details]
patch

Attachment 263145 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/290839

Number of test failures exceeded the failure limit.
Comment 3 Build Bot 2015-10-15 06:26:32 PDT 
Created attachment 263149 [details]
Archive of layout-test-results from ews102 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 4 Antti Koivisto 2015-10-15 06:27:10 PDT 
Created attachment 263150 [details]
patch
Comment 5 Andreas Kling 2015-10-15 07:16:56 PDT 
Comment on attachment 263150 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=263150&action=review

r=me

> Source/WebCore/dom/Node.h:618
> +        // HeyItIsAFreeBit = 1 << 22,

Nice.
Comment 6 WebKit Commit Bot 2015-10-15 08:13:16 PDT 
Comment on attachment 263150 [details]
patch

Clearing flags on attachment: 263150

Committed r191112: <http://trac.webkit.org/changeset/191112>
Comment 7 WebKit Commit Bot 2015-10-15 08:13:23 PDT 
All reviewed patches have been landed.  Closing bug.