Bug 150152 - [iOS] build-dumprendertree does not build ImageDiff
Summary: [iOS] build-dumprendertree does not build ImageDiff
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: iPhone / iPad All
: P2 Normal
Assignee: Andy Estes
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-14 17:46 PDT by Andy Estes
Modified: 2015-10-14 20:57 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.97 KB, patch)
2015-10-14 17:53 PDT, Andy Estes 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2015-10-14 17:46:10 PDT 
[iOS] build-dumprendertree does not build ImageDiff
Comment 1 Andy Estes 2015-10-14 17:53:33 PDT 
Created attachment 263125 [details]
Patch
Comment 2 Andy Estes 2015-10-14 17:58:16 PDT 
Committed r191078: <http://trac.webkit.org/changeset/191078>
Comment 3 Alexey Proskuryakov 2015-10-14 20:26:13 PDT 
Does this mean that we will be building ImageDiff for iOS (simulator) instead of the host OS? I do not fully understand the setup yet, but this sounds wrong. 

One thing that's built for the host is LayoutTestRelay.
Comment 4 Andy Estes 2015-10-14 20:57:25 PDT 
We have always(In reply to comment #3)
> Does this mean that we will be building ImageDiff for iOS (simulator)
> instead of the host OS? I do not fully understand the setup yet, but this
> sounds wrong. 

I don't know if it's right, but we do build ImageDiff for iOS Simulator and run it in the sim bootstrap (see http://trac.webkit.org/changeset/172118). This just brings build-dumprendertree in line with what is built by make and the 'All Tools' scheme.